Meredith Lancaster
ddb8855198
flip bundle fetching logic
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-30 09:12:48 -07:00
Andy Feller
a6c9c511ea
Merge pull request #10319 from cli/dependabot/go_modules/github.com/in-toto/attestation-1.1.1
...
Bump github.com/in-toto/attestation from 1.1.0 to 1.1.1
2025-01-30 08:44:34 -05:00
Andy Feller
068f92b474
Merge pull request #10324 from hoffm/view-autolinks
...
feat: Add support for viewing autolink references
2025-01-30 08:42:41 -05:00
Michael Hoffman
d609c40404
Merge branch 'trunk' into view-autolinks
2025-01-29 16:43:23 -05:00
Michael Hoffman
b23cf6e8d7
Update formatting for autolink output
2025-01-29 16:24:47 -05:00
Tyler McGoffin
de9971d718
Merge pull request #9208 from Frederick888/find-pr-by-rev-parse-push
...
Find PRs using `@{push}`
2025-01-29 12:11:32 -08:00
Tyler McGoffin
15783a6be5
Merge pull request #10323 from iamazeem/stop-progress-indicator-on-failure-for-run-list
...
[gh run list] Stop progress indicator on failure from `--workflow` flag
2025-01-29 11:57:11 -08:00
Tyler McGoffin
e0f624ba24
Rename PRRefs to PullRequestRefs and PR comment cleanup
2025-01-29 11:56:31 -08:00
Michael Hoffman
e4d720ba22
Remove redundant error check
2025-01-29 11:12:28 -05:00
Michael Hoffman
9725a32f3e
Merge branch 'trunk' into view-autolinks
2025-01-29 10:52:00 -05:00
Andy Feller
fe21e10ae8
Keeping autolink IDs the same in all test cases
2025-01-29 10:16:02 -05:00
Andy Feller
af538b277d
Expand test case
...
- add autolink view case for numeric
- simplifying local variable usage
2025-01-29 10:10:42 -05:00
Michael Hoffman
21a5267be4
Remove unused test field
2025-01-29 09:35:05 -05:00
Michael Hoffman
8b7d6d1b3f
Remove unused test field
2025-01-29 09:34:29 -05:00
Azeem Sajid
ab2455c848
Merge branch 'trunk' into stop-progress-indicator-on-failure-for-run-list
2025-01-29 08:23:07 +05:00
Azeem Sajid
de7c40789e
Use defer instead
2025-01-29 08:22:32 +05:00
Tyler McGoffin
75a23e73eb
Merge pull request #10309 from cli/update-sigstore-go-v0.7.0
...
Upgrade sigstore-go to v0.7.0: fixes #10114 formatting issue
2025-01-28 15:00:43 -08:00
Michael Hoffman
8f55dbcf61
Error case test for viewRun
2025-01-28 14:07:48 -05:00
Michael Hoffman
32ee4db484
Autolink view HTTP tests
2025-01-28 13:33:50 -05:00
Michael Hoffman
58d84a4088
Shorten description
2025-01-28 12:03:03 -05:00
Michael Hoffman
11ce0c661c
Updates following renaming domain to shared
2025-01-28 11:43:57 -05:00
Michael Hoffman
f941608091
Partial testing for view
2025-01-28 11:43:57 -05:00
Michael Hoffman
e8475d9fb8
Initial, working implementation
2025-01-28 11:43:57 -05:00
Azeem Sajid
359b4a1d63
Stop progress indicator on failure (gh run list --workflow)
2025-01-28 17:18:30 +05:00
Tyler McGoffin
e31bfd0092
Cleaned up some naming and comments
2025-01-27 16:40:47 -08:00
Andy Feller
b0cd1fb655
Merge pull request #10180 from hoffm/create-autolinks
...
feat: Add support for creating autolink references
2025-01-27 18:01:34 -05:00
Andy Feller
7c31d1a76b
Minor refactoring autolink create help and logic
...
- simplified and wrapped `gh repo autolink create` and `gh repo autolink` long help usage docs
- simplified success message, brought into alignment with other commands
2025-01-27 17:47:55 -05:00
dependabot[bot]
532be61d6b
Bump github.com/in-toto/attestation from 1.1.0 to 1.1.1
...
Bumps [github.com/in-toto/attestation](https://github.com/in-toto/attestation ) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/in-toto/attestation/releases )
- [Commits](https://github.com/in-toto/attestation/compare/v1.1.0...v1.1.1 )
---
updated-dependencies:
- dependency-name: github.com/in-toto/attestation
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-01-27 14:35:50 +00:00
Michael Hoffman
965782a444
Merge branch 'trunk' into create-autolinks
2025-01-25 16:03:19 -05:00
Tyler McGoffin
7fcb4453ed
Merge pull request #10121 from cli/jtmcg/add-tagname-enforcement-to-deployment-workflow
...
Add job to deployment workflow to validate the tag name for a given release
2025-01-24 14:31:59 -08:00
Tyler McGoffin
62106dc800
Cleanup comment
2025-01-24 14:18:20 -08:00
Tyler McGoffin
4382bdf072
Fix pr create tests
...
Due to the refactor of BranchConfig, the tests for `pr create` no longer
require a handful of stubbed git commands.
Additionally, I noticed some overlap between `pr create`'s existing logic
with the new finder code. I suspect that the finder's new ParsePRRefs
helper could be leveraged here as well, which would allow us to respect
non-centralized workflows pr create in the same way we are respecting them
in `gh pr view` and `gh pr status`
2025-01-24 14:01:44 -08:00
Cody Soyland
6a629ed871
Fix breaking changes from sigstore-go v0.7.0 upgrade
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2025-01-24 16:35:31 -05:00
Cody Soyland
d60c4fbd7b
go mod tidy
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2025-01-24 16:26:49 -05:00
Cody Soyland
b582b5830b
Upgrade sigstore-go to v0.7.0: fixes #10114 formatting issue
...
Signed-off-by: Cody Soyland <codysoyland@github.com>
2025-01-24 16:24:00 -05:00
Tyler McGoffin
d684834ad9
Refactor pr status to use the ParsePRRefs helper on the Finder
...
There was a lot of copy-pasta code between the finder and pr status. After
some investigation it was clear that the prSelectorForCurrentBranch code
was really just a duplicate of the finder's code without actually making
the API call for the PR. Since the ParsePRRefs helper had already
extracted much of the logic for determining a PR's head ref branch, I was
able to reuse it in gh pr status with a small refactor.
2025-01-24 11:51:49 -08:00
Tyler McGoffin
cdead50d57
Moved remote.pushDefault out of ReadBranchConfig and into finder
2025-01-24 11:05:15 -08:00
Tyler McGoffin
e4d8ed0e60
Remove @{push} from branch config
2025-01-24 10:20:04 -08:00
Tyler McGoffin
5a8dd35ba7
Add PushDefault method to git client
2025-01-24 09:40:02 -08:00
William Martin
07ab59d2b5
Merge pull request #10306 from cli/dependabot/go_modules/google.golang.org/protobuf-1.36.4
...
Bump google.golang.org/protobuf from 1.36.3 to 1.36.4
2025-01-24 17:50:09 +01:00
William Martin
6355ed7c08
WIP: push default defaults to simple
2025-01-24 17:25:38 +01:00
Meredith Lancaster
77cc1b17bd
Merge pull request #10102 from malancas/more-attestation-cmd-integration-tests
...
Add more `gh attestation verify` integration tests
2025-01-24 09:14:32 -07:00
William Martin
a72bef9b42
Error if push revision doesn't match a remote
2025-01-24 17:07:24 +01:00
dependabot[bot]
9f801771a8
Bump google.golang.org/protobuf from 1.36.3 to 1.36.4
...
Bumps google.golang.org/protobuf from 1.36.3 to 1.36.4.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-01-24 14:49:07 +00:00
Andy Feller
c23a2834c7
Merge pull request #10297 from dennisameling/windows-arm64-msi
...
Enable MSI building for Windows arm64
2025-01-24 08:04:35 -05:00
William Martin
c33275a4dc
Merge pull request #10300 from cli/dependabot/github_actions/actions/attest-build-provenance-2.2.0
...
Bump actions/attest-build-provenance from 2.1.0 to 2.2.0
2025-01-24 11:59:00 +01:00
Tyler McGoffin
41729b004d
Refactor finder.Find and replace parseCurrentBranch with parsePRRefs
...
I've been struggling horribly to reason through all of this code, and
after much mental gymnastics I identified the culprit as the overloaded
"branch" string returned by parseCurrentBranch.
This value was either the name of the branch that the PR we're looking for
is associated with, or that name prepended with the owner's name and a :
if we're on a branch, so:
PR branch: featureBranch
branch == "featureBranch"
If on Fork belonging to "ForkOwner"
branch == "ForkOwner:featureBranch"
Since this extra information was bundled up into this single string, it
complicated the responsibilities of parseCurrentBranch's "branch" return
value. Thus, I've teased out "branch" into the new PRRefs struct:
type PRRefs struct{
BranchName string
HeadRepo ghrepo.Interface
BaseRepo ghrepo.Interface
}
This allows the new parsePRRefs function to move all the previous
"branch" string's information into structured data, and allows for a new
method on PRRefs, GetPRLabel(), to create the string that "branch"
previously held to pass into its downstream consumer, namely
findForBranch.
This also allowed for better test coverage, directly connecting the PRRefs
fields to the values contained in the git config. Overall, I am now
confident that this is doing what its supposed to do with respect to my
understanding of the various central and triangular git workflows we are
addressing.
2025-01-23 15:25:28 -08:00
Meredith Lancaster
c0c1618e50
Merge pull request #10104 from malancas/update-attestation-verify-table-output
...
Update `gh attestation verify` table output
2025-01-23 12:38:55 -07:00
Michael Hoffman
363bfd9520
Merge branch 'trunk' into create-autolinks
2025-01-23 12:55:30 -05:00
dependabot[bot]
fe3d18c96a
Bump actions/attest-build-provenance from 2.1.0 to 2.2.0
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](7668571508...520d128f16
2025-01-23 14:53:49 +00:00
