Meredith Lancaster
e97d01f265
use different file name for attestation files on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-09 17:32:55 -07:00
Uday R
8afb434e59
test(gh run): assert branch names are enclosed in square brackets
2024-12-09 12:45:36 -05:00
Kynan Ware
167e868fe2
docs: enhance help text and prompt for rename command
2024-12-09 10:16:38 -07:00
Mateus Marquezini
a7dceb345a
Merge branch 'fix/issue_10042' of github.com:mateusmarquezini/cli into fix/issue_10042
2024-12-09 11:00:01 -03:00
Mateus Marquezini
b740486b13
#10042 fixed test
2024-12-09 10:59:09 -03:00
William Martin
54a7f4de70
Revert "Confirm auto-detected base branch"
...
This reverts commit e021a07285 .
2024-12-09 13:01:00 +01:00
Mateus Marquezini
a3cf4e1c2d
Merge branch 'trunk' into fix/issue_10042
2024-12-09 08:42:57 -03:00
Mateus Marquezini
cbaaf77822
fixing gh gist view prompts with no TTY
2024-12-09 08:35:01 -03:00
Heath Stewart
e021a07285
Confirm auto-detected base branch
...
If interactive, confirm the automatically configured gh-merge-branch or, if not configured, the default branch.
Based on PR feedback.
2024-12-08 22:27:00 -08:00
Heath Stewart
5da86e07e7
Merge changes from #10004
...
Merges changes from @williammartin including acceptance tests and word changes.
Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Andy Feller
a6b8bec70d
Remove unnecessary Extension.FullName()
2024-12-08 21:17:26 -05:00
Heath Stewart
88b96f411c
Set gh-merge-base from issue develop
2024-12-08 17:40:03 -08:00
Heath Stewart
3d139019f8
Open PR against gh-merge-base
...
Partly resolves issue #8979 by checking for a `gh-merge-base` branch tag and using that as though it were passed to `gh pr create --base`.
2024-12-08 17:40:00 -08:00
Andrew Feller
a55f50b115
Remove Extension.FullName() from interface
...
- this was something I did in the original implementation of this improved extension update notification logic
- discovering other parts of the extension manager code that were working with non-prefixed extension names motivated a different approach
- the extension manager code that requires the extension be prefixed has been enhanced to use the centralized ensurePrefixed() logic, making the need for this on the extension unnecessary
2024-12-08 20:01:26 -05:00
Andrew Feller
97630fe73c
Enhance extension manager and tests
...
- extension manager has been made responsible for extension update directory information
- extension manager has been enhanced to ensure that previously left extension update metadata is deleted before installing an extension
- extension manager has been enhanced to ensure that extension update metadata is deleted when extension is being removed
- refactored extension command tests for manager change, ensuring previous and expected states along with returned release info
- refactored extension manager tests for ensuring previous extension update entries are removed before installing extension
- created extension manager test for installing local extension
- centralized logic for checking and ensuring extension name is "gh-" prefixed
2024-12-08 19:40:24 -05:00
Kynan Ware
b2ab7b84f8
Refactor extension executable error handling
2024-12-08 15:55:09 -07:00
Uday R
463105d648
fix: list branches in square brackets in gh run view ( #10038 )
2024-12-08 12:33:08 -05:00
ANKDDEV
3e0703571e
Merge branch 'cli:trunk' into better-document-auth-scopes
2024-12-07 09:54:58 +03:00
ANKDDEV
a4923de755
docs: update description of command
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 20:43:54 +03:00
ANKDDEV
0653a5a09c
style: reformat files
2024-12-06 20:04:15 +03:00
ANKDDEV
0e5f26449d
docs: update sentence case
...
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 19:38:26 +03:00
Meredith Lancaster
67798b06c0
use github owned oci image
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-06 08:32:16 -07:00
ANKDDEV
24db9f64c7
docs: add mention of scopes help topic in auth refresh command help
2024-12-06 17:06:19 +03:00
ANKDDEV
53ee6ae56f
docs: add mention of scopes help topic in auth login command help
2024-12-06 17:04:59 +03:00
ANKDDEV
419a01271a
docs: add help topic for auth scopes
2024-12-06 17:03:31 +03:00
ANKDDEV
694e209142
docs: improve help for browse command
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-06 16:33:57 +03:00
ANKDDEV
3e647385f7
docs: improve docs for browse command as of #5352
2024-12-06 13:45:22 +03:00
Andy Feller
d60e5ffba3
Merge pull request #10016 from cli/andyfeller/cli-cli-10013-pr-checks-json-watch-mutex
...
Error for mutually exclusive json and watch flags
2024-12-05 12:22:24 -05:00
Meredith Lancaster
2b7c6f6a16
add integration test for bundle-from-oci option
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:58:27 -07:00
Andy Feller
acfdae466e
Merge pull request #10009 from cli/wm/safepaths
...
Use safepaths for run download
2024-12-05 11:43:10 -05:00
Meredith Lancaster
2137a483de
include alg with digest when fetching bundles from OCI
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:27:14 -07:00
Andy Feller
c9ecf310b3
Error for mutually exclusive json and watch flags
...
Closes #10013
This commit enhances `gh pr checks` to exit with an error when mutually exclusive `--json` and `--watch` flags are used. Users are encouraged to either 1) retrieve information about the checks via `--json` or 2) watch and wait on PR checks that are being updated.
2024-12-05 10:23:13 -05:00
Meredith Lancaster
b4dfc9fc72
update tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-04 14:59:10 -07:00
Meredith Lancaster
ee05325e1d
update tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-04 14:48:44 -07:00
Meredith Lancaster
4810fc2a74
move content of veriy policy options function into enforcement criteria
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-04 14:30:32 -07:00
William Martin
9bd8f09774
Use safepaths for run download
2024-12-04 22:12:58 +01:00
William Martin
a47b4c9f1d
Use consistent slice ordering in run download tests
2024-12-04 13:02:25 +01:00
Tyler McGoffin
1136764c36
Merge commit from fork
...
The fix
2024-12-03 15:12:05 -08:00
Meredith Lancaster
3b043f6350
comment
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:37:42 -07:00
Meredith Lancaster
efca3bdfd9
try switch statement
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:34:33 -07:00
Meredith Lancaster
2a6ee87ba0
remove duplicate err checking
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:29:35 -07:00
Meredith Lancaster
f0f86ecd23
get bundle issuer in another func
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:22:56 -07:00
Meredith Lancaster
d737d3b933
more logic updating to remove nesting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 12:19:28 -07:00
Meredith Lancaster
1ffd22565d
inverse logic for less nesting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 11:52:08 -07:00
Andy Feller
8720479b0b
Consolidate logic for isolating artifacts
2024-12-03 13:33:00 -05:00
Meredith Lancaster
6a7243bb7b
remove unneeded nesting
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-03 10:54:22 -07:00
Phill MV
963a6fe8fa
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-12-03 11:52:46 -05:00
William Martin
7c241cf4e6
Merge pull request #9992 from cli/wm/fix-pr-checkout-panic
...
Fix PR checkout panic when base repo is not in remotes
2024-12-03 14:04:32 +01:00
William Martin
694e565384
Fix PR checkout panic when base repo is not in remotes
2024-12-02 17:20:57 +01:00
Andrew Feller
6bd01d52dd
Initial extension update check testing
...
First pass at implementing basic test around extension state checking behavior, wanting to discus with team about level of testing to perform and whether this is really the right place.
2024-12-01 18:20:55 -05:00