Andy Feller
df0aedbe3c
Update internal/prompter/prompter.go
2025-04-28 11:16:35 -04:00
Andy Feller
2d66877d6c
Update internal/prompter/accessible_prompter_test.go
2025-04-28 11:15:28 -04:00
Andy Feller
9fa00c350b
Update accessible tests based on huh@0.7.0 changes
2025-04-28 10:17:23 -04:00
Andy Feller
a53b6c074c
Assert password and auth token not displayed
...
This commit expands existing tests (thanks to @babakks) to assert whether the echo mode is actually disabled for password and auth token prompts.
2025-04-28 08:55:47 -04:00
Andy Feller
97a3b70599
Update to huh@0.7.0, echo mode changes
...
This commit is the initial change around updating to huh@0.7.0; pre-testing changes.
2025-04-26 12:57:10 -04:00
William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref ( #10863 )
...
* Fix pr create when push.default tracking and no merge ref
* Update pkg/cmd/pr/shared/find_refs_resolution.go
---------
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-24 16:41:14 +00:00
William Martin
c378b18ac7
Merge pull request #10859 from cli/wm-babakks/fix-pr-create-with-remote-tracking-branch-contains-slashes
...
Fix pr create when branch name contains slashes
2025-04-24 15:27:27 +02:00
William Martin
4e68a61a58
Fix pr create when branch name contains slashes
...
Intentionally have not fixed remote names containing slashes because we
want to get a fix out for the vast majority failure case.
2025-04-24 15:14:49 +02:00
Kynan Ware
c0f993aca0
Merge pull request #10846 from cli/kw/accessible-prompter-and-disable-spinners-config
...
`gh config`: add config settings for accessible prompter and disabling spinner
2025-04-23 07:40:10 -06:00
Kynan Ware
5316f052d8
Merge branch 'trunk' into kw/accessible-prompter-and-disable-spinners-config
2025-04-23 07:30:54 -06:00
Kynan Ware
41f94502e3
Merge pull request #10817 from cli/kw/project-query-uses-iostreams-progress-indicator
...
Fix: `project` commands use shared progress indicator
2025-04-23 07:15:54 -06:00
William Martin
bdc0886492
Merge pull request #10819 from cli/wm/projectsv1-deprecation-issue-edit
...
Feature detect v1 projects on issue edit
2025-04-23 14:18:31 +02:00
William Martin
1a15212e4a
Merge pull request #10818 from cli/wm/projectsv1-deprecation-issue-create-web
...
Feature detect v1 projects on web mode issue create
2025-04-23 14:14:43 +02:00
William Martin
2f06fafd1b
Merge pull request #10815 from cli/wm-kw/projectsv1-deprecation-issue-create
...
Feature detect v1 projects on non web-mode `issue create`
2025-04-23 13:31:24 +02:00
Kynan Ware
9463b0ee61
test(prompter): correct typo in accessible prompter name
2025-04-22 17:12:07 -06:00
Kynan Ware
138bccd437
feat(config): add accessible prompter and spinner
2025-04-22 16:50:58 -06:00
William Martin
636453059c
Merge pull request #10813 from cli/wm-kw/projectsv1-deprecation-issue-view
...
Feature detect v1 projects on `issue view`
2025-04-22 17:15:13 +02:00
William Martin
3fc362b279
Merge pull request #10811 from cli/wm/issue-pr-base-repo-resolution
...
Issue commands should parse args early
2025-04-22 15:02:14 +02:00
Andy Feller
e06a368fa9
Merge pull request #10820 from cli/andyfeller/accessible-colors-config
...
Update configuration support for accessible colors
2025-04-21 14:20:48 -04:00
Andy Feller
ac95196748
Fix comment typo
2025-04-21 14:04:53 -04:00
Andy Feller
486c589665
PR feedback to improve config settings docs
2025-04-21 14:04:00 -04:00
Andy Feller
f61961907e
Update configuration support for accessible colors
...
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
2025-04-17 15:57:49 -04:00
Kynan Ware
0ffc887644
Merge pull request #10758 from cli/dependabot/go_modules/google.golang.org/grpc-1.71.1
...
Bump google.golang.org/grpc from 1.71.0 to 1.71.1
2025-04-17 13:35:06 -06:00
William Martin
0aa49b7741
Feature detect v1 projects on issue edit
2025-04-17 21:19:41 +02:00
William Martin
c208b1f075
Feature detect v1 projects on web mode issue create
2025-04-17 21:04:08 +02:00
Kynan Ware
c08425aef1
fix(projects): use iostreams progress indicator
2025-04-17 11:06:27 -06:00
William Martin
c8dd61d837
Feature detect v1 projects on non-interactive issue create
2025-04-17 17:51:38 +02:00
William Martin
5ec2160bc6
Avoid requesting projectCards for issue view
2025-04-17 15:37:48 +02:00
William Martin
fff0e70259
Provide better HTTP Exclude failure messages
2025-04-17 15:37:42 +02:00
William Martin
55d3b1eaa4
Document TestArgParsing
2025-04-17 15:33:44 +02:00
William Martin
cfa90a2c80
Remove old issue lookup funcs
2025-04-17 15:27:40 +02:00
William Martin
81ecbd8e1d
Issue view early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
e474acc2dd
Issue comment early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
455c77add8
Issue unpin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
f55138c896
Issue transfer early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
5c67c1944b
Issue reopen early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
96699329fc
Issue pin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
60f248458c
Issue lock early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
7744e0564f
Issue develop early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
6129b26f9f
Issue delete early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
8b615ec2e6
Issue close early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
aaddcb019d
Issue edit early arg parsing
2025-04-17 15:27:39 +02:00
Andy Feller
0ef0c42665
Merge pull request #10767 from leudz/fix-9749
...
Fix multi pages search for gh search
2025-04-16 16:57:12 -04:00
Kynan Ware
bff4db1309
Merge pull request #10773 from cli/kw/opt-into-no-spinners
...
Introduce option to opt-out of spinners
2025-04-16 14:44:45 -06:00
leudz
4a885899d6
Add comments for Total
2025-04-16 20:46:29 +02:00
Andy Feller
ba390db71f
PR feedback
...
- update local variables to communicate what they are
- added docblock explaining search results populated
2025-04-16 14:22:29 -04:00
Kynan Ware
dabb29bd36
test(factory): remove needless nil check
2025-04-16 11:21:39 -06:00
Kynan Ware
1dbb01a1d1
doc(help): add documentation for GH_SPINNER_DISABLED
2025-04-16 11:17:23 -06:00
Kynan Ware
056d292f26
doc(iostreams): comment behavior of textual progress indicator
2025-04-16 11:13:58 -06:00
Kynan Ware
290e78c904
test(iostreams): update test description
2025-04-16 11:05:36 -06:00