William Martin
fb97b3efaa
Fix pr create when push.default tracking and no merge ref ( #10863 )
...
* Fix pr create when push.default tracking and no merge ref
* Update pkg/cmd/pr/shared/find_refs_resolution.go
---------
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-24 16:41:14 +00:00
Kynan Ware
5316f052d8
Merge branch 'trunk' into kw/accessible-prompter-and-disable-spinners-config
2025-04-23 07:30:54 -06:00
Kynan Ware
41f94502e3
Merge pull request #10817 from cli/kw/project-query-uses-iostreams-progress-indicator
...
Fix: `project` commands use shared progress indicator
2025-04-23 07:15:54 -06:00
William Martin
bdc0886492
Merge pull request #10819 from cli/wm/projectsv1-deprecation-issue-edit
...
Feature detect v1 projects on issue edit
2025-04-23 14:18:31 +02:00
William Martin
1a15212e4a
Merge pull request #10818 from cli/wm/projectsv1-deprecation-issue-create-web
...
Feature detect v1 projects on web mode issue create
2025-04-23 14:14:43 +02:00
William Martin
2f06fafd1b
Merge pull request #10815 from cli/wm-kw/projectsv1-deprecation-issue-create
...
Feature detect v1 projects on non web-mode `issue create`
2025-04-23 13:31:24 +02:00
Kynan Ware
138bccd437
feat(config): add accessible prompter and spinner
2025-04-22 16:50:58 -06:00
William Martin
636453059c
Merge pull request #10813 from cli/wm-kw/projectsv1-deprecation-issue-view
...
Feature detect v1 projects on `issue view`
2025-04-22 17:15:13 +02:00
William Martin
3fc362b279
Merge pull request #10811 from cli/wm/issue-pr-base-repo-resolution
...
Issue commands should parse args early
2025-04-22 15:02:14 +02:00
Andy Feller
f61961907e
Update configuration support for accessible colors
...
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
2025-04-17 15:57:49 -04:00
William Martin
0aa49b7741
Feature detect v1 projects on issue edit
2025-04-17 21:19:41 +02:00
William Martin
c208b1f075
Feature detect v1 projects on web mode issue create
2025-04-17 21:04:08 +02:00
Kynan Ware
c08425aef1
fix(projects): use iostreams progress indicator
2025-04-17 11:06:27 -06:00
William Martin
c8dd61d837
Feature detect v1 projects on non-interactive issue create
2025-04-17 17:51:38 +02:00
William Martin
5ec2160bc6
Avoid requesting projectCards for issue view
2025-04-17 15:37:48 +02:00
William Martin
fff0e70259
Provide better HTTP Exclude failure messages
2025-04-17 15:37:42 +02:00
William Martin
55d3b1eaa4
Document TestArgParsing
2025-04-17 15:33:44 +02:00
William Martin
cfa90a2c80
Remove old issue lookup funcs
2025-04-17 15:27:40 +02:00
William Martin
81ecbd8e1d
Issue view early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
e474acc2dd
Issue comment early arg parsing
2025-04-17 15:27:40 +02:00
William Martin
455c77add8
Issue unpin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
f55138c896
Issue transfer early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
5c67c1944b
Issue reopen early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
96699329fc
Issue pin early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
60f248458c
Issue lock early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
7744e0564f
Issue develop early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
6129b26f9f
Issue delete early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
8b615ec2e6
Issue close early arg parsing
2025-04-17 15:27:39 +02:00
William Martin
aaddcb019d
Issue edit early arg parsing
2025-04-17 15:27:39 +02:00
Andy Feller
0ef0c42665
Merge pull request #10767 from leudz/fix-9749
...
Fix multi pages search for gh search
2025-04-16 16:57:12 -04:00
Kynan Ware
bff4db1309
Merge pull request #10773 from cli/kw/opt-into-no-spinners
...
Introduce option to opt-out of spinners
2025-04-16 14:44:45 -06:00
leudz
4a885899d6
Add comments for Total
2025-04-16 20:46:29 +02:00
Andy Feller
ba390db71f
PR feedback
...
- update local variables to communicate what they are
- added docblock explaining search results populated
2025-04-16 14:22:29 -04:00
Kynan Ware
dabb29bd36
test(factory): remove needless nil check
2025-04-16 11:21:39 -06:00
Kynan Ware
1dbb01a1d1
doc(help): add documentation for GH_SPINNER_DISABLED
2025-04-16 11:17:23 -06:00
Kynan Ware
056d292f26
doc(iostreams): comment behavior of textual progress indicator
2025-04-16 11:13:58 -06:00
Kynan Ware
290e78c904
test(iostreams): update test description
2025-04-16 11:05:36 -06:00
Andy Feller
becd936e7b
Update searcher tests
...
This commit moves the remaining searcher tests from using JSON marshaled types to using JSON responses for consistency. There appears to be a weird JSON marshaling error with search.Repository that does not map `Name` field in the process.
Additionally, the test scenarios around pulling multiple pages beneath the total results have been updated to demonstrate that the REST API returns full pages in both of these cases, which is below the total number of results.
2025-04-15 17:13:43 -04:00
William Martin
a9dbda6913
Rework ref usage when finding and creating PRs
2025-04-15 13:38:10 -06:00
Kynan Ware
028caa3823
docs(pr create): clarify BaseRepo type in submitPR
2025-04-15 13:38:10 -06:00
Kynan Ware
339e1a25f3
docs(pr create): add link for user:branch syntax
2025-04-15 13:38:10 -06:00
Kynan Ware
76de5f07ca
test(pr finder): run test in parallel
2025-04-15 13:38:10 -06:00
Kynan Ware
bf7bf99f54
fix(pr create & stubs): handle exitcode in stubs
2025-04-15 13:38:10 -06:00
Kynan Ware
81d00a36f8
fix(pr create): use existing local variables
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
15ea861b79
docs(pr create): help text, doc user:branch syntax
...
Document the user:branch syntax for the `--head`` flag in `gh pr create`.
2025-04-15 13:38:10 -06:00
Kynan Ware
7bb5d71f4c
doc(pr create): improve head repo resolution comments
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
041f02c980
docs(pr create): standard <user>:<branch> syntax
...
Standardize <user>:<branch> syntax wherever it is described in comments.
2025-04-15 13:38:10 -06:00
Kynan Ware
6dae35b442
test(finder): change assert to require
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
e9e57f3ee3
doc(pr create): fix typo in comments
...
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2025-04-15 13:38:10 -06:00
Kynan Ware
d524cbddc2
docs(pr create): clarify comment on head branch syntax
2025-04-15 13:38:10 -06:00