Commit graph

617 commits

Author SHA1 Message Date
David Gardiner
d22c6f33e9 Update comment 2023-10-31 13:12:25 -07:00
David Gardiner
d04a9d941f Lock the Close func 2023-10-31 13:11:28 -07:00
David Gardiner
1bcf92438a Defer the mutex unlock 2023-10-31 13:08:34 -07:00
David Gardiner
b566ea670c Add mutex for connect 2023-10-31 13:01:24 -07:00
David Gardiner
581b6652e2 Resolve race condition in codespaces connection 2023-10-31 12:19:14 -07:00
David Gardiner
500f359592
Don't poll for addition codespace permissions if user chooses to create without them (#8267) 2023-10-30 13:22:38 -05:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface (#8246) 2023-10-27 15:42:05 +02:00
Sam Coe
20baccfa85
Add default configuration back from go-gh (#8244) 2023-10-24 13:23:31 +02:00
Sam Coe
5023b61909
Remove uses of FuzzyAgoAbbr in tables (#8222) 2023-10-22 17:33:49 +02:00
Heath Stewart
7738b6187c
Add headers to all tables (#8157) 2023-10-20 11:20:02 +02:00
William Martin
4fc1999847 Add link to token source issue 2023-10-19 15:39:10 +02:00
William Martin
6dc04bb1e2 Remove GetOrDefault uses in favour of GitProtocol 2023-10-19 12:57:19 +02:00
William Martin
7d8c1af009 Fix GitProtocol signature and rework test descriptions 2023-10-19 12:49:38 +02:00
William Martin
b9cbee0462 Remove incorrect comment about HasEnvToken 2023-10-19 12:39:31 +02:00
William Martin
3c3fbcdb66 Remove Login branch that handles empty username 2023-10-19 12:35:43 +02:00
William Martin
aa8848471f Remove Logout branch that handles empty hostname 2023-10-19 12:33:15 +02:00
William Martin
c430da7329 Ensure all AuthConfig tests are isolated on disk 2023-10-19 12:31:41 +02:00
William Martin
c9de817865 Avoid using keyring unnecessarily in AuthConfig tests
This is to avoid the impression that the keyring matters, when the test
is actually about general auth behaviour
2023-10-19 12:26:52 +02:00
William Martin
fa80802c81 Add tests for AuthConfig DefaultHost 2023-10-19 12:24:25 +02:00
William Martin
07f5ca48d8 Share config.Read setup in AuthConfig tests 2023-10-19 12:24:05 +02:00
William Martin
e0bc2ff0ca Add test that host is added on Login 2023-10-19 12:08:03 +02:00
William Martin
cb7672e573 Add additional comment on Logout ignoring errors 2023-10-19 12:05:40 +02:00
William Martin
3380831672 Rewrite AuthConfig User and GitProtocol tests 2023-10-19 12:05:14 +02:00
William Martin
e011633cdc Add tests for AuthConfig HasEnvToken 2023-10-18 18:10:00 +02:00
William Martin
07110eca33 Add tests for AuthConfig Token 2023-10-18 17:51:53 +02:00
William Martin
52ba99ebab Update AuthConfig to use default fn 2023-10-18 17:51:41 +02:00
William Martin
614e49296b Add tests for AuthConfig Login and Logout 2023-10-18 17:09:20 +02:00
William Martin
34b0b33f24 Add initial AuthConfig tests 2023-10-18 16:31:13 +02:00
William Martin
5f645eaded Add tests for config GetOrDefault 2023-10-18 16:10:53 +02:00
William Martin
b94f458950 Add initial tests for config Get 2023-10-18 15:51:46 +02:00
David Gardiner
a8f8728056 Poll permission acceptance endpoint on codespace creation 2023-10-12 16:55:13 -07:00
David Gardiner
64f4660ec7
Migrate all Codespaces operations from Live Share to Dev Tunnels (#8149)
* Migrate all Codespaces operations from Live Share to Dev Tunnels

* Remove Live Share references

* Fix linting errors

* Update comments, remove deps, add uint16 bound checks

* Fix tests and move keep-alive logic to forwarder

* Address comments

* Updated mock port forwarder

* Fix CodeQL error

* Update comment

* Update func name

* Add missing connection close

* Fix linting error

* https -> http

* Update defer

* Fix tests
2023-10-12 22:16:36 +00:00
David Gardiner
e059f32aa5 Forward codespace ports over Dev Tunnels 2023-09-27 13:42:40 -07:00
Keith Bailey
97755c6bf0
Document when gh auth login writes oauth token to plain text (#7781) 2023-09-18 11:34:13 +02:00
Sam Coe
8016244dbb
Use go-gh prompter package (#7896) 2023-08-28 08:08:43 -05:00
azarashi
bb42fa07aa
codespace: Handle HTTP request retry interruption (#7846)
* codespace: Handle HTTP request retry interruption

* codespace: Make the error message more detailed
2023-08-18 07:16:06 -07:00
Nate Smith
a51aba0d22
Merge pull request #7850 from cli/noch-prompts
update more prompts
2023-08-17 17:38:17 -05:00
Nate Smith
f2e5ad6dcd fix RegisterPassword 2023-08-16 21:26:37 -05:00
Sam Coe
4a57a812f5
Upgrade to Go 1.21 (#7843) 2023-08-16 10:37:58 -07:00
Nate Smith
d9ea221b1a
Merge pull request #7816 from cli/prompts-again
port repo edit prompts
2023-08-10 17:45:49 -07:00
John Keech
93e1511bae
Codespaces: Use the host name from the logged in server for commands (#7795)
* Use the host name from the logged in server for codespace commands

* Fix existing tests

* Add tests for server url configuration

* Rename defaultApiUrl to defaultAPIURL and comment cleanup

* Switch to t.Setenv in codespaces api tests

* Switch to t.Setenv in other tests

* Support custom server in web flows for list and create

* Rename GetServerURL() to ServerURL()
2023-08-08 09:32:06 -07:00
Nate Smith
7d470c4df4 name MultiSelect parameters in interface
I wanted the parameters to show up in my autocomplete
2023-08-07 17:59:12 -07:00
Sam Coe
8079d18efd
Use asciisanitization package from go-gh (#7745) 2023-07-24 10:50:33 -07:00
Sam Coe
ad283cff72
Fix pr checks command for GHES versions older than 3.9 (#7725) 2023-07-19 09:25:07 -07:00
Sam Coe
5d82a9553c
Sanitize file contents before displaying them (#7694) 2023-07-18 12:49:25 -07:00
Jose Garcia
37d8e9e915 Support --server-port behavior with conn details 2023-07-02 20:55:56 -04:00
Sam Coe
d21c11d774
Add tenancy support (#7636) 2023-06-30 11:20:53 +00:00
Sam Coe
bf7db84ca8
Add timeouts to keyring operations (#7580) 2023-06-20 23:45:20 +00:00
David Gardiner
06e40dfddb
Merge pull request #7496 from dmgardiner25/add-view-cmd
Add `gh cs view` command
2023-05-30 14:37:34 -07:00
David Gardiner
3c05c99c83 Address comments 2023-05-30 12:20:23 -07:00