Commit graph

8587 commits

Author SHA1 Message Date
Meredith Lancaster
e03a36ea3c add tests for bundle url fetch and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 12:12:26 -07:00
Meredith Lancaster
070b67e5a4 fetch bundles in parallel
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:44:55 -07:00
Meredith Lancaster
311f2b2e23 return fetch attestations err directly
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:39:40 -07:00
Meredith Lancaster
fc984c91d0 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 10:21:37 -07:00
Meredith Lancaster
9051da39fc provide additional logging and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:19:47 -07:00
Meredith Lancaster
706314b005
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 09:57:57 -07:00
Kynan Ware
106d5d1144
Merge pull request #10181 from jsoref/issue-10084
Upgrade generated workflows
2025-01-06 09:08:33 -07:00
Josh Soref
dd32a9cc94 Upgrade generated workflows
Use `cli/gh-extension-precompile@v2`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2025-01-05 23:18:28 -05:00
Tyler McGoffin
2ec473ff2f
Merge pull request #10139 from ChandranshuRao14/feat/repo-edit-security-analysis
Feat: Allow setting security_and_analysis settings in gh repo edit
2025-01-03 16:22:10 -08:00
Tyler McGoffin
576fa8a3bc
Add test for permissions check for security and analysis edits (#1) 2025-01-03 01:29:45 -05:00
Tyler McGoffin
d6dba93586
Merge pull request #10164 from cli/jtmcg/update-auth-PAT-info
Add mention of classic token in gh auth login docs
2025-01-02 15:29:23 -08:00
Tyler McGoffin
2306623cad
Merge pull request #10124 from hoffm/autolink-references
feat: Add support for listing autolink references
2025-01-02 14:29:48 -08:00
Tyler McGoffin
aa793f1dac
Update pkg/cmd/auth/login/login.go
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-01-02 14:22:20 -08:00
Tyler McGoffin
ae9e68b803 Move mention of classic token to correct line 2025-01-02 10:41:25 -08:00
Michael Hoffman
a5cf3751cd Separate type decrarations 2025-01-02 13:14:23 -05:00
Michael Hoffman
8f00cd40af
Merge branch 'cli:trunk' into autolink-references 2025-01-02 13:11:48 -05:00
Tyler McGoffin
375dbf19da Add mention of classic token in gh auth login docs 2025-01-02 10:08:28 -08:00
Kynan Ware
64c23e5e95
Merge pull request #10163 from nobe4/repo-create-branch-doc
docs(repo): make explicit which branch is used when creating a repo
2025-01-02 09:34:21 -07:00
nobe4
f1c3619003
Update pkg/cmd/repo/create/create.go
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-01-02 17:11:59 +01:00
nobe4
9558d5b60b
docs(repo): make explicit which branch is used when creating a repo
This adds a line of documentation in the `gh repo create` command's help
specifying which branch for the new repo is selected.
2025-01-02 16:53:44 +01:00
ChandranshuRao14
079719f923 Move api call to editRun 2024-12-31 00:47:05 -05:00
Michael Hoffman
fa254ba205 Complete get -> list renaming 2024-12-28 07:51:47 -05:00
Michael Hoffman
da826db342 Better error testing for autolink TestListRun 2024-12-27 22:58:12 -05:00
Michael Hoffman
20f086549a Decode instead of unmarshal 2024-12-27 22:03:25 -05:00
Michael Hoffman
63488a1a06 Use 'list' instead of 'get' for autolink list type and method 2024-12-27 22:02:19 -05:00
Michael Hoffman
dc6320f7f7 Remove NewAutolinkClient 2024-12-27 21:47:27 -05:00
Michael Hoffman
cc24289832 Break out autolink list json fields test 2024-12-27 21:43:47 -05:00
Michael Hoffman
67266e9cb8 PR nits 2024-12-27 21:40:52 -05:00
Michael Hoffman
e98ff2ea38 Refactor autolink subcommands into their own packages 2024-12-27 21:36:16 -05:00
Michael Hoffman
ea04d2da30 Whitespace 2024-12-27 21:36:16 -05:00
Michael Hoffman
869d25193a Refactor out early return in test code
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
2024-12-27 21:36:16 -05:00
Tyler McGoffin
4a74cc8856 Add testing for AutoLinkGetter
This adds the missing mocked http tests to the http_test.go file. These
tests were previously bundled with the tests in list_test.go, creating a
testing pattern that was difficult to understand and maintain. The
refactor in the previous commit replaced these tests with the
AutolinkClient interface, allowing for the httpmocks to be isolated to the
AutolinkGetter that implements that interface.
2024-12-27 21:36:16 -05:00
Tyler McGoffin
a390ce4f10 Refactor autolink list and test to use http interface for simpler testing
This defines an AutolinkClient interface with a Get method used for
fetching the autolinks lists from the api. Then, the http client for
autolinks implements this interface with the AutolinkGetter struct.

This allows for dependency injection of the AutolinkGetter struct into the
listOptions, enabling mocking of the AutolinkGetter for testing. The
result of this is simpler tests that are easier to maintain, because the
interface for the table tests now allow for defining autolink structs as
the response instead of large mocked api calls.

This also allows for bespoke testing of the http file, which I'll follow
up with in the next commit.
2024-12-27 21:36:16 -05:00
Tyler McGoffin
5fb98524e0 Apply PR comment changes 2024-12-27 21:36:16 -05:00
Michael Hoffman
23c16c9c4c Introduce repo autolinks list commands 2024-12-27 21:36:16 -05:00
Tyler McGoffin
6c51451660
Merge pull request #10145 from shauryatiwari1/remove-discussions
Remove release discussion posts and clean up related block in deployment yml
2024-12-27 08:59:35 -08:00
Tyler McGoffin
c968e5c60c
Merge pull request #10143 from dziamidchyk/add-pending-status-for-workflows
add pending status for workflow runs
2024-12-27 08:38:26 -08:00
shauryatiwari1
eed3626521 Remove release discussion posts and clean up related block in deployment yml 2024-12-27 15:15:21 +05:30
ChandranshuRao14
29371e9491 Extract logic into helper function 2024-12-26 22:52:32 -05:00
Arseni Dziamidchyk
f9767d0a9a add pending status for workflow runs 2024-12-26 19:10:06 +03:00
ChandranshuRao14
a542011cdc Feat: Allow setting security_and_analysis settings in gh repo edit 2024-12-24 12:59:42 -06:00
William Martin
48bc3cabab
Merge pull request #10135 from cli/jtmcg/update-go-net
Upgrade golang.org/x/net to v0.33.0
2024-12-24 12:38:37 +01:00
Tyler McGoffin
7357bad2d3
Merge pull request #10112 from heaths/gh-merge-base-docs
Document how to set gh-merge-base
2024-12-23 11:51:10 -08:00
Tyler McGoffin
939e183cd6 Upgrade golang.org/x/net to v0.33.0 2024-12-23 11:43:51 -08:00
William Martin
b476849331
Merge pull request #10116 from cli/andyfeller/10113-update-release-docs
Update releasing.md
2024-12-23 19:48:31 +01:00
William Martin
0a280ff145
Merge pull request #10110 from cli/10109-document-the-base-repo-resolution-functions
Document the base repo resolution functions
2024-12-23 19:47:38 +01:00
William Martin
b9c597458b Document SmartBaseRepoFunc 2024-12-23 19:07:17 +01:00
William Martin
7a954cde82 Document BaseRepoFunc 2024-12-23 19:07:17 +01:00
Andy Feller
0e191ef0f2
Update releasing.md 2024-12-20 15:34:26 -05:00
Heath Stewart
78836097c3
Document how to set gh-merge-base
Follow-up to PR #9712
2024-12-20 10:49:38 -08:00