Commit graph

9784 commits

Author SHA1 Message Date
Stefan Heimersheim
e062330163
Fix inconsistent use of tabs and spaces
The code below used spaces to indent two of the lines, and tabs for the other 6 lines. This makes indenting inconsistent in settings where tabs are not rendered as 8 spaces. I've replaced the spaces with tabs.

```
(type -p wget >/dev/null || (sudo apt update && sudo apt-get install wget -y)) \
	&& sudo mkdir -p -m 755 /etc/apt/keyrings \
        && out=$(mktemp) && wget -nv -O$out https://cli.github.com/packages/githubcli-archive-keyring.gpg \
        && cat $out | sudo tee /etc/apt/keyrings/githubcli-archive-keyring.gpg > /dev/null \
	&& sudo chmod go+r /etc/apt/keyrings/githubcli-archive-keyring.gpg \
	&& sudo mkdir -p -m 755 /etc/apt/sources.list.d \
	&& echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | sudo tee /etc/apt/sources.list.d/github-cli.list > /dev/null \
	&& sudo apt update \
	&& sudo apt install gh -y
```
2025-07-01 11:43:04 +01:00
William Martin
c58a88a217
Merge pull request #11189 from cli/wm/automate-go-bump
Add workflow to automate go version bumping
2025-07-01 12:21:01 +02:00
William Martin
12aeb1fed2 Add workflow to automate go version bumping 2025-07-01 12:10:22 +02:00
Kynan Ware
729ff163b6
Merge pull request #11190 from cli/kw/followup-pr-11179
Remove unused `GH_TOKEN` env variable from workflow
2025-06-30 11:05:23 -06:00
Kynan Ware
8a5302ec6e Remove unused GH_TOKEN env variable from workflow
The GH_TOKEN environment variable was set but not used in the pr-vars-dispatch step. This commit removes it for clarity and to avoid confusion.
2025-06-30 10:55:10 -06:00
Kynan Ware
45c8c827c5
Add workflow_dispatch support to PR Help Wanted check (#11179)
* Add workflow_dispatch support to PR Help Wanted check

This update allows the PR Help Wanted workflow to be triggered manually via workflow_dispatch with a specified PR URL. It adds logic to fetch PR details using the GitHub CLI for manual runs and unifies variable handling for both event types.

* Update workflow to use PR number instead of URL

Changed the workflow_dispatch input from 'pr_url' to 'pr_number' and updated the script to construct the PR URL from the number.

* Move help-wanted check for draft PRs into script

* Don't prefix URL with `#`

* Invert draft checking logic

Inverting this logic because anything other than "false" means we should skip it.

* Move PR draft status check to shell script

The logic for checking if a pull request is a draft has been moved from the GitHub Actions workflow YAML to the check-help-wanted.sh script. This simplifies the workflow file and centralizes the draft status check within the script.
2025-06-30 12:51:54 -04:00
Andy Feller
e5913fe02f
Merge pull request #11038 from anuraaga/active-token-user
fix: get token for active user instead of blank if possible
2025-06-27 08:27:36 -04:00
Andy Feller
2fc1e548cc
Merge pull request #11048 from cli/babakks/embed-winres-at-release
Embed Windows resources (VERSIONINFO) during build
2025-06-24 17:29:18 -04:00
Babak K. Shandiz
9c54fb3e0d
chore: improve error message when versioninfo.json is not found
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-06-24 22:19:37 +01:00
Daniel Krzeminski
b31f38c946
Fix: gh pr create prioritize --title and --body over --fill when --web is present (#10547)
* fix: prioritize title and body over autofill for prs

* fix: prioritize title and body over autofill tests

* refactor: collapse state conditions

---------

Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 12:54:43 +00:00
Babak K. Shandiz
480240fd0b
chore: create .syso libs only on Windows
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 12:59:47 +01:00
Babak K. Shandiz
ee5ec5e058
chore: delete script/winres.json
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 11:57:30 +01:00
Babak K. Shandiz
68d9513038
chore: add versioninfo.template.json
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 11:56:10 +01:00
Babak K. Shandiz
925b0bcb03
refactor: switch to github.com/josephspurrier/goversioninfo
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 11:55:50 +01:00
Babak K. Shandiz
f819762561
chore: exclude generated .syso files from git repo
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 11:46:34 +01:00
Andy Feller
2b89358543
Merge pull request #11161 from cli/andyfeller/111-golicenses-versioning-followup
Ensure automation uses pinned go-licenses version
2025-06-23 13:51:47 -04:00
Andy Feller
ce265d4ac2
Merge pull request #11160 from cli/kw/fix-broken-install-linux-links
Fix missing newline in install_linux.md
2025-06-23 13:32:07 -04:00
Andy Feller
728e973a20 Ensure automation uses pinned go-licenses version 2025-06-23 13:22:27 -04:00
Kynan Ware
74d10f8dec Fix missing newline in install_linux.md 2025-06-23 11:16:20 -06:00
Kynan Ware
9ce1aeeb1c
Merge pull request #10823 from chax/install_solus
docs: install_linux.md: add Solus linux install instructions
2025-06-23 10:31:38 -06:00
Kynan Ware
802a75b19a
Apply suggestions from code review 2025-06-23 10:23:10 -06:00
Andy Feller
f7218561be
Merge pull request #11047 from cli/andyfeller/9422-license-compliance
Ensure lint workflow checks whether 3rd party license and code is up to date
2025-06-23 12:06:31 -04:00
Kynan Ware
8541d6e290
Merge branch 'trunk' into install_solus 2025-06-23 09:42:11 -06:00
Kynan Ware
51fd8edd85
Merge pull request #11158 from tMinamiii/chore/devcontainer-image-go-version
chore: update Go version to 1.24 in devcontainer configuration and docs
2025-06-23 09:23:16 -06:00
Andy Feller
b5867208a1 Update missed Go 1.23 references 2025-06-23 09:58:06 -04:00
TmINAMIII
6bfd4bbd77 chore: update Go version to 1.24 in devcontainer configuration 2025-06-22 01:57:48 +00:00
Andy Feller
11e8a8127d Use make for license generation and checks 2025-06-20 16:53:11 -04:00
Andy Feller
4d1eb59c36 Use temp directory for license checks 2025-06-20 16:44:44 -04:00
Andy Feller
4e8d022448 Update 3rd party licenses 2025-06-20 16:26:59 -04:00
Andy Feller
98ea250ede Merge branch 'trunk' into andyfeller/9422-license-compliance 2025-06-20 16:23:00 -04:00
Andy Feller
d4efe0bd0a
Merge pull request #11018 from ejahnGithub/eugene/release-verify
init release verify subcommands
2025-06-20 15:55:44 -04:00
Andy Feller
0180c7fce4 Restored original test setup, clarified
After discussing my previous change to the test, I'm restoring the previous keyring setup to reflect the specific situation.

I added clarifying comments to help the next reviewer.
2025-06-20 15:38:09 -04:00
Andy Feller
b7c2b19e70 Enhance Activetoken prioritize test
- ensure test user tokens are different from unkeyed token
- ensure assertion expected / actual are in correct order
2025-06-20 14:36:45 -04:00
Eugene
98d7135ccc
Merge branch 'trunk' into eugene/release-verify 2025-06-20 06:50:04 -07:00
ejahnGithub
169b909015 improve the description for gh release verify cmd 2025-06-19 10:18:23 -04:00
William Martin
dc7b22b659
Merge pull request #11149 from jinjingroad/trunk
chore: fix function name
2025-06-19 11:31:49 +02:00
jinjingroad
28d5de9d8e chore: fix function name
Signed-off-by: jinjingroad <jinjingroad@sina.com>
2025-06-19 12:36:52 +08:00
Anuraag Agrawal
12a41333c3 Merge branch 'trunk' of https://github.com/cli/cli into active-token-user 2025-06-18 09:57:09 +09:00
Anuraag Agrawal
848cedd2c8 Push up 2025-06-18 09:56:44 +09:00
Eugene
524aee8cfb
Merge branch 'trunk' into eugene/release-verify 2025-06-17 08:20:37 -07:00
William Martin
d9d0e14e85
Merge pull request #11145 from cli/kw/fix-step-order-in-codeql-workflow
Fix step order for CodeQL workflow
2025-06-17 17:03:43 +02:00
William Martin
b5613cdbbe
Merge pull request #10699 from laffer1/patch-1
Add instructions for MidnightBSD installation
2025-06-17 16:55:53 +02:00
Eugene
898bb42719
Merge branch 'trunk' into eugene/release-verify 2025-06-17 07:54:26 -07:00
William Martin
9cf0c73ae4
Merge pull request #10935 from MagneticNeedle/patch-1
docs: update install command for Debian
2025-06-17 16:54:02 +02:00
William Martin
6b36060d58
Update docs/install_linux.md 2025-06-17 16:43:25 +02:00
Kynan Ware
50e4a4ad15 Fix step order for CodeQL workflow 2025-06-17 08:41:14 -06:00
Vibhakar Solanki
1ac3f064f3 docs: update install command for Debian
Make sure that `sources.list.d` exists before trying to populate `github-cli.list`
2025-06-17 16:39:58 +02:00
William Martin
e51b03d989
Merge pull request #10888 from aconsuegra/ac/fix-acceptance-test-output
Fix expected error output of TestRepo/repo-rename-transfer-ownership
2025-06-17 16:26:16 +02:00
William Martin
8deae3038a Use active token stubbing on auth config 2025-06-17 15:53:13 +02:00
William Martin
fb35097dec
Merge pull request #11120 from cli/dependabot/go_modules/github.com/google/go-containerregistry-0.20.6
chore(deps): bump github.com/google/go-containerregistry from 0.20.3 to 0.20.6
2025-06-17 12:39:04 +02:00