STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9394 commits 87 branches 0 tags 160 MiB
Commit graph

9394 commits

This branch
This branch
All branches
Author SHA1 Message Date
Andy Feller
e06a368fa9
Merge pull request #10820 from cli/andyfeller/accessible-colors-config 
Update configuration support for accessible colors
 2025-04-21 14:20:48 -04:00
Andy Feller
ac95196748 Fix comment typo 2025-04-21 14:04:53 -04:00
Andy Feller
486c589665 PR feedback to improve config settings docs 2025-04-21 14:04:00 -04:00
Andy Feller
f61961907e Update configuration support for accessible colors 
- added support for `accessible_colors` configuration setting in `gh config` commandset
- updated default configuration file to contain `accessible_colors: disabled`
- add `GH_ACCESSIBLE_COLORS` env var to `gh environment`
- generated mocks via `go generate ./...` including previously missed prompter changes
 2025-04-17 15:57:49 -04:00
Kynan Ware
0ffc887644
Merge pull request #10758 from cli/dependabot/go_modules/google.golang.org/grpc-1.71.1 
Bump google.golang.org/grpc from 1.71.0 to 1.71.1
 2025-04-17 13:35:06 -06:00
Andy Feller
0ef0c42665
Merge pull request #10767 from leudz/fix-9749 
Fix multi pages search for gh search
 2025-04-16 16:57:12 -04:00
Kynan Ware
bff4db1309
Merge pull request #10773 from cli/kw/opt-into-no-spinners 
Introduce option to opt-out of spinners
 2025-04-16 14:44:45 -06:00
leudz
4a885899d6 Add comments for Total 2025-04-16 20:46:29 +02:00
Andy Feller
ba390db71f PR feedback 
- update local variables to communicate what they are
- added docblock explaining search results populated
 2025-04-16 14:22:29 -04:00
Kynan Ware
dabb29bd36 test(factory): remove needless nil check 2025-04-16 11:21:39 -06:00
Kynan Ware
1dbb01a1d1 doc(help): add documentation for GH_SPINNER_DISABLED 2025-04-16 11:17:23 -06:00
Kynan Ware
056d292f26 doc(iostreams): comment behavior of textual progress indicator 2025-04-16 11:13:58 -06:00
Kynan Ware
290e78c904 test(iostreams): update test description 2025-04-16 11:05:36 -06:00
William Martin
5d8dbc0d53
Merge pull request #10787 from cli/dependabot/go_modules/github.com/sigstore/sigstore-go-0.7.2 
chore(deps): bump github.com/sigstore/sigstore-go from 0.7.1 to 0.7.2
 2025-04-16 11:28:25 +02:00
Andy Feller
becd936e7b Update searcher tests 
This commit moves the remaining searcher tests from using JSON marshaled types to using JSON responses for consistency.  There appears to be a weird JSON marshaling error with search.Repository that does not map `Name` field in the process.

Additionally, the test scenarios around pulling multiple pages beneath the total results have been updated to demonstrate that the REST API returns full pages in both of these cases, which is below the total number of results.
 2025-04-15 17:13:43 -04:00
Kynan Ware
d52a5999ec
Merge pull request #10513 from cli/kw/575-detect-push-target-for-local-branches-without-upstream-configuration 
`gh pr create`: Support Git's `@{push}` revision syntax for determining head ref
 2025-04-15 14:37:51 -06:00
William Martin
a9dbda6913 Rework ref usage when finding and creating PRs 2025-04-15 13:38:10 -06:00
William Martin
ebd147b43e Use verbose upstream setting 2025-04-15 13:38:10 -06:00
Kynan Ware
028caa3823 docs(pr create): clarify BaseRepo type in submitPR 2025-04-15 13:38:10 -06:00
Kynan Ware
339e1a25f3 docs(pr create): add link for user:branch syntax 2025-04-15 13:38:10 -06:00
Kynan Ware
bdfec50186 fix(pr create): use REPO var in AT 2025-04-15 13:38:10 -06:00
Kynan Ware
6004fc2cd8 fix(pr create): use curly brace for vars in AT 2025-04-15 13:38:10 -06:00
Kynan Ware
76de5f07ca test(pr finder): run test in parallel 2025-04-15 13:38:10 -06:00
Kynan Ware
0611d9d06d test(pr create): fix user:branch syntax AT 
This test was setting `remote.pushDefault` which likely caused
the `user:branch` syntax to be ignored. Update the test to not set
this config value.
 2025-04-15 13:38:10 -06:00
Kynan Ware
bf7bf99f54 fix(pr create & stubs): handle exitcode in stubs 2025-04-15 13:38:10 -06:00
Kynan Ware
188e1388b3 test(pr create): add AT for no local repo 2025-04-15 13:38:10 -06:00
Kynan Ware
81d00a36f8 fix(pr create): use existing local variables 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-15 13:38:10 -06:00
Kynan Ware
15ea861b79 docs(pr create): help text, doc user:branch syntax 
Document the user:branch syntax for the `--head`` flag in `gh pr create`.
 2025-04-15 13:38:10 -06:00
Kynan Ware
7bb5d71f4c doc(pr create): improve head repo resolution comments 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-15 13:38:10 -06:00
Kynan Ware
041f02c980 docs(pr create): standard <user>:<branch> syntax 
Standardize <user>:<branch> syntax wherever it is described in comments.
 2025-04-15 13:38:10 -06:00
Kynan Ware
6dae35b442 test(finder): change assert to require 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-15 13:38:10 -06:00
Kynan Ware
e9e57f3ee3 doc(pr create): fix typo in comments 
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
 2025-04-15 13:38:10 -06:00
Kynan Ware
d524cbddc2 docs(pr create): clarify comment on head branch syntax 2025-04-15 13:38:10 -06:00
Kynan Ware
e999976b3d refactor(pr create): add PullRequestRefs HasHead 2025-04-15 13:38:10 -06:00
Kynan Ware
54da786bec fix(pr create): update error handling 2025-04-15 13:38:10 -06:00
Kynan Ware
bab7dc650b test(pr create): update repo owner names in tests 2025-04-15 13:38:10 -06:00
Kynan Ware
1ce3d99227 test(pr create): add logical spacing between operations 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2025-04-15 13:38:10 -06:00
Kynan Ware
da235b134b tests(pr create): remove irrelevant comments 2025-04-15 13:38:10 -06:00
Kynan Ware
9b96e6cded doc(pr create): fix typo in test comments 
Co-authored-by: Tyler McGoffin <jtmcg@github.com>
 2025-04-15 13:38:10 -06:00
Kynan Ware
ba6e2ec3ed test(pr create): skip tests that create forks 2025-04-15 13:38:10 -06:00
Kynan Ware
911079c744 docs(pr create): add comments 2025-04-15 13:38:10 -06:00
Kynan Ware
cf58910ac0 refactor(pr create): named headRefName var 2025-04-15 13:38:10 -06:00
Kynan Ware
9f1cb0cd54 refactor(pr create): simplify head remote logic 2025-04-15 13:38:10 -06:00
Kynan Ware
f50dac53cb docs(pr create): fix <repo_name>:<branch> desc. 2025-04-15 13:38:10 -06:00
Kynan Ware
c0c5d9123d refactor(pr create): use GetPRHeadLabel() 
Use PrRefs.GetPRHeadLabel() instead of headBranchLabel.
Also remove headBranchLabel from CreateContext struct.

To do this, we needed a new identifier for when the head repo should be
created via a new fork of the base repo. Previously, this was done by
checking if the head repo was nil, but if we want to call
GetPRHeadLabel(), it requires a non-nil head repo to construct the
headBranchLabel. So, instead of the head repo being nil to signal
a fork, we pass a new forkHeadRepo bool in the CreateContext struct.
This also makes the decision to fork more intentional; now the decision
is made clearly instead of if the headRepo happens to be nil.
 2025-04-15 13:38:10 -06:00
Kynan Ware
178fb40515 refactor(pr create): Use PrRefs in CreateContext 
Replace BaseRepo, HeadRepo, HeadBranch with PrRefs in CreateContext struct.
 2025-04-15 13:38:10 -06:00
Kynan Ware
c3087cde99 refactor(pr create): Refactor NewCreateContext 
- Use prRefs instead of local vars more.
- Rename variables for readability.
- Improve comments.
- Refactor tests.
 2025-04-15 13:38:10 -06:00
Kynan Ware
a5fe37f91b test(pr create): add AT for remote:branch syntax 2025-04-15 13:38:10 -06:00
Kynan Ware
10e3949348 refactor(pr create): use prRefs.GetPRHeadLabel() 2025-04-15 13:38:10 -06:00
Kynan Ware
1848beb94b test(pr create): unset gh-resolved 2025-04-15 13:38:10 -06:00