Alan Donovan
a56a84947a
Update ghcs for go-liveshare@v0.12.0
2021-09-03 10:11:29 -04:00
Mislav Marohnić
8f3b6749d7
Merge pull request #4241 from cli/saml-error
...
Suggest to re-authenticate to fix "SAML enforcement" error
2021-09-03 16:10:16 +02:00
Alan Donovan
786a631995
fix local/remote confusion in getPorts (!)
2021-09-02 17:21:24 -04:00
Alan Donovan
981b2545bc
sketch of changes for https://github.com/github/go-liveshare/pull/13
2021-09-02 17:08:17 -04:00
Alan Donovan
1162c8adff
fix go vet loopclosure finding
2021-09-02 16:02:09 -04:00
Alan Donovan
4e2c20606a
Merge branch 'main' into join-session
2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b
update go-liveshare@v0.11.0
2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97
fix StartSharing data race
2021-09-02 15:53:56 -04:00
Jose Garcia
881e6d5940
Merge pull request #111 from github/jg/remove-dir
...
ghcs ssh: remove dir command
2021-09-02 13:33:53 -04:00
Jose Garcia
c15d810d68
remove extra verb arg
2021-09-02 13:27:12 -04:00
Alan Donovan
8570f4111d
sketch after API changes in go-liveshare#11
2021-09-02 12:38:27 -04:00
Alan Donovan
65c19a3317
Merge pull request #107 from github/spelling-again
...
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
c31fc05746
more typo fixes
2021-09-02 09:09:05 -04:00
Alan Donovan
72a2099a50
fix breakage from API changes
2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21
use correct correct spelling of codespace
2021-09-01 17:26:26 -04:00
Jose Garcia
bfeb4e77c9
remove dir command
2021-09-01 14:38:37 -04:00
Jose Garcia
2163aba3d5
pass branch for sku selection, pre-select if only one is returned
2021-09-01 13:54:45 -04:00
Alan Donovan
37b2f5e979
Merge branch 'main' into runcommand
2021-08-31 17:18:52 -04:00
Alan Donovan
6a527941bf
suppress display of usage message after errors
2021-08-31 16:35:28 -04:00
Alan Donovan
f1c3a22a0b
Merge branch 'main' into product-spelling
2021-08-31 16:24:41 -04:00
Alan Donovan
68792d5aa5
Merge branch 'main' into runcommand
2021-08-31 16:19:37 -04:00
Edmundo Gonzalez
d6f52ae557
Merge pull request #91 from github/edgonmsft/codespaces-ssh-rpc
...
Implement RPC interface so that the codespaces agent starts and configures ssh in the codespace
2021-08-31 13:05:56 -07:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e
address review comments
2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
ea97e2e73d
remove sleep 1s
2021-08-30 18:15:37 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
Mislav Marohnić
b0b67014f1
Suggest to re-authenticate to fix "SAML enforcement" error
...
As far as I can put together, this error appears when someone has
authenticated GitHub CLI with a PAT that isn't authorized to access a
certain org. It can also happen if someone has authorized GitHub CLI
using the legacy "GitHub CLI (dev)" OAuth app instead of our production
OAuth app.
Doing `gh auth refresh` will re-authenticate the user using our
production "GitHub CLI" OAuth app which will not have problems accessing
resources in different GitHub organizations.
2021-08-30 17:18:59 +02:00
Edmundo Gonzalez
ee36a005b1
Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc
2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Jose Garcia
634796e8a8
merge main
2021-08-27 18:18:30 -04:00
Jose Garcia
adc1ee5e2d
merge main
2021-08-27 17:43:43 -04:00
Jose Garcia
368e8c6110
simplify contract for state polling
2021-08-27 17:34:06 -04:00
Alan Donovan
9f082ca887
Merge branch 'main' into main-style
2021-08-27 17:30:34 -04:00
Jose Garcia
c66cf0da39
Merge pull request #92 from github/jg/remove-dst-port
...
Remove destination port column and add docs
2021-08-27 17:06:48 -04:00
Jose Garcia
e5f45d4bfa
docs and improvement to the showStatus implementation
2021-08-27 16:41:22 -04:00
Jose Garcia
1e8a8370fe
initial round of PR feedback
2021-08-27 16:29:02 -04:00
Alan Donovan
e423cb0ef9
display colon and cursor in survey prompts
2021-08-27 16:09:02 -04:00
Alan Donovan
8b395b5ab5
ghcs code: improve vscode error
2021-08-27 15:53:55 -04:00
Alan Donovan
a5ae72cb26
revert removal of _ = f() to pacify linter
2021-08-27 15:38:41 -04:00
Alan Donovan
d8f1baa519
more SKU renames.
2021-08-27 15:36:45 -04:00
Alan Donovan
da34d12abb
respond to review
2021-08-27 15:26:34 -04:00
Jose Garcia
da8655209b
make things private
2021-08-27 12:52:30 -04:00
Jose Garcia
cb6552f4ca
more efficient impl for processing states
2021-08-27 12:50:32 -04:00
Alan Donovan
38ff786a7d
cmd/ghcs: style tweaks
2021-08-27 12:03:20 -04:00
Jose Garcia
8e95493872
period
2021-08-27 15:46:40 +00:00
Jose Garcia
5dc923777b
update docs, make ports private to be more consistent
2021-08-27 15:32:18 +00:00
Jose Garcia
3dcee5cca7
remove dst port column and add docs
2021-08-27 12:41:36 +00:00
Edmundo Gonzalez
b6094e0006
Changes to point to RPC service.
2021-08-26 21:50:20 +00:00
