Phill MV
82a849742e
minor tweak to language
2024-12-11 16:58:37 -05:00
Phill MV
bbc47fbac7
go mod tidy
2024-12-11 16:52:40 -05:00
Phill MV
7bd59e091f
Deleted no-longer-used code.
2024-12-11 16:51:23 -05:00
Phill MV
ac93417c29
Merge branch 'trunk' into phillmv/improve-gh-at-inspect
2024-12-11 16:50:01 -05:00
Phill MV
465b6ff889
deleted now-invalid tests, added a tiny patina of new testing.
2024-12-11 16:48:29 -05:00
Phill MV
bc236db9e5
Tightened up docs, deleted dead code, improved printing
2024-12-11 16:26:08 -05:00
Meredith Lancaster
6574327d79
Merge branch 'trunk' into gh-attestation-download-windows-bug
2024-12-11 09:20:35 -07:00
Meredith Lancaster
2418eda1cb
fix file name creation on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:55:11 -07:00
Meredith Lancaster
d42b076a48
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:13:40 -07:00
Meredith Lancaster
2393725469
hard code expected digest
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:13:30 -07:00
Meredith Lancaster
35b5606937
fix download test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:04:02 -07:00
Meredith Lancaster
5ebfa26487
use bash shell with integration tests
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 08:03:42 -07:00
Meredith Lancaster
91edde1acb
simplify var creation
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:18 -07:00
Meredith Lancaster
2ced59fba3
update integration test scripts
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:05 -07:00
Andy Feller
52b845bcad
Refactor local installation manager test by OS
...
- Local extensions on Windows are not symlinks but files whose contents is the path to the local extension directory
- Local extensions elsewhere are symlinks
2024-12-10 22:13:48 -05:00
Kynan Ware
2abe675246
Merge pull request #10043 from uday-rana/issue-10038
...
fix: list branches in square brackets in `gh run` and `gh codespace`
2024-12-10 15:25:57 -07:00
Kynan Ware
e8e30dab6a
Merge branch 'trunk' into issue-10038
2024-12-10 14:17:11 -07:00
Kynan Ware
9d53b86436
Merge pull request #10044 from cli/kw/cli-10034-repo-rename-docs-and-prompt-updates
...
`gh repo rename` help text clarifies new repo name should not include owner
2024-12-10 14:07:08 -07:00
Uday R
40beb82e0c
fix: list branches in square brackets in gh codespace
2024-12-10 15:19:30 -05:00
Meredith Lancaster
b6c2b4ff2a
try nesting scripts
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 11:58:23 -07:00
Meredith Lancaster
050f295b37
run all tests in a single script
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 11:41:15 -07:00
Meredith Lancaster
0e15557000
windows for loop syntax
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 10:18:15 -07:00
Meredith Lancaster
9ff3370ff7
use replaceAll
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:52:56 -07:00
Meredith Lancaster
98a81ffe0f
update expected file path on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:47:15 -07:00
Meredith Lancaster
9f6d18c70e
run integration tests with windows specific syntax
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 08:37:32 -07:00
Meredith Lancaster
fb7f2bfea2
Merge branch 'trunk' into gh-attestation-download-windows-bug
2024-12-10 08:25:31 -07:00
Meredith Lancaster
351592d90f
run all attestation cmd integration tests automatically
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 08:24:01 -07:00
dependabot[bot]
4c5a92aa11
Bump actions/attest-build-provenance from 1.4.4 to 2.1.0
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 1.4.4 to 2.1.0.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](ef244123eb...7668571508 )
---
updated-dependencies:
- dependency-name: actions/attest-build-provenance
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-12-10 14:57:58 +00:00
Meredith Lancaster
23a3c18d56
Merge pull request #10020 from malancas/attestation-fetch-integration-tests
2024-12-10 07:56:57 -07:00
Jonas Grabber
881a2a374c
Improve error handling in apt setup script
...
`wget -qO- ... | sudo tee` causes any errors from `wget` to be swallowed up, causing an empty keyring file to be configured.
For us, the local Ubuntu setup did not have `ca-certificates` installed, which caused `wget` to error out because of a authentication errors (untrusted certificate). However, the `-q` flag and the pipe into `tee` prevented the error from showing up or halting the script.
This PR turns on non-verbose output for `wget` and adds a proper short-circuit on the return code of it by storing the keyring in a temporary file first.
2024-12-10 15:49:55 +01:00
Meredith Lancaster
e97d01f265
use different file name for attestation files on windows
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-09 17:32:55 -07:00
Uday R
8afb434e59
test(gh run): assert branch names are enclosed in square brackets
2024-12-09 12:45:36 -05:00
Kynan Ware
167e868fe2
docs: enhance help text and prompt for rename command
2024-12-09 10:16:38 -07:00
Mateus Marquezini
a7dceb345a
Merge branch 'fix/issue_10042' of github.com:mateusmarquezini/cli into fix/issue_10042
2024-12-09 11:00:01 -03:00
Mateus Marquezini
b740486b13
#10042 fixed test
2024-12-09 10:59:09 -03:00
William Martin
46bba45fac
Merge pull request #9712 from heaths/issue8979
...
Open PR against gh-merge-base
2024-12-09 13:23:22 +01:00
William Martin
54a7f4de70
Revert "Confirm auto-detected base branch"
...
This reverts commit e021a07285 .
2024-12-09 13:01:00 +01:00
Mateus Marquezini
a3cf4e1c2d
Merge branch 'trunk' into fix/issue_10042
2024-12-09 08:42:57 -03:00
Mateus Marquezini
cbaaf77822
fixing gh gist view prompts with no TTY
2024-12-09 08:35:01 -03:00
Nilln
26798213f0
Merge branch 'trunk' into nil/fix-2329
2024-12-09 21:59:25 +11:00
nilvng
5109336963
issue #2329 : include PR status in the prompt's options
2024-12-09 21:22:00 +11:00
nilvng
4bc90101cd
issue #2329 : fix prompt header getting duplicated
...
following the approach in gh run view seems to fix this issue
2024-12-09 21:20:07 +11:00
Heath Stewart
e021a07285
Confirm auto-detected base branch
...
If interactive, confirm the automatically configured gh-merge-branch or, if not configured, the default branch.
Based on PR feedback.
2024-12-08 22:27:00 -08:00
Heath Stewart
5da86e07e7
Merge changes from #10004
...
Merges changes from @williammartin including acceptance tests and word changes.
Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Andy Feller
a6b8bec70d
Remove unnecessary Extension.FullName()
2024-12-08 21:17:26 -05:00
Andy Feller
10f62b1c37
Expand update tests for local extensions
2024-12-08 21:06:01 -05:00
Andy Feller
a79e086bd4
Test whether extension update should be checked
2024-12-08 20:43:51 -05:00
Heath Stewart
88b96f411c
Set gh-merge-base from issue develop
2024-12-08 17:40:03 -08:00
Heath Stewart
3d139019f8
Open PR against gh-merge-base
...
Partly resolves issue #8979 by checking for a `gh-merge-base` branch tag and using that as though it were passed to `gh pr create --base`.
2024-12-08 17:40:00 -08:00
Andrew Feller
a55f50b115
Remove Extension.FullName() from interface
...
- this was something I did in the original implementation of this improved extension update notification logic
- discovering other parts of the extension manager code that were working with non-prefixed extension names motivated a different approach
- the extension manager code that requires the extension be prefixed has been enhanced to use the centralized ensurePrefixed() logic, making the need for this on the extension unnecessary
2024-12-08 20:01:26 -05:00