STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
9368 commits 87 branches 0 tags 160 MiB
Commit graph

9368 commits

This branch
This branch
All branches
Author SHA1 Message Date
Andrew Feller
97630fe73c Enhance extension manager and tests 
- extension manager has been made responsible for extension update directory information
- extension manager has been enhanced to ensure that previously left extension update metadata is deleted before installing an extension
- extension manager has been enhanced to ensure that extension update metadata is deleted when extension is being removed
- refactored extension command tests for manager change, ensuring previous and expected states along with returned release info
- refactored extension manager tests for ensuring previous extension update entries are removed before installing extension
- created extension manager test for installing local extension
- centralized logic for checking and ensuring extension name is "gh-" prefixed
 2024-12-08 19:40:24 -05:00
Kynan Ware
b2ab7b84f8 Refactor extension executable error handling 2024-12-08 15:55:09 -07:00
Uday R
463105d648 fix: list branches in square brackets in gh run view (#10038) 2024-12-08 12:33:08 -05:00
ANKDDEV
3e0703571e
Merge branch 'cli:trunk' into better-document-auth-scopes 2024-12-07 09:54:58 +03:00
Kynan Ware
481a9dd5ad
Merge pull request #10025 from ankddev/update-browse-docs 
docs: improve docs for browse command as of #5352
 2024-12-06 10:53:08 -07:00
ANKDDEV
a4923de755
docs: update description of command 
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-12-06 20:43:54 +03:00
ANKDDEV
0653a5a09c
style: reformat files 2024-12-06 20:04:15 +03:00
ANKDDEV
0e5f26449d
docs: update sentence case 
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-12-06 19:38:26 +03:00
Meredith Lancaster
67798b06c0 use github owned oci image 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-06 08:32:16 -07:00
ANKDDEV
24db9f64c7
docs: add mention of scopes help topic in auth refresh command help 2024-12-06 17:06:19 +03:00
ANKDDEV
53ee6ae56f
docs: add mention of scopes help topic in auth login command help 2024-12-06 17:04:59 +03:00
ANKDDEV
419a01271a
docs: add help topic for auth scopes 2024-12-06 17:03:31 +03:00
ANKDDEV
694e209142
docs: improve help for browse command 
Co-authored-by: Andy Feller <andyfeller@github.com>
 2024-12-06 16:33:57 +03:00
ANKDDEV
3e647385f7
docs: improve docs for browse command as of #5352 2024-12-06 13:45:22 +03:00
nilvng
409e3ca08c issue #2329: simplify the UI of the prompt 
This commit reverts the previous color changes in the prompt UI. While color highlighting could potentially improve the visual appealing of the prompt
using the existing color library (mguz/ansi) with the prompt library (AlecAivazis/survey) caused unintended side effects.
It reset the bold text style for the selected option. We decide to that
bold text style would have a higher priority than the color text ,for
three reasons:
1. To maintain consistency with other prompts in the UI and prioritize accessibility
2. While color can enhance the user experience, according to Primer Design Guidelines, color should not be relied upon to convey essential information.
3. visual indicator of the selected option, especially crucial when dealing with long PR titles or branch names.

As a future improvement, we may consider a separate issue or PR to address the color library issue and explore controlled color usage in prompts. This could potentially allow for more nuanced visual differentiation while avoiding unintended style resets.

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-12-06 19:59:46 +11:00
nilvng
eced54c904 issue #2329: update the prompt's format 
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-12-06 18:49:43 +11:00
nilvng
12479e3072 issue #2329: fix unit tests 2024-12-06 18:19:07 +11:00
Andy Feller
d60e5ffba3
Merge pull request #10016 from cli/andyfeller/cli-cli-10013-pr-checks-json-watch-mutex 
Error for mutually exclusive json and watch flags
 2024-12-05 12:22:24 -05:00
Meredith Lancaster
7e69c0d4ab fix package reference 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-05 10:06:26 -07:00
Meredith Lancaster
006ed7b5b5 add gh attestation verify integration test for oci bundles 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-05 10:02:01 -07:00
Meredith Lancaster
2b7c6f6a16 add integration test for bundle-from-oci option 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-05 09:58:27 -07:00
Andy Feller
acfdae466e
Merge pull request #10009 from cli/wm/safepaths 
Use safepaths for run download
 2024-12-05 11:43:10 -05:00
Meredith Lancaster
90dfefbefb
Merge pull request #10019 from malancas/gh-attestation-oci-attestations-bug 
Fix bug when fetching bundles from OCI registry
 2024-12-05 09:41:56 -07:00
Meredith Lancaster
2137a483de include alg with digest when fetching bundles from OCI 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-05 09:27:14 -07:00
Andy Feller
c9ecf310b3 Error for mutually exclusive json and watch flags 
Closes #10013

This commit enhances `gh pr checks` to exit with an error when mutually exclusive `--json` and `--watch` flags are used.  Users are encouraged to either 1) retrieve information about the checks via `--json` or 2) watch and wait on PR checks that are being updated.
 2024-12-05 10:23:13 -05:00
Meredith Lancaster
b4dfc9fc72 update tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-04 14:59:10 -07:00
Meredith Lancaster
ee05325e1d update tests 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-04 14:48:44 -07:00
Kynan Ware
490bfdac03 issue cli#2329: Fix linter 2024-12-04 14:41:30 -07:00
Kynan Ware
1d19878bc4
Merge branch 'trunk' into nil/fix-2329 2024-12-04 14:37:57 -07:00
Meredith Lancaster
4810fc2a74 move content of veriy policy options function into enforcement criteria 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-04 14:30:32 -07:00
William Martin
9bd8f09774 Use safepaths for run download 2024-12-04 22:12:58 +01:00
nilvng
2a1f27ee01 issue cli#2329: fix unsufficent properties required for PR checkout 
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-12-05 01:07:31 +11:00
Andy Feller
179f0c479e
Merge pull request #10006 from cli/10005-fix-flaky-run-download-test 
Use consistent slice ordering in run download tests
 2024-12-04 08:13:20 -05:00
William Martin
a47b4c9f1d Use consistent slice ordering in run download tests 2024-12-04 13:02:25 +01:00
Tyler McGoffin
1136764c36
Merge commit from fork 
The fix
 2024-12-03 15:12:05 -08:00
Meredith Lancaster
3b043f6350 comment 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 12:37:42 -07:00
Meredith Lancaster
efca3bdfd9 try switch statement 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 12:34:33 -07:00
Meredith Lancaster
2a6ee87ba0 remove duplicate err checking 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 12:29:35 -07:00
Meredith Lancaster
f0f86ecd23 get bundle issuer in another func 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 12:22:56 -07:00
Meredith Lancaster
d737d3b933 more logic updating to remove nesting 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 12:19:28 -07:00
Meredith Lancaster
1ffd22565d inverse logic for less nesting 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 11:52:08 -07:00
Andy Feller
8720479b0b Consolidate logic for isolating artifacts 2024-12-03 13:33:00 -05:00
Meredith Lancaster
6a7243bb7b remove unneeded nesting 
Signed-off-by: Meredith Lancaster <malancas@github.com>
 2024-12-03 10:54:22 -07:00
Phill MV
963a6fe8fa
Merge branch 'trunk' into phillmv/improve-gh-at-inspect 2024-12-03 11:52:46 -05:00
William Martin
7c241cf4e6
Merge pull request #9992 from cli/wm/fix-pr-checkout-panic 
Fix PR checkout panic when base repo is not in remotes
 2024-12-03 14:04:32 +01:00
nilvng
9c82156e86 issue #2329: move Interactive check to RunE 
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
 2024-12-03 22:28:02 +11:00
nilvng
985118e36a fix: update the copy 2024-12-03 20:13:38 +11:00
William Martin
694e565384 Fix PR checkout panic when base repo is not in remotes 2024-12-02 17:20:57 +01:00
Andy Feller
5a74934d19
Merge pull request #9983 from timrogers/timrogers/fork-rename 
When renaming an existing remote as part of remote creation in `gh repo fork`, log the change
 2024-12-02 10:30:03 -05:00
Kynan Ware
67df4a39fe
Merge pull request #9976 from cli/kw/Improve-DNF-version-clarity-in-install-steps 
Clarify which commands correspond to which DNF version under Linux install instructions
 2024-12-02 06:08:47 -07:00