William Martin
ecfb226d5d
Fix linting errors
2023-12-06 14:06:28 +01:00
William Martin
8d53c9e55e
Only migrate oauth token under new user
2023-12-06 14:06:28 +01:00
William Martin
ab5103f061
Don't set user level git protocol and don't switch
2023-12-06 14:06:28 +01:00
William Martin
08c659bdf8
Document that git protocol during login is host level
2023-12-06 14:06:28 +01:00
William Martin
553b89f30c
Add tests for AuthConfig TokenForUser
2023-12-06 14:06:28 +01:00
Sam Coe
587007a562
Additional auth status tests
2023-12-06 14:06:28 +01:00
William Martin
15ba536317
Ensure subtests use the right t during setup
2023-12-06 14:06:28 +01:00
William Martin
c165d5ccc0
Use isolated config in logout cmd tests
2023-12-06 14:06:28 +01:00
William Martin
c9a6b7cc00
Always mock the keyring in NewIsolatedTestConfig
2023-12-06 14:06:28 +01:00
William Martin
0a7871c6d3
Use real config in setupgit cmd tests
2023-12-06 14:06:28 +01:00
William Martin
20dd95b88d
Use real config in token cmd tests
2023-12-06 14:06:28 +01:00
William Martin
748d59ec64
Use real config in auth refresh tests
2023-12-06 14:06:28 +01:00
William Martin
239f983ad4
Use real config in auth check tests
2023-12-06 14:06:28 +01:00
William Martin
dc0f6d55e2
Use real config in fork cmd tests
2023-12-06 14:06:28 +01:00
William Martin
5b3e7290be
Use real config and env in login cmd tests
2023-12-06 14:06:28 +01:00
Sam Coe
e806664ef7
New UX for auth status
2023-12-06 14:06:28 +01:00
William Martin
8e89af96e8
Write tests for SwitchUser
2023-12-06 14:06:28 +01:00
William Martin
a0e5e4c709
Use NewIsolatedTestConfig in AuthConfig tests
2023-12-06 14:06:28 +01:00
Sam Coe
760dc91faa
Include environment variable users in auth status output
2023-12-06 14:06:28 +01:00
William Martin
b2997cc7bd
Handle multi account golden path in auth status
2023-12-06 14:06:28 +01:00
William Martin
e4ed4041cd
Use auth config and only print stdout in status
2023-12-06 14:06:28 +01:00
William Martin
5d10beb60a
Use config to look up user for status
2023-12-06 14:06:28 +01:00
William Martin
08c7bd1df2
Use real config and login in status tests
2023-12-06 14:06:28 +01:00
Sam Coe
eca5f72328
UX polish and standardization of language
2023-12-06 14:06:28 +01:00
William Martin
98381e63c9
Refactor switch test to be more structural
2023-12-06 14:06:28 +01:00
William Martin
7667fbdb5a
Handle logout having no candidates
2023-12-06 14:06:28 +01:00
William Martin
df274d4f3a
Implement auth switch
2023-12-06 14:06:28 +01:00
Sam Coe
2fc6dbd851
Add user flag to auth logout command
2023-12-06 14:06:28 +01:00
William Martin
72d5550407
Implemented auth logout for multiaccount
2023-12-06 14:06:28 +01:00
William Martin
1bf6023164
Display message when logging into existing account
2023-12-06 14:06:28 +01:00
William Martin
a9acece7dd
Split Login into adding a user and switching
...
It makes clear the steps that should be needed to "switch" which should be
shared between Login (add user and switch to it), Logout (remove user and switch
to another), and Switch (no modification and switch to a user)
2023-12-06 14:06:28 +01:00
William Martin
c4fcf9ba1a
Add test to ensure login command allows multiple users
2023-12-06 14:06:28 +01:00
William Martin
209aed30b4
Fix typo on migration comment
2023-12-06 14:06:28 +01:00
William Martin
a00294eff9
Fix double negatives in migration errors
2023-12-06 14:06:28 +01:00
William Martin
06c36a74c2
Remove host entries without valid tokens during migration
2023-12-06 14:06:28 +01:00
Sam Coe
4f33d88c5f
Set user level config values automatically when setting host level config values
2023-12-06 14:06:28 +01:00
Sam Coe
38b73e3f85
Set host level git_protocol on login
2023-12-06 14:06:28 +01:00
Sam Coe
eb771aecc9
Address PR comments
2023-12-06 14:06:28 +01:00
Sam Coe
d2ff55737c
Enable multi-account migration
2023-12-06 14:06:28 +01:00
Sam Coe
68e30beac4
Logout removes token from keyring using username
2023-12-06 14:06:28 +01:00
Sam Coe
2ca8b1ea94
Login sets token in keyring using username
2023-12-06 14:06:28 +01:00
Sam Coe
d8084f5f6d
Hide all keyring package implementation inside internal keyring package
2023-12-06 14:06:28 +01:00
Sam Coe
e0ebbc9e88
Add auth token migration to multi account migration
2023-12-06 14:06:28 +01:00
William Martin
9efa7248a9
Initial multi-account migration work
2023-12-06 14:06:28 +01:00
Andy Feller
cd2a6ad6dc
Merge pull request #8420 from cli/andyfeller/triage-the-final-enhancements
...
andyfeller/triage the final enhancements
2023-12-05 09:00:16 -05:00
Andy Feller
8302a293d0
Fix triage workflow, restore PR support
...
This commit reverts the triage workflow to restore the previous PR support using the `pull_request_target`, which is more secure as it doesn't allow fork repositories to change the workflow before it runs.
Additionally, this fixes an issue currently causing the workflow to break as cli/cli uses the `discuss` label but github/cli uses the `triage` label.
2023-12-05 08:46:45 -05:00
Andy Feller
bdfdc42624
Revert "Update triage.yml"
...
This reverts commit 3be9a0ed85
2023-12-05 08:33:00 -05:00
Zach Steindler
6eb650185b
Add progress indicator when installing an extension ( #8411 )
2023-12-04 19:52:11 +00:00
Sam Coe
08fb744229
Simplify git AddRemote to remove unused arg ( #8392 )
2023-12-04 15:48:08 -04:00
Andy Feller
fe390533c8
Merge pull request #8412 from cli/andyfeller/triage-patch
...
Simplify triage workflow given GitHub Actions limitations on OSS pull requests
2023-12-04 14:06:46 -05:00
