Commit graph

121 commits

Author SHA1 Message Date
nate smith
ee0fe61b04 test nonzero exit code 2019-10-30 17:46:34 -05:00
nate smith
ab115efd89 add cases to test for 2019-10-30 17:06:49 -05:00
nate smith
fdbf85e9ab sigh worthy mechanism for selecting arbitrary git outputs 2019-10-30 16:45:11 -05:00
nate smith
f6afe1b576 use testing hack to mock git call 2019-10-30 16:34:23 -05:00
nate smith
9efe96575e actually add command 2019-10-30 12:01:54 -05:00
nate smith
dfd567bf7f blindly committing the state of these files 2019-10-30 12:00:35 -05:00
nate smith
5087ec5c15 restore pr create with new context/client 2019-10-30 12:00:16 -05:00
Corey Johnson
eefb6d13ee Merge pull request #34 from github/no-global
Eliminate package-level global state
2019-10-29 17:18:03 -07:00
Mislav Marohnić
862db45587 Add mising files 2019-10-29 21:19:34 +01:00
Mislav Marohnić
51b08f871e Merge pull request #37 from github/remove-readme-redirect
Remove redirect to helper-cli from the README
2019-10-29 21:18:27 +01:00
Mislav Marohnić
343ccaf0cb Merge remote-tracking branch 'origin/master' into no-global 2019-10-29 21:17:14 +01:00
Mislav Marohnić
39a6feba9c Now able to use api in oauth flow 2019-10-29 21:16:35 +01:00
Mislav Marohnić
f786802e9e Customizable API client 2019-10-29 21:07:03 +01:00
Julian Nadeau
642276faf8 Remove redirect to helper-cli from the README 2019-10-29 13:43:47 -04:00
Mislav Marohnić
e7159254b4 Merge pull request #31 from github/stop-vendor
Stop requiring vendored dependencies in CI
2019-10-28 15:05:01 +01:00
Mislav Marohnić
8370602f49 WIP eliminate package-level state in commands, context 2019-10-25 21:49:08 +02:00
Mislav Marohnić
641de86427 Eliminate package-level state in git remote parsing 2019-10-25 21:48:25 +02:00
Corey Johnson
07322341f8 Merge pull request #32 from github/update-readme
Update the README.md
2019-10-24 15:29:47 -07:00
Corey Johnson
c46f4d94ce Update README.md 2019-10-23 14:18:06 -07:00
Mislav Marohnić
6d8af20e30 Stop requiring vendored dependencies in CI
We started vendoring dependencies because this was a practice that the Go community had for a while now to:

1. Speed up builds - no need to fetch dependencies every time;
2. Guard against 3rd-party downtime - CI passes even if hosts such as `gopkg.in` are down, or if someone deletes their GitHub repo/account hosting a particular module.

With Go 1.13 and GitHub Actions, however, we have these problems solved for free:
- The built-in goproxy caches dependencies and speeds up downloads;
- Octofactory ensures that dependencies are cached on our own infrastructure, guarding us from 3rd-party downtime.

With all this in mind, I feel that we don't have to require vendoring dependencies anymore.
2019-10-23 22:35:11 +02:00
Nate Smith
24ebdc23b5 Merge pull request #27 from github/fix-repo-branch-flags
Fix global `--repo`, `--current-branch` functionality
2019-10-21 13:38:14 -05:00
Nate Smith
398bd27d02 Merge pull request #6 from github/oauth
OAuth authentication flow
2019-10-18 15:01:39 -05:00
Mislav Marohnić
c82e38353f Fix global --repo, --current-branch functionality
Turns out I've tried to use the flags' value too early: they are not yet
parsed out at package `init()` time.
2019-10-18 19:24:16 +02:00
Mislav Marohnić
5aca575964 Wire up OAuth authentication flow to initialize config file
The config file is now `~/.config/gh`.
2019-10-18 19:08:11 +02:00
Mislav Marohnić
2aa77fb8ea Add Context.SetAuthToken 2019-10-18 18:47:42 +02:00
Mislav Marohnić
de85294c79 Extract OAuth logic into a struct 2019-10-18 15:44:46 +02:00
Mislav Marohnić
7bf306f022 Generate and verify random "state" value
This is for extra security during OAuth flow.
2019-10-18 15:44:46 +02:00
Mislav Marohnić
216ffb89e2 Use random available port number 2019-10-18 15:44:46 +02:00
Mislav Marohnić
db0084f623 One weird trick to prevent macOS firewall popup
Discovered by a stay-at-home developer!
2019-10-18 15:44:46 +02:00
Mislav Marohnić
d90552454d Preliminary OAuth flow 2019-10-18 15:44:44 +02:00
Corey Johnson
e2767b463c Merge pull request #25 from github/pr-view-tests
Add tests for `gh pr view`
2019-10-17 10:48:09 -07:00
Corey Johnson
a25fa5d66b Merge remote-tracking branch 'origin/master' into pr-view-tests 2019-10-17 10:39:49 -07:00
Corey Johnson
2df6c914d6 Merge pull request #26 from github/rm-binary
rm accidentally checked-in binary
2019-10-17 09:39:42 -07:00
Mislav Marohnić
252e29e577 Merge pull request #17 from github/ghr-context
add context package
2019-10-17 17:30:17 +02:00
Mislav Marohnić
d334d56f09 Test FindByName 2019-10-17 16:10:45 +02:00
Mislav Marohnić
51c70dd918 Add test for invalid remote URLs 2019-10-17 16:05:25 +02:00
Mislav Marohnić
183db99535 Ensure remote URL parsing tests don't read user SSH config files 2019-10-17 15:58:26 +02:00
Mislav Marohnić
344906bf03 Test SSH config parser 2019-10-17 15:50:17 +02:00
Mislav Marohnić
79e8766d8f Use eq in more tests 2019-10-17 14:44:53 +02:00
Mislav Marohnić
74c637fec8 Improve config file parsing 2019-10-17 14:34:55 +02:00
Mislav Marohnić
c09eb742c3 Keep original order of remotes 2019-10-17 13:46:35 +02:00
Mislav Marohnić
25c90ed265 go mod tidy 2019-10-17 02:26:32 +02:00
Mislav Marohnić
63f4026367 🔥 github package 2019-10-17 02:25:59 +02:00
Mislav Marohnić
a8aa5feb02 Test remote parsing 2019-10-17 02:25:59 +02:00
Mislav Marohnić
8016d80884 Create overridable Context interface 2019-10-17 02:25:59 +02:00
Mislav Marohnić
12e295e46b Merge remote-tracking branch 'origin/master' into ghr-context 2019-10-17 02:23:00 +02:00
Mislav Marohnić
b48c71a125 rm accidentally checked-in binary 2019-10-17 02:14:36 +02:00
Corey Johnson
32c9cb9892 Great work corey 2019-10-16 16:28:56 -07:00
Corey Johnson
b69dff172c Remove caching
I removed this because it was making tests fail!
2019-10-16 16:26:32 -07:00
Corey Johnson
9e97712956 Add fixture 2019-10-16 16:26:13 -07:00