Mislav Marohnić
c2f3537a32
Separate "main" package from "ghcs" package
...
To make "ghcs" importable, this separates out the `main()` function into
its own package that lives under "cmd/ghcs/main". Typically the main
package would be called "cmd/ghcs", but we wanted to leave the current
ghcs implementation where it is to avoid causing conflicts with current
work in progress.
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:26:20 +02:00
Alan Donovan
ce4bbe5bd8
list: show branch (not name) in branch column
2021-09-17 10:13:35 -04:00
Raffaele Di Fazio
23c9026f58
Merge branch 'main' into raffo/delete-codespaces
2021-09-17 16:13:12 +02:00
Alan Donovan
d23eca8c5f
remove "list" operation from "delete -r" command
2021-09-17 09:51:11 -04:00
Alan Donovan
747d7e7173
Restore confirmation to delete -r, lost in botched merge
2021-09-17 09:49:46 -04:00
Alan Donovan
6ac8a0ad88
Merge pull request #165 from github/delete-parallel
...
Delete in parallel
2021-09-17 09:34:10 -04:00
Alan Donovan
610ab89c3d
Merge branch 'main' into delete-parallel
2021-09-17 09:32:56 -04:00
Alan Donovan
4de4572813
add comment
2021-09-17 09:31:05 -04:00
Alan Donovan
fb197c8e75
Merge branch 'main' into delete-parallel
2021-09-17 09:30:48 -04:00
Raffaele Di Fazio
c6b5fb5ba3
add the tests
...
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:55:50 +02:00
Raffaele Di Fazio
054fec0ba1
address code comments
...
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:45:08 +02:00
Mislav Marohnić
bb86145cb6
Merge pull request #4331 from cli/repo-create-prompt-error
...
Do not swallow prompt error during `repo create`
2021-09-17 14:37:24 +02:00
Max Beizer
a4f1fa076b
Fix up all the static-check warnings ( #162 )
2021-09-17 13:10:37 +02:00
Raffaele Di Fazio
29c2a17866
Update cmd/ghcs/delete.go
...
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 08:55:54 +02:00
Alan Donovan
bc74c4aafa
make delete --repo parallel
2021-09-16 18:29:19 -04:00
Jose Garcia
42e47a98d7
add docs, simplify map, error on invalid args
2021-09-16 15:22:47 -04:00
Sam
0f7c4d94af
Merge pull request #4328 from cli/fix-sync-fetch
...
Allow user input for git fetch in repo sync
2021-09-16 10:15:26 -07:00
Raffaele Di Fazio
455dabb484
use named params
...
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 18:49:44 +02:00
Raffaele Di Fazio
22e9da790c
Update internal/api/api_test.go
...
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
2021-09-16 18:43:16 +02:00
Raffaele Di Fazio
35e0f95243
Update cmd/ghcs/delete.go
...
Co-authored-by: CamiloGarciaLaRotta <camilogarcialarotta@github.com>
2021-09-16 18:42:41 +02:00
Sam Coe
0305788536
Typo
2021-09-16 09:02:10 -07:00
Raffaele Di Fazio
5cd90fea88
fix linter
...
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:45:07 +02:00
Raffaele Di Fazio
68f4cad1af
implement delete all with thresold
...
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 16:42:53 +02:00
Jose Garcia
8a0f8b6d1c
parse ssh args and command
2021-09-16 10:32:27 -04:00
Christian Gregg
cc1b86461e
Confirm deletion of codespaces with unpushed/uncommited changes ( #129 )
...
Adds a confirmation dialog on `ghcs delete` if the codespace in question
has unpushed or uncommited changes.
This confirmation can be skipped using the `--force` or `-f` flag.
Closes : #84
Closes : #10
2021-09-16 13:47:15 +01:00
Mislav Marohnić
f9e49f4aec
Do not swallow prompt error during repo create
2021-09-16 12:25:44 +02:00
Mislav Marohnić
5617db6614
Merge pull request #151 from github/ruleguard
...
Wrap errors using "%w" instead of "%v"
2021-09-16 12:21:36 +02:00
Mislav Marohnić
dbb4e0c177
Merge remote-tracking branch 'origin' into ruleguard
2021-09-16 11:46:50 +02:00
vilmibm
eeca998640
binary extension support in gh extension install
2021-09-15 18:46:17 -05:00
Jose Garcia
514448dde8
Merge branch 'main' of github.com:github/ghcs into jg/ssh-cmd-flags
2021-09-15 15:45:53 -04:00
Jose Garcia
10ad85486f
Merge pull request #154 from github/jg/fix-ctx-error
...
ghcs create/ssh: fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 15:45:35 -04:00
Jose Garcia
45a9715e9f
Merge pull request #158 from github/jg/go-liveshare-0.16.0
...
upgrade to go-liveshare 0.16.0
2021-09-15 15:40:58 -04:00
Jose Garcia
b2234969e4
update logs
2021-09-15 15:40:07 -04:00
Alan Donovan
eafadd3757
Merge pull request #156 from github/api-internal
...
move api to internal/api
2021-09-15 15:38:11 -04:00
Jose Garcia
c5bd8c4127
initial spike to accept args
2021-09-15 15:37:37 -04:00
Jose Garcia
26d3199082
add back codespaces.Shell
2021-09-15 15:18:54 -04:00
Jose Garcia
ecd0c70567
upgrade to go-liveshare 0.16.0
2021-09-15 15:15:28 -04:00
Jose Garcia
0f72e3d886
defer stopPolling and docs
2021-09-15 14:29:16 -04:00
Alan Donovan
06719866c9
move api to internal/
2021-09-15 13:13:10 -04:00
Jose Garcia
547c629220
fix ctx cancellation errors & fix todo for X11 forwarding
2021-09-15 10:38:19 -04:00
Jose Garcia
22433a57db
Merge pull request #18 from github/jg/ssh-server-docs
...
ssh server: docs
2021-09-15 09:52:31 -04:00
Jose Garcia
20e618fd02
pr feedback
2021-09-15 13:49:03 +00:00
Jose Garcia
8abff2af97
move StartSSHServer to Session
2021-09-15 13:14:58 +00:00
Alan Donovan
2de51a8ec8
Merge pull request #17 from github/rm-terminal
...
Remove Terminal, no longer needed by ghcs
2021-09-15 09:06:49 -04:00
Mislav Marohnić
fb5a35568c
Ensure original errors are wrapped with "%w" instead of "%v"
2021-09-15 13:58:41 +02:00
Jose Garcia
497b45e4e2
ssh server docs
2021-09-14 23:57:40 +00:00
Sam Coe
600c387bd2
Address PR comments
2021-09-14 10:56:21 -07:00
Andrew Hsu
e13398f6b4
fix browse of markdown files with line ranges ( #4310 )
...
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-09-14 16:08:19 +02:00
Sam Coe
952ebc8eb2
Change to v2 import statements
2021-09-13 14:56:13 -07:00
Sam Coe
78067e0a89
Merge branch 'trunk' into feature/gpg-key
2021-09-13 14:50:56 -07:00