Commit graph

4949 commits

Author SHA1 Message Date
Sam Coe
7e920a3b66
Add some small UX polish 2021-09-13 14:43:10 -07:00
Jose Garcia
3abde5f0c5 Merge pull request #148 from github/jg/remove-deprecation-msg
remove all deprecation messages and deprecated functionality
2021-09-13 14:44:40 -04:00
Mislav Marohnić
d7f7a98d81
Merge pull request #4320 from cli/site-ssh-key
Publish docs site using a deploy key instead of PAT
2021-09-13 19:43:39 +02:00
Mislav Marohnić
6f3b1eb080
Merge pull request #3967 from despreston/des/3839-warn-limit
show warning when limit exceeds search api max
2021-09-13 19:30:16 +02:00
Sam Coe
a8492bb0ea
Allow user input for git fetch in repo sync 2021-09-13 10:14:20 -07:00
Jose Garcia
f5adc9e3a7 remove all deprecation messages and deprecated functionality 2021-09-13 10:58:00 -04:00
Mislav Marohnić
2f45173370 Publish docs site using a deploy key instead of PAT
I'd like to decommission SITE_GITHUB_TOKEN as it's a PAT that has write
access to all my `github/*` repositories. Instead, I've created a deploy
key that only has access to `github/cli.github.com`.

    ssh-keygen -t ed25519 -C "gh docs push" -N "" -f ~/.ssh/gh-docs-publish
    gh repo -R github/cli.github.com deploy-key add ~/.ssh/gh-docs-publish.pub

    # testing:
    GIT_SSH_COMMAND='ssh -i $HOME/.ssh/gh-docs-publish' git push ...
2021-09-13 16:30:40 +02:00
Alan Donovan
a5b985523c Merge pull request #147 from github/tty-windows
Don't assume stdin/stdout fds are 0/1 on windows
2021-09-13 09:30:39 -04:00
Alan Donovan
c4be0a0e28 this time without compile errors 2021-09-13 09:29:46 -04:00
Issy Long
74a4afcd77 Merge pull request #139 from github/fix-version-string
goreleaser: Fix version string replacement
2021-09-13 10:32:19 +01:00
Siarhei Fedartsou
1926971a76 Remove non-relevant test 2021-09-12 21:04:03 +03:00
Siarhei Fedartsou
f3053c3628 fix tests 2021-09-12 20:58:13 +03:00
Siarhei Fedartsou
373d1efb58 format code 2021-09-12 20:50:21 +03:00
Siarhei Fedartsou
11466fda12 Add --draft and --non-draft filters to gh pr list 2021-09-12 20:48:23 +03:00
Alan Donovan
1526ab5bff fix URL 2021-09-10 18:08:48 -04:00
Alan Donovan
af301bfff1 stdin/stdout fds are not 0/1 on windows 2021-09-10 17:36:20 -04:00
Jose Garcia
3ca3dd05a1 Merge pull request #143 from github/jg/ssh-flags
ghcs ssh: make flag description consistent
2021-09-10 16:04:09 -04:00
Jose Garcia
ad600d22ed merge upstream 2021-09-10 16:03:09 -04:00
Alan Donovan
8b06ffe2bd Merge pull request #145 from github/remove-script
Remove go-ghcs-crypto vendor script
2021-09-10 15:48:40 -04:00
Alan Donovan
5b23d87d47 Remove Terminal, no longer needed by ghcs 2021-09-10 15:15:05 -04:00
Jose Garcia
6c907869ff Merge pull request #144 from github/jg/remove-terminal
ghcs ssh: remove terminal, bash_profile setup
2021-09-10 15:06:18 -04:00
Jose Garcia
798075045e remove terminal, bash_profile setup 2021-09-10 14:58:47 -04:00
Jose Garcia
31e1d974aa Merge pull request #142 from github/jg/delete-flags
ghcs delete: deprecate argument/subcommands & introduce flags
2021-09-10 14:17:44 -04:00
Alan Donovan
2fe71e3576 Merge pull request #138 from github/sigint-delay
Wait forever for SIGINT delivery
2021-09-10 14:15:36 -04:00
Jose Garcia
34e52ba24a deprecate subcommands 2021-09-10 14:11:50 -04:00
Alan Donovan
9b1ed00ae3 Merge pull request #140 from github/crypto
fork go-ghcs-crypto repo into internal module
2021-09-10 14:11:27 -04:00
Jose Garcia
28ab023b07 Merge pull request #133 from github/jg/ports-flags
ghcs ports: deprecate codespace arg, introduce global flag
2021-09-10 13:33:26 -04:00
Jose Garcia
9b9e533cb9 add comment for special handling 2021-09-10 13:32:30 -04:00
Alan Donovan
efb2569d2b move vendored go-ghcs-crypto to internal module 2021-09-10 12:29:25 -04:00
Issy Long
810c127608 goreleaser: Fix version string replacement
- The `Version` variable casing changed in 6a4950cf7a (diff-d897a31624bae4fe935e8dc2243f41626c68639be6643535297c06935277ffb4), so we need to update our version setting code.
- Otherwise, for `ghcs 0.11.0`, `ghcs --version` would print "DEV".
2021-09-10 16:17:37 +01:00
Alan Donovan
4f6cab195a wait for sigint delivery 2021-09-10 10:08:54 -04:00
Jose Garcia
219a22ef12 Merge pull request #137 from github/jg/liveshare-0.15.0
go-liveshare 0.15.0
2021-09-10 08:35:15 -04:00
Alan Donovan
c06d56fa20 Merge pull request #136 from github/sigint
deliver SIGINT to self after Ctrl-C in survey
2021-09-09 18:10:09 -04:00
Jose Garcia
fe2d5ebf37 merge upstream + pr feedback 2021-09-09 17:22:07 -04:00
Jose Garcia
467c695122 Merge pull request #16 from github/jg/ignore-pf-errs
port forwarder: ignore conn errors
2021-09-09 17:00:47 -04:00
Jose Garcia
272ea57b54 revert comment update 2021-09-09 21:00:09 +00:00
Alan Donovan
0afdcdec84 Merge pull request #126 from github/lightstep
ghcs: add --lightstep flag for tracing
2021-09-09 16:41:38 -04:00
Alan Donovan
2cbe120774 return err, don"t fatal 2021-09-09 16:39:41 -04:00
Alan Donovan
22f9824ec8 deliver SIGINT to self after Ctrl-C in survey 2021-09-09 16:33:39 -04:00
Jose Garcia
efe519cb7a comments + fix Forward method 2021-09-09 20:11:45 +00:00
Jose Garcia
920f793c6d pr feedback 2021-09-09 19:33:16 +00:00
Jose Garcia
1ff5c514fb fix erroneous ctx waiting and introduce back io.EOF handling 2021-09-09 18:35:05 +00:00
Alan Donovan
ee44ecc944 include span context in HTTP request 2021-09-09 13:42:44 -04:00
Alan Donovan
2b4e881018 Merge pull request #15 from github/lightstep
Add OpenTelemetry instrumentation
2021-09-09 13:31:20 -04:00
Jose Garcia
8b0e8c990e ignore pf conn errors 2021-09-09 17:31:18 +00:00
Alan Donovan
af541ad5f2 Merge pull request #132 from github/ask-tty
consolidate survey functions
2021-09-09 12:43:00 -04:00
Mislav Marohnić
3b20dfc032
Merge pull request #4299 from andrewhsu/fix-project-layout
fix link to code in project-layout doc
2021-09-09 18:16:47 +02:00
Jose Garcia
81f08e7baf start converting to flags 2021-09-09 12:08:07 -04:00
Alan Donovan
b96341a5f9 Merge branch 'main' into ask-tty 2021-09-09 12:01:55 -04:00
Alan Donovan
cbb8253544 consolidate survey functions 2021-09-09 11:57:37 -04:00