Jose Garcia
ebb04d1753
format code
2021-08-31 19:52:32 +00:00
Jose Garcia
535d832f8a
small tweak
2021-08-31 15:50:04 -04:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e
address review comments
2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
b63972b62f
spell Live Share product name correctly in UI
2021-08-31 11:07:26 -04:00
Alan Donovan
fee4b484ea
Merge pull request #102 from github/fix-12
...
remove sleep 1s in ssh subcommand
2021-08-31 09:20:35 -04:00
Alan Donovan
dc40d99096
Merge pull request #103 from github/fix-EnvironmentNotShutdown
...
in Start, ignore HTTP 503 with reason 7 EnvironmentNotShutdown
2021-08-31 09:18:45 -04:00
Alan Donovan
15dab395a5
in Start, ignore HTTP 503 with reason 7 EnvironmentNotShutdown
2021-08-30 18:23:55 -04:00
Alan Donovan
ea97e2e73d
remove sleep 1s
2021-08-30 18:15:37 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Alan Donovan
4af240d87d
handle errors in port forwarding
2021-08-30 17:36:28 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
wilso199
2dba58bfa8
Using gh executable from PATH in favor of the resolved path
2021-08-30 16:57:43 -04:00
Edmundo Gonzalez
954d46dce5
Changes from comments on pr.
2021-08-30 17:30:28 +00:00
Mislav Marohnić
b0b67014f1
Suggest to re-authenticate to fix "SAML enforcement" error
...
As far as I can put together, this error appears when someone has
authenticated GitHub CLI with a PAT that isn't authorized to access a
certain org. It can also happen if someone has authorized GitHub CLI
using the legacy "GitHub CLI (dev)" OAuth app instead of our production
OAuth app.
Doing `gh auth refresh` will re-authenticate the user using our
production "GitHub CLI" OAuth app which will not have problems accessing
resources in different GitHub organizations.
2021-08-30 17:18:59 +02:00
Mislav Marohnić
e6ff77ce73
Merge pull request #4239 from Jernik/trunk
...
add quotes around `@me` in documentation to ensure examples work on ps
2021-08-30 16:27:33 +02:00
Luke
1102de89be
add quotes around @me in documentation to ensure examples work on powershell
2021-08-30 09:13:43 -05:00
Edmundo Gonzalez
0c066cbd09
Fix compilation error.
2021-08-30 05:05:43 +00:00
Edmundo Gonzalez
ee36a005b1
Merge remote-tracking branch 'origin/main' into edgonmsft/codespaces-ssh-rpc
2021-08-30 05:01:22 +00:00
Edmundo Gonzalez
13917a289d
Moved function to ssh.go file.
2021-08-30 04:52:27 +00:00
Edmundo Gonzalez
5db9e2d83e
PR changes.
2021-08-30 04:48:56 +00:00
Jose Garcia
3967d0c623
Merge pull request #64 from github/jg/dotfiles-status
...
Post create status support on create
2021-08-27 18:24:21 -04:00
Jose Garcia
634796e8a8
merge main
2021-08-27 18:18:30 -04:00
Jose Garcia
0cf2640c86
better docs and stop ticker
2021-08-27 18:14:10 -04:00
Alan Donovan
c053bd0bde
Merge pull request #95 from github/main-style
...
cmd/ghcs: style tweaks
2021-08-27 18:13:53 -04:00
Alan Donovan
54a9e74565
Merge branch 'main' into main-style
2021-08-27 18:12:38 -04:00
Jose Garcia
272af2fadf
add docs
2021-08-27 18:12:06 -04:00
Alan Donovan
a7a57d8c65
Merge pull request #93 from github/defer-close
...
api: close HTTP response body stream on all control-flow paths
2021-08-27 18:11:35 -04:00
Alan Donovan
dcf4f041e9
deal with Start errors, non-JSON
2021-08-27 18:01:52 -04:00
Jose Garcia
adc1ee5e2d
merge main
2021-08-27 17:43:43 -04:00
Jose Garcia
a5a18026cc
fix linter
2021-08-27 17:39:10 -04:00
Jose Garcia
368e8c6110
simplify contract for state polling
2021-08-27 17:34:06 -04:00
Alan Donovan
4545e11ffc
Merge branch 'main' into defer-close
2021-08-27 17:33:46 -04:00
Alan Donovan
9f082ca887
Merge branch 'main' into main-style
2021-08-27 17:30:34 -04:00
Jose Garcia
c66cf0da39
Merge pull request #92 from github/jg/remove-dst-port
...
Remove destination port column and add docs
2021-08-27 17:06:48 -04:00
Jose Garcia
e5f45d4bfa
docs and improvement to the showStatus implementation
2021-08-27 16:41:22 -04:00
Jose Garcia
1e8a8370fe
initial round of PR feedback
2021-08-27 16:29:02 -04:00
Alan Donovan
e423cb0ef9
display colon and cursor in survey prompts
2021-08-27 16:09:02 -04:00
Alan Donovan
44a22d6965
Merge pull request #97 from github/vscode-error
...
ghcs code: improve vscode error
2021-08-27 15:56:03 -04:00
Alan Donovan
8b395b5ab5
ghcs code: improve vscode error
2021-08-27 15:53:55 -04:00
Alan Donovan
a5ae72cb26
revert removal of _ = f() to pacify linter
2021-08-27 15:38:41 -04:00
Alan Donovan
d8f1baa519
more SKU renames.
2021-08-27 15:36:45 -04:00
Alan Donovan
da34d12abb
respond to review
2021-08-27 15:26:34 -04:00
Alan Donovan
90f3ac6f56
check status codes
2021-08-27 14:23:33 -04:00
Jose Garcia
2cc91c224e
add comment for improvements
2021-08-27 12:53:27 -04:00
Jose Garcia
da8655209b
make things private
2021-08-27 12:52:30 -04:00
Jose Garcia
cb6552f4ca
more efficient impl for processing states
2021-08-27 12:50:32 -04:00
Alan Donovan
38ff786a7d
cmd/ghcs: style tweaks
2021-08-27 12:03:20 -04:00
Jose Garcia
8e95493872
period
2021-08-27 15:46:40 +00:00