Commit graph

4949 commits

Author SHA1 Message Date
lepasq
87e5e6f2e3 Add topic filter to repository listing 2021-08-14 19:12:59 +02:00
Jose Garcia
79111d85ac Merge pull request #4 from github/jg/port-forwarding-errors-test-server
Port forwarding improvements & slight refactor
2021-08-13 08:41:43 -04:00
Mislav Marohnić
a7fc43bc5f Add hint about argument to extensions remove usage synopsis 2021-08-12 15:41:17 +02:00
Mislav Marohnić
ac6c859ca0 Print "Upgrade available" instead of "Update available"
This is because we have an `upgrade` command, not `update` command.
2021-08-12 15:40:46 +02:00
Mislav Marohnić
fbe1487dd0
Merge pull request #4112 from cli/extension-cmd-rename
Rename `gh extensions` → `gh extension`
2021-08-12 15:35:01 +02:00
Mislav Marohnić
0c99f7d8d5
Merge pull request #4051 from cli/extensions-overhaul
Rework local extensions for Windows
2021-08-12 15:33:56 +02:00
Mislav Marohnić
e567ce00cd
Merge pull request #4102 from cli/sync-no-checkout
Repo sync optimizations
2021-08-12 15:33:32 +02:00
Mislav Marohnić
20d75f0ff9 Normalize logging, output, and error reporting
- Return errors as errors, not print to stdout and return nil
- Ensure errors and warnings are always written to stderr, not stout
- Do not print progress to stdout unless stdout is a terminal
2021-08-12 14:37:23 +02:00
Mislav Marohnić
41e223869e Fix mapping port numbers to labels 2021-08-12 14:37:06 +02:00
Mislav Marohnić
db95f2f71f Add machine-readable output functionality to ports command 2021-08-12 14:35:49 +02:00
Mislav Marohnić
e35d41ec1f Add PowerShell instructions to completions help 2021-08-12 12:56:46 +02:00
Mislav Marohnić
bf9c49eccd Rename gh extensionsgh extension
This is for compatibility with other core commands which are all singular.
2021-08-11 22:22:39 +02:00
Mislav Marohnić
3946606e5e Use symlinks on most platforms and keep using plain files on Windows 2021-08-11 22:11:24 +02:00
Mislav Marohnić
c39dd1e3eb
Merge pull request #4109 from ShaharyarAhmed-bot/dev
Check path for git executable before auth
2021-08-11 19:27:37 +02:00
Mislav Marohnić
21521b06b9 Check git presence during auth login only if it's going to be needed 2021-08-11 19:22:16 +02:00
Shaharyar Ahmed
e28236a447 Check path for git executable before auth
There was a bug where if git was not installed then gh would do its
authentication and try to configure git but would then find out that the
git executable was not in PATH.

Now gh checks to see if the git executable is in PATH before
authenticating the user. If the git executable is in PATH the
authentication continues as normal, if it is not in PATH then it prints
out an error to the console:

$ git executable not found in $PATH

Resolves: #3818
2021-08-11 19:22:16 +02:00
Mislav Marohnić
7a9d1fc331 Merge remote-tracking branch 'origin/main' into output-formats 2021-08-11 12:13:09 +02:00
Mislav Marohnić
4fa984a333
Merge pull request #4003 from despreston/3381-release-discussions
add --discussion-category flag to release cmd
2021-08-10 15:54:03 +02:00
Des Preston
bdc5b55f55 pr comments
Only add discussion category to request if there is one. This eliminates
the need to update old tests.

Renaming the variable to something shorter.
2021-08-10 09:47:49 -04:00
Mislav Marohnić
f4bded30f8 Mark test helper 2021-08-10 14:30:55 +02:00
Mislav Marohnić
6136a39ed6 Use remotes.FindByRepo() 2021-08-10 14:30:36 +02:00
Mislav Marohnić
0f1ab13b9e Only check if working copy is dirty when syncing current branch
In other cases, we don't have to abort the operation since it can
proceed without being affected by the working copy at all.
2021-08-10 14:29:23 +02:00
Mislav Marohnić
66ad6ad7d0 Avoid git checkout during gh repo sync
- If the local branch already exists, use `git update-ref`
- If it needs to be created, use `git branch <newbranch>`, but don't
  switch to the new branch

Bonus fixes
- Enables operation while on detached HEAD
- Enables operation even when the current remote doesn't track all
  branches in the remote repo (uses FETCH_HEAD instead of the
  `<remote>/<branch>` syntax)
2021-08-09 22:10:52 +02:00
Jose Garcia
eb2a176450 remove err print 2021-08-07 17:54:43 +00:00
Sam
c5371d5303
Merge pull request #3813 from cli/repo-sync
Add repo sync command
2021-08-05 19:39:40 -07:00
Jose Garcia
fbf0d28672 port forwarding err handling and test refactors 2021-08-06 01:03:03 +00:00
Mislav Marohnić
ac13fc807c
Merge pull request #4005 from despreston/835-rename-checkout
add --branch flag to pr checkout
2021-08-05 21:02:27 +02:00
Mislav Marohnić
9a485ddfa2 💅 Cleanup local branch handling during pr checkout 2021-08-05 20:44:34 +02:00
Des Preston
294a029e70 add --branch flag to pr checkout
Allows renaming the checked out branch.
2021-08-05 20:44:20 +02:00
Jose Garcia
619862a46b initial spike for multiple port support 2021-08-05 15:21:26 +00:00
Issy Long
2f1543a2d7 Merge pull request #62 from github/interactive-menu-for-deleting-a-codespace
cmd/ghcs/delete: Display the interactive menu when there are no args
2021-08-05 15:12:09 +01:00
Issy Long
4362b0b241 cmd/ghcs/delete: Display the interactive menu when there are no args
- Currently the flow to delete a single Codespace is `gh cs list`, copy
  and paste the Codespace name onto the end of `gh cs delete`.
- This improves consistency with other commands by letting the user
  choose which Codespace they want to delete, interactively. A Codespace
  name on the command-line still works too.
2021-08-05 15:00:18 +01:00
Jose Garcia
7b079d9855 Merge pull request #56 from github/jg/logs-cmd
ghcs logs
2021-08-05 08:09:48 -04:00
bchadwic
1f2ab7fbe4 pr and run check symbols revision 2021-08-05 02:13:55 -07:00
Sam Coe
174e26ecac
Fix tests 2021-08-04 18:26:30 -07:00
Sam Coe
2c4a662660
Rework git client interface 2021-08-04 18:13:58 -07:00
Sam Coe
00d67e3e5a
Remove unnecessary + 2021-08-04 17:10:50 -07:00
Sam Coe
86f16dbaf5
Use more idiomatic pattern 2021-08-04 17:00:20 -07:00
Sam Coe
c0756c2d1c
Clean up UX 2021-08-04 16:42:27 -07:00
bchadwic
5993018679 NEW functionality:
current folder '.', from current folder '.(pathsep)', parent folder '..(path sep)', absolute 'folder | filename'
2021-08-04 15:20:45 -07:00
bchadwic
7ef919d713 NEW functionality: current folder '.', from current folder '.(path sep)', parent folder '..(path sep)', absolute 'folder | filename' 2021-08-04 15:03:30 -07:00
Jose Garcia
76aca39f5b Create status support 2021-08-04 17:35:11 +00:00
Mislav Marohnić
140a54a009 Add machine-readable output formats
- Default table output (when stdout is attached to a terminal) stays the same;
- When stdout is redirected, output tab-separated values and no header line;
- With `--json` flag, output structured JSON data.

Example:

    $ ghcs list --json
    [
      {
        "Branch": "main",
        "Created At": "2021-06-10T15:04:46+02:00",
        "Name": "mislav-playground-jvqj",
        "Repository": "mislav/playground",
        "State": "Shutdown"
      },
      {
        "Branch": "master",
        "Created At": "2021-07-15T15:51:08+02:00",
        "Name": "mislav-github-github-pwgg365xv",
        "Repository": "github/github",
        "State": "Shutdown"
      }
    ]
2021-08-04 15:58:27 +02:00
Mislav Marohnić
95a515ecf0
Merge pull request #4087 from cli/graphql-error-fix
Fix unmarshalling GraphQL error type
2021-08-04 15:43:00 +02:00
Mislav Marohnić
90b7886142 Fix unmarshalling GraphQL error type
The "path" field of a GraphQL error object contains a mix of strings and
numbers and cannot be deserialized into `[]string`. Fortunately, we
don't need to rely on the "path" field and instead have the final error
message be constructed by aggregating human-readable "message" fields.
2021-08-04 15:34:53 +02:00
Mislav Marohnić
1007c1a3ae
Merge pull request #4079 from cli/no-label-colors
Disable colorizing labels in `issue list` output
2021-08-04 15:23:36 +02:00
Jose Garcia
70f4a7b4b5 Re-introduce secrets export 2021-08-04 13:19:00 +00:00
Mislav Marohnić
fddca21815
Merge pull request #4085 from marckhouzam/feat/compPowershell
Fixes #4084: Enable completion descriptions for powershell
2021-08-04 15:10:15 +02:00
Marc Khouzam
549caf29b5 Enable completion descriptions for powershell
Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
2021-08-04 07:45:30 -04:00
Mislav Marohnić
65d1124799 Close file after resolving faux symlinks on Windows
https://github.com/cli/cli/pull/4051/checks?check_run_id=3186063173
2021-08-03 16:46:04 +02:00