Commit graph

4949 commits

Author SHA1 Message Date
CamiloGarciaLaRotta
ba37311927 Merge pull request #30 from github/feat/richer-delete
feat: delete all & delete per repo
2021-07-22 10:10:58 -04:00
CamiloGarciaLaRotta
89cf916e23 Merge branch 'main' into feat/promptless-create 2021-07-22 10:09:21 -04:00
Camilo Garcia La Rotta
3ef0226e20 fix: output available machine names on --machine error 2021-07-22 10:07:09 -04:00
CamiloGarciaLaRotta
2f467e3ddc Merge branch 'main' into feat/richer-delete 2021-07-22 09:55:20 -04:00
Issy Long
8f73b18911 Merge pull request #33 from github/improve-descriptions
cmd/ghcs/*.go: Better short descriptions of what commands do
2021-07-22 14:19:07 +01:00
Issy Long
69865fa762 cmd/ghcs/main: Better description of ghcs as a whole
Co-authored-by: Camilo Garcia La Rotta <camilogarcialarotta@github.com>
2021-07-22 14:08:20 +01:00
Issy Long
b66d65379f cmd/ghcs/*.go: Better short descriptions of what commands do
- I ran `--help` on `ghcs code` and saw `ghcs code` and that was it,
  which was surprising. I expected a description.
- Here's a fix for all of the commands thus far to give them longer
  descriptions.
- I've only done "short" descriptions in Cobra terms, and removed the
  "long" descriptions as they seemed like they needed to be
  unnecessarily verbose.

Before:

```
❯ ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        code
  create      Create
  delete      delete
  help        Help about any command
  list        list
  ports       ports
  ssh         ssh

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ghcs ssh --help
ssh

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```

After:

```
❯ ./ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        Open a GitHub Codespace in VSCode.
  create      Create a GitHub Codespace.
  delete      Delete a GitHub Codespace.
  help        Help about any command
  list        List GitHub Codespaces you have on your account.
  ports       Forward ports from a GitHub Codespace.
  ssh         SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ./ghcs ssh --help
SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```
2021-07-22 11:07:23 +01:00
Jose Garcia
a99d0f5495 Better naming for rpc client and ssh session 2021-07-22 01:07:06 +00:00
Jose Garcia
fddcd876b0 Some more cleanup to the port forwarder and connection 2021-07-22 01:02:03 +00:00
Camilo Garcia La Rotta
a68cda1469 refactor: break down Create() into smaller funcs 2021-07-21 20:54:18 -04:00
Jose Garcia
7332aa428c Large refactor and solidifying of APIs before tests 2021-07-22 00:45:45 +00:00
Camilo Garcia La Rotta
3db217fef0 feat: make sku survey optional 2021-07-21 20:27:22 -04:00
Camilo Garcia La Rotta
aab98ccc18 feat: break out repo and branch surveys 2021-07-21 20:06:05 -04:00
Camilo Garcia La Rotta
c751e88120 feat: introduce repo, branch and machine flags for ghcs create 2021-07-21 19:56:08 -04:00
Jose Garcia
71a55b2126 Merge branch 'main' of github.com:github/go-liveshare 2021-07-21 18:54:13 -04:00
Camilo Garcia La Rotta
5ca2fa5562 feat: ghcs delete repo REPO_NAME 2021-07-21 18:13:36 -04:00
Camilo Garcia La Rotta
7a0a8fa39c feat: ghcs delete all 2021-07-21 18:02:50 -04:00
Camilo Garcia La Rotta
0d6926e14b doc: root cmd description 2021-07-21 17:41:50 -04:00
Sam Coe
340a1fdc93
Add --force flag for extensions upgrade 2021-07-21 11:06:22 -07:00
Jose Garcia
35f458b853 Merge pull request #28 from github/jg/fix-ssh
Fix ssh command order
2021-07-21 14:06:18 -04:00
Jose Garcia
532ee68165 Fix ssh command order 2021-07-21 14:04:42 -04:00
Jose Garcia
345e3e1b8a Update main.go 2021-07-21 13:50:19 -04:00
Jose Garcia
f7c80c99e7 Merge pull request #27 from github/jg/code-command
ghcs code command support
2021-07-21 13:48:10 -04:00
Jose Garcia
b44355d80d Merge pull request #26 from github/jg/secrets-and-server-port
Don't overwrite .zshenv, support server port for SSH, forward X11
2021-07-21 13:30:16 -04:00
Jose Garcia
c2b136a84f ghcs code command support 2021-07-21 13:28:47 -04:00
Mislav Marohnić
2801206663 Switch to Cobra's bash completion V2 2021-07-21 16:32:39 +02:00
Jose Garcia
3e50fff2c9 X11 support 2021-07-21 10:22:33 -04:00
Mislav Marohnić
6ed2e8f7f8 Add completion support to repo create --gitignore and --license 2021-07-21 16:12:38 +02:00
Mislav Marohnić
4d7625c8a0 Allow shell-completing multiple --json fields separated by commas 2021-07-21 16:12:38 +02:00
Mislav Marohnić
db8204dc56 Allow space to be added after completing issue/pr list --state values
The "nospace" directive instructs the shell completion logic to avoid
adding a space after completing the word. However, this feature was
broken in an older Cobra, and users still saw a space character added.
In most case we want the space because we anticipate that the user might
want to add extra arguments to the command.
2021-07-21 16:12:38 +02:00
Mislav Marohnić
3e8f075a8e Bump Cobra for improved completion support 2021-07-21 15:01:31 +02:00
Kristján Oddsson
aa0ef37ffc Merge pull request #25 from github/fix-error-message-wording-and-link
Update error message link and wording.
2021-07-21 13:01:07 +01:00
Kristján Oddsson
7a3e47ff3e Update error message link and wording. 2021-07-21 12:46:44 +01:00
bchadwic
285f8659b3 clean up 2021-07-21 01:11:38 -07:00
bchadwic
8962aeebf9 changed functionality to open up last commit with -c / --commit for gh browse 2021-07-21 01:08:15 -07:00
Jose Garcia
e81bee6886 Doesn't overwrite .zshenv and supports server-port 2021-07-20 18:43:43 -04:00
Sam
fa354a922b
Merge pull request #3905 from cli/extensions-list-notice
Add update checking to extensions list
2021-07-20 13:21:30 -07:00
Sam Coe
e70bdbf7a9
Add update checking to extensions list 2021-07-20 13:13:20 -07:00
Mislav Marohnić
3ff94ae76b
Merge pull request #4025 from cli/revert-3926-update-goreleaser-20210630
Revert "Update GoReleaser"
2021-07-20 22:02:49 +02:00
Mislav Marohnić
6c8abe9df6
Merge branch 'trunk' into revert-3926-update-goreleaser-20210630 2021-07-20 21:43:51 +02:00
Mislav Marohnić
85d0447a6e
Revert "Update GoReleaser to v0.172.1" 2021-07-20 21:39:50 +02:00
Mislav Marohnić
5bbce4a5b9 Fix goreleaser config for linux packages 2021-07-20 20:15:48 +02:00
Mislav Marohnić
ccd4f0fa9a
Merge pull request #3706 from cristiand391/improve-automerge
PR auto-merge improvements
2021-07-20 19:55:43 +02:00
Mislav Marohnić
a83c2924c5 Never prompt to delete branch if --auto was given 2021-07-20 19:49:19 +02:00
Mislav Marohnić
6e026412df Add "UNSTABLE" to immediately mergeable statuses
This status describes a state where the head branch is mergeable and
technically not blocked per base branch requirements, but it does have
non-passing checks.
2021-07-20 19:42:53 +02:00
Mislav Marohnić
6f2dfd7eea Adjust conditions for switching between regular and auto merge
Conditions prohibiting a regular merge: BLOCKED, BEHIND, DIRTY.

Conditions triggering a regular merge even if `--auto` was set: CLEAN,
HAS_HOOKS.

Note that UNKNOWN status does not trigger either of the conditions.
2021-07-20 19:34:32 +02:00
Mislav Marohnić
0ab9c70c3f Merge remote-tracking branch 'origin' into improve-automerge 2021-07-20 18:45:47 +02:00
Mislav Marohnić
1ca49a8bcd
Merge pull request #3980 from cli/bump-survey
Bump Survey library for cursor improvements
2021-07-20 18:34:14 +02:00
Mislav Marohnić
2624ed9d8c Merge remote-tracking branch 'origin' into bump-survey 2021-07-20 18:28:58 +02:00
Mislav Marohnić
4a7b130511
Merge pull request #3981 from cli/bump-gojq
Bump gojq to latest version
2021-07-20 18:27:07 +02:00