Commit graph

5081 commits

Author SHA1 Message Date
vilmibm
ef08712354 test list 2021-09-28 19:27:21 -05:00
vilmibm
3971df4f93 switch to stubBinaryExtension 2021-09-28 19:23:28 -05:00
vilmibm
392460b81e WIP switching to stubBinaryExtension 2021-09-28 15:45:49 -05:00
vilmibm
541ed3ba6f test Upgrade with binary exts 2021-09-28 15:33:11 -05:00
vilmibm
22c1778b9f TODOs 2021-09-28 15:04:45 -05:00
vilmibm
94778a9cb0 un-stupid the file mode 2021-09-28 15:04:39 -05:00
vilmibm
1fe49fa776 fix listing, cleanup 2021-09-28 13:07:01 -05:00
vilmibm
54ec5329c5 add ability to upgrade binary extensions 2021-09-28 13:03:00 -05:00
vilmibm
db5bbf799f use manager io in Upgrade 2021-09-28 13:03:00 -05:00
Mislav Marohnić
7673622830 Mount gh codespace command 2021-09-28 17:03:05 +02:00
Mislav Marohnić
f749590e87 Replace old "github/ghcs" import statements 2021-09-28 16:57:56 +02:00
Mislav Marohnić
e64607d07b Merge remote-tracking branch 'ghcs/main' into import-codespaces
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-28 16:46:27 +02:00
Mislav Marohnić
f947ef3448 Remove lightstep configuration
The `github.com/shirou/gopsutil` dependency of lightstep-tracer is
giving us trouble during building.

Ref. https://github.com/shirou/gopsutil/issues/976

Another build problem raises its head even after we upgrade gopsutil to
a version where the above bug is fixed.
2021-09-28 16:42:35 +02:00
Mislav Marohnić
0483765da5 Merge pull request #190 from github/app-struct
Introduce an App struct that executes core business logic
2021-09-28 15:46:57 +02:00
Alan Donovan
4015af0427 Merge pull request #192 from github/json-error
create: decode JSON error heuristically
2021-09-27 18:04:55 -04:00
Alan Donovan
57d9b1a9e1 create: decode JSON error heuristically 2021-09-27 14:51:52 -04:00
Nate Smith
425bc64859
Merge pull request #4090 from bchadwic/pr-checks
Revised pending and skipped symbols for pr checks / run commands
2021-09-27 09:25:21 -07:00
Mislav Marohnić
4d5ec86b17
Merge pull request #4291 from rethab/patch-1
docs: add hint how to use use stdin in api command
2021-09-27 14:24:30 +02:00
Reto Hablützel
f6e9734f17 add more hints to docs 2021-09-25 08:38:26 +02:00
rethab
f5b0d01e86 docs: add hint how to use use stdin in api command 2021-09-25 08:11:47 +02:00
Rasmus Wriedt Larsen
9e3893e104 Also set pushRemote on gh pr checkout from fork
As explained in https://git-scm.com/docs/git-config#Documentation/git-config.txt-branchltnamegtremote
if you have `remote.pushDefault` set in your global gitconfig (like I
do), then _that_ setting will take precedence over
`branch.<name>.remote` 😞

However, `branch.<name>.pushRemote` will take precedence over your
`remote.pushDefault` setting, such that
`gh pr checkout 123 && make changes && git push` will just work, even if
you have `remote.pushDefault` set 💪
2021-09-24 16:38:25 +00:00
Mislav Marohnić
c82d4c5472 Avoid passing params struct as pointer 2021-09-24 17:36:18 +02:00
Mislav Marohnić
dc8f6ef183 No longer accept a logger in CreateCodespace
The API layer shouldn't concern itself with logging progress to stderr.
Instead, we will subsequently add progress indicators in the caller
around CreateCodespace and other potentially slow commands as needed.
2021-09-24 17:30:31 +02:00
Mislav Marohnić
ca0f89d3bc Introduce an App struct that executes core business logic
The Cobra commands are now a light wrapper around the App struct.

Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-24 17:20:34 +02:00
Mislav Marohnić
8807b3a73a Merge pull request #184 from github/args-constraint
Consistently institute constraints for position arguments and improve error message
2021-09-24 16:02:36 +02:00
Mislav Marohnić
92d0abd6ab Merge pull request #79 from github/raffo/delete-codespaces
Add code and command to delete unused codespaces
2021-09-24 16:02:05 +02:00
Mislav Marohnić
3d017b2824 Fix stderr output on delete errors 2021-09-24 15:09:41 +02:00
Mislav Marohnić
750c3e38f3
Merge pull request #4243 from wilso199/3704-credential-helper
Fixes #4274
2021-09-24 14:50:59 +02:00
Mislav Marohnić
b38ce24497 Ensure correct path to gh after gh auth refresh git credential setup 2021-09-24 14:43:48 +02:00
Mislav Marohnić
d853ce5bc9 Avoid resolving executable() until requested at runtime
This is to avoid hitting the filesystem and resolving symlinks
unnecessarily. The value of executable is just used conditionally by a
handful of commands.
2021-09-24 14:42:41 +02:00
Mislav Marohnić
78b35b7b6e Merge remote-tracking branch 'origin' into 3704-credential-helper 2021-09-24 14:35:01 +02:00
Nate Smith
96aed38819
Merge pull request #4308 from cli/ext-bin
install binary extensions
2021-09-23 10:51:37 -07:00
Jose Garcia
4eb15134a4 Merge pull request #189 from github/jg/inline-go-liveshare
Inline go-liveshare v0.20.0
2021-09-23 13:45:11 -04:00
Jose Garcia
5d6ea5029e Linter fixes 2021-09-23 13:36:04 -04:00
Jose Garcia
65dcb0f428 Linter fixes 2021-09-23 13:22:20 -04:00
Jose Garcia
08bc181d79 Linter fixes 2021-09-23 13:16:20 -04:00
Jose Garcia
b8f35f950c Linter fixes 2021-09-23 13:14:35 -04:00
Mislav Marohnić
75c1dfdf49 Fetch codespace by name directly if name argument given 2021-09-23 18:57:22 +02:00
Jose Garcia
c4114cc972 Linter fixes 2021-09-23 11:58:55 -04:00
Jose Garcia
fb53ccb06a Linter fixes 2021-09-23 11:56:41 -04:00
Jose Garcia
958990cef8 More linter fixes 2021-09-23 11:47:52 -04:00
Jose Garcia
d0c65e5490 Linter fixes 2021-09-23 11:36:27 -04:00
Jose Garcia
f4396e8f1a Inline go-liveshare with history 2021-09-23 11:28:04 -04:00
Jose Garcia
9ae7eb5869 Merge branch 'go-liveshare-download' into jg/inline-go-liveshare 2021-09-23 11:19:46 -04:00
Jose Garcia
6ca35d0e73 Moved files to liveshare dir 2021-09-23 11:18:49 -04:00
Mislav Marohnić
e8212a80a9 Print delete failures as they occur 2021-09-23 17:14:25 +02:00
Mislav Marohnić
1232dba684 Merge remote-tracking branch 'origin' into raffo/delete-codespaces 2021-09-23 16:43:22 +02:00
Jose Garcia
3e26a15342 Merge pull request #188 from github/jg/update-liveshare
Update to go-liveshare v0.20.0
2021-09-23 10:22:09 -04:00
Jose Garcia
f1c35ba9da Update docs 2021-09-23 10:21:01 -04:00
Jose Garcia
fb12f4108f Merge pull request #181 from github/jg/poll-on-async-creation
ghcs create: poll for codespaces that are being retried by the server
2021-09-23 10:10:57 -04:00