Commit graph

5081 commits

Author SHA1 Message Date
vilmibm
b00e8a5681 more accurately check for binary extension 2021-09-20 16:02:20 -05:00
Jose Garcia
7f682f9c39 Close Live Share sessions
- New helper method codespaces.CloseSession to be used using defer
- Upgrade to go-liveshare v0.17.0
2021-09-20 16:56:57 -04:00
Jose Garcia
82d7733f43 Merge pull request #19 from github/jg/session-closer-tidy-up
Allow clients to Close a Session, general tidy up
2021-09-20 16:36:16 -04:00
Jose Garcia
40886479ae Close SSH even if RPC Close fails 2021-09-20 20:35:12 +00:00
Alan Donovan
dbb80d8b1e check for authorised SSH keys 2021-09-20 16:01:43 -04:00
Sam
02ed5a9666
Merge pull request #4316 from SiarheiFedartsou/sf-pulls-draft
Add `--draft` and `--non-draft` filters to `gh pr list`
2021-09-20 12:07:52 -07:00
Sam Coe
d14715f1e3
Convert bool to string early for pr list draft flag 2021-09-20 11:29:37 -07:00
Alan Donovan
9e08b7477d delete: reject position args 2021-09-20 13:40:45 -04:00
Mislav Marohnić
b894d3e134 Simplify delete implementation 2021-09-20 18:37:00 +02:00
Dan Burzo
9f43967042 Fixes #4346: allow git+https URL protocol 2021-09-20 19:35:06 +03:00
Raffaele Di Fazio
c222c3d696 drop check on shut down
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 18:23:00 +02:00
Jose Garcia
57d04dc5f0 Allow clients to Close a Session, general tidy up
- Allow clients to call Close on a Session to clean up resources
- Switch to the %w verb for error wrapping
- Fix typo on Port struct after verifying the server does not have a
  typo
2021-09-20 13:16:38 +00:00
Mislav Marohnić
836075215d Merge remote-tracking branch 'origin' into cli-migration 2021-09-20 13:59:32 +02:00
Jose Garcia
85f79ed8e8 Merge pull request #159 from github/jg/ssh-cmd-flags
ghcs ssh: ssh flags and command support
2021-09-20 07:43:16 -04:00
Raffaele Di Fazio
c4f0eda96d force was actually needed by a next commit
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 11:54:30 +02:00
Raffaele Di Fazio
eca3ecb43b Merge branch 'main' into raffo/delete-codespaces 2021-09-20 11:53:35 +02:00
Raffaele Di Fazio
4721e7004b add threshold to delete by repo
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 11:10:44 +02:00
Raffaele Di Fazio
11024f71fa force is not used in delete by repo
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-20 10:27:29 +02:00
Jose Garcia
82c19729d3 Wrap -- with optional argument brackets 2021-09-17 15:17:38 -04:00
Jose Garcia
47c6a5fce8 Update usage 2021-09-17 15:13:09 -04:00
Siarhei Fedartsou
6a34f53c6c Change pr list --draft UX 2021-09-17 22:05:47 +03:00
Jose Garcia
5890d6ad66 Switch if block logic, assert err string 2021-09-17 15:04:55 -04:00
Jose Garcia
da58313358 Remove redudant type def 2021-09-17 14:03:31 -04:00
Jose Garcia
9f84015bd0 Avoid append 2021-09-17 14:00:16 -04:00
Jose Garcia
65e1c6f789 More test cases 2021-09-17 13:56:38 -04:00
Jose Garcia
76037ee753 Update docs, simplify loop to append to command 2021-09-17 13:54:00 -04:00
Jose Garcia
54265afda0 PR Feedback
- use named returns
- handle command flags + test case
- simplify tests
2021-09-17 13:43:23 -04:00
Jose Garcia
60d066f0a6 PR Feedback
- return nil for slices
- handle `-L -l` case
- document `parseSSHArgs`
2021-09-17 11:51:37 -04:00
Alan Donovan
67a6f0a85d Merge pull request #168 from github/restore-delete-r-confirm
Restore confirmation to delete -r, lost in botched merge
2021-09-17 11:48:02 -04:00
Alan Donovan
1271e20b9b Merge pull request #169 from github/delete-no-list
delete -r: don't perform "list" operation
2021-09-17 11:28:53 -04:00
Alan Donovan
930f194507 Merge pull request #170 from github/list-show-branch-not-name
list: show branch (not name) in branch column
2021-09-17 11:28:26 -04:00
Mislav Marohnić
8c0c7a8e19 Make GITHUB_TOKEN configurable through Go member
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:29:35 +02:00
Mislav Marohnić
c2f3537a32 Separate "main" package from "ghcs" package
To make "ghcs" importable, this separates out the `main()` function into
its own package that lives under "cmd/ghcs/main". Typically the main
package would be called "cmd/ghcs", but we wanted to leave the current
ghcs implementation where it is to avoid causing conflicts with current
work in progress.

Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 16:26:20 +02:00
Alan Donovan
ce4bbe5bd8 list: show branch (not name) in branch column 2021-09-17 10:13:35 -04:00
Raffaele Di Fazio
23c9026f58 Merge branch 'main' into raffo/delete-codespaces 2021-09-17 16:13:12 +02:00
Alan Donovan
d23eca8c5f remove "list" operation from "delete -r" command 2021-09-17 09:51:11 -04:00
Alan Donovan
747d7e7173 Restore confirmation to delete -r, lost in botched merge 2021-09-17 09:49:46 -04:00
Alan Donovan
6ac8a0ad88 Merge pull request #165 from github/delete-parallel
Delete in parallel
2021-09-17 09:34:10 -04:00
Alan Donovan
610ab89c3d Merge branch 'main' into delete-parallel 2021-09-17 09:32:56 -04:00
Alan Donovan
4de4572813 add comment 2021-09-17 09:31:05 -04:00
Alan Donovan
fb197c8e75 Merge branch 'main' into delete-parallel 2021-09-17 09:30:48 -04:00
Raffaele Di Fazio
c6b5fb5ba3 add the tests
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:55:50 +02:00
Raffaele Di Fazio
054fec0ba1 address code comments
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-17 14:45:08 +02:00
Mislav Marohnić
bb86145cb6
Merge pull request #4331 from cli/repo-create-prompt-error
Do not swallow prompt error during `repo create`
2021-09-17 14:37:24 +02:00
Max Beizer
a4f1fa076b Fix up all the static-check warnings (#162) 2021-09-17 13:10:37 +02:00
Raffaele Di Fazio
29c2a17866 Update cmd/ghcs/delete.go
Co-authored-by: Jose Garcia <josebalius@github.com>
2021-09-17 08:55:54 +02:00
Alan Donovan
bc74c4aafa make delete --repo parallel 2021-09-16 18:29:19 -04:00
Jose Garcia
42e47a98d7 add docs, simplify map, error on invalid args 2021-09-16 15:22:47 -04:00
Sam
0f7c4d94af
Merge pull request #4328 from cli/fix-sync-fetch
Allow user input for git fetch in repo sync
2021-09-16 10:15:26 -07:00
Raffaele Di Fazio
455dabb484 use named params
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-09-16 18:49:44 +02:00