Commit graph

5081 commits

Author SHA1 Message Date
Jose Garcia
efc6fd369c merge upstream 2021-09-08 13:37:35 -04:00
Jose Garcia
5569cc56c6 Merge pull request #120 from github/jg/output-logger
output pkg: new Errorln method and add comments
2021-09-08 13:34:14 -04:00
Jose Garcia
fda40a9682 new Errorln method and add comments 2021-09-08 10:29:30 -04:00
Mislav Marohnić
156872c5db
Merge pull request #4271 from wrslatz/4201-extension-doc
Document installing extensions using full repo URL
2021-09-07 14:33:41 +02:00
Alan Donovan
07300aeb38 Merge pull request #119 from github/silence-errors
ghcs: don't double-print errors
2021-09-07 07:12:57 -04:00
Alan Donovan
d395dae3a8 don't double-print errors 2021-09-06 15:17:24 -04:00
Alan Donovan
dd5fe49420 Merge pull request #114 from github/listen-race
Update to go-liveshare@v0.12.0
2021-09-06 14:56:20 -04:00
Mislav Marohnić
2a2088dc89 💅 tweak extension docs 2021-09-06 20:04:40 +02:00
Mislav Marohnić
d731cb9c73 Fix determining current process location 2021-09-06 16:57:59 +02:00
Mislav Marohnić
55c3064f45 Merge remote-tracking branch 'origin' into 3704-credential-helper 2021-09-06 16:16:52 +02:00
Mislav Marohnić
619333adb6 Avoid using error values to pass information about the search cap 2021-09-06 16:09:18 +02:00
Des Preston
e8b015b80d show warning when limit exceeds search api max
Fixes #3839
2021-09-06 16:05:11 +02:00
Siarhei Fedartsou
8f581fa450 Extend test for params.go 2021-09-05 21:25:48 +03:00
Siarhei Fedartsou
a133e9d9a7 Add --head filter to gh pr list 2021-09-05 21:13:16 +03:00
wrslatz
28cbfc4aab
Document installing extensions using full repo URL 2021-09-03 18:14:10 -04:00
Jose Garcia
b79ea871fd rename arg 2021-09-03 16:04:00 -04:00
Alan Donovan
5c26d1488f Merge pull request #14 from github/ssh-close-workaround
add workaround for ssh.channel.Close EOF
2021-09-03 15:13:20 -04:00
Alan Donovan
50523c4f10 remove ListenTCP and add workaround for ssh.channel.Close EOF 2021-09-03 14:39:47 -04:00
Alan Donovan
9e81dc7fde fix missing error return 2021-09-03 12:56:47 -04:00
Alan Donovan
2c660fa2e5 avoid ListenTCP helper 2021-09-03 12:55:40 -04:00
Alan Donovan
43198b24aa use errgroup 2021-09-03 12:50:11 -04:00
Jose Garcia
9193b03b69 introduce follow, deprecate tail 2021-09-03 12:40:01 -04:00
Jose Garcia
9dbf267e54 codespace flag, deprecate argument 2021-09-03 12:33:47 -04:00
Jose Garcia
3216cbc07f codespace flag, deprecate argument 2021-09-03 11:43:10 -04:00
Jose Garcia
b1d83fe294 codespace flag, deprecate argument 2021-09-03 11:33:33 -04:00
Alan Donovan
a56a84947a Update ghcs for go-liveshare@v0.12.0 2021-09-03 10:11:29 -04:00
Mislav Marohnić
8f3b6749d7
Merge pull request #4241 from cli/saml-error
Suggest to re-authenticate to fix "SAML enforcement" error
2021-09-03 16:10:16 +02:00
Alan Donovan
10a129b764 Merge pull request #13 from github/listen-race
move Listen call into clients to avoid race
2021-09-03 10:05:02 -04:00
Alan Donovan
e2552fbd2a rename to ForwardToListener 2021-09-03 09:43:31 -04:00
Alan Donovan
5bd0519ef3 move Listen call into clients to avoid race 2021-09-02 17:52:49 -04:00
Alan Donovan
88146a16a0 Merge pull request #110 from github/join-session
Update to go-liveshare v0.11.0
2021-09-02 17:26:01 -04:00
Alan Donovan
786a631995 fix local/remote confusion in getPorts (!) 2021-09-02 17:21:24 -04:00
Alan Donovan
981b2545bc sketch of changes for https://github.com/github/go-liveshare/pull/13 2021-09-02 17:08:17 -04:00
Alan Donovan
1162c8adff fix go vet loopclosure finding 2021-09-02 16:02:09 -04:00
Alan Donovan
4e2c20606a Merge branch 'main' into join-session 2021-09-02 15:57:34 -04:00
Alan Donovan
cee761238b update go-liveshare@v0.11.0 2021-09-02 15:54:00 -04:00
Alan Donovan
3485bacc97 fix StartSharing data race 2021-09-02 15:53:56 -04:00
Alan Donovan
b4686935b9 Merge pull request #12 from github/fix-share-data-race
Fix data race in StartSharing
2021-09-02 15:44:49 -04:00
Alan Donovan
4438b85e29 comment tweaks 2021-09-02 15:41:36 -04:00
Alan Donovan
94319d4cfe move localPort parameter to ForwardToLocalPort 2021-09-02 15:34:57 -04:00
Alan Donovan
94b91661cc don't forget to close conn in case of sharing error 2021-09-02 14:30:19 -04:00
Jose Garcia
ab47e97540 Merge pull request #112 from github/jg/start-errs
api start: ignore any 7 err code in start
2021-09-02 14:14:41 -04:00
Jose Garcia
090af2290b pr feedback 2021-09-02 14:13:40 -04:00
Mislav Marohnić
029d49f3b3
Merge pull request #4199 from cli/go-module-v2
Rename the module to "github.com/cli/cli/v2"
2021-09-02 20:10:09 +02:00
Alan Donovan
87b15aa264 Fix data race in StartSharing 2021-09-02 14:03:48 -04:00
Mislav Marohnić
e0fa56dc29 Merge remote-tracking branch 'origin' into go-module-v2 2021-09-02 20:02:16 +02:00
Nate Smith
49652cdefa
Update pkg/cmd/run/cancel/cancel.go
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2021-09-02 12:57:50 -05:00
Jose Garcia
5c65cfd249 ignore any 7 err code in start 2021-09-02 13:42:52 -04:00
Nate Smith
1af6a669e3
Merge pull request #4214 from cli/garden-portability
Use `x/term` package for repo garden instead of shelling out to stty
2021-09-02 12:39:23 -05:00
Jose Garcia
881e6d5940 Merge pull request #111 from github/jg/remove-dir
ghcs ssh: remove dir command
2021-09-02 13:33:53 -04:00