Jose Garcia
c15d810d68
remove extra verb arg
2021-09-02 13:27:12 -04:00
Alan Donovan
8570f4111d
sketch after API changes in go-liveshare#11
2021-09-02 12:38:27 -04:00
Alan Donovan
e9cb521bfd
Merge pull request #11 from github/session
...
rename Server to Session and simplify API
2021-09-02 12:37:00 -04:00
Alan Donovan
6f45c7fa7d
point out data races to be fixed
2021-09-02 12:14:04 -04:00
Alan Donovan
23ea329f2e
Merge branch 'main' into session
2021-09-02 11:49:13 -04:00
Alan Donovan
05a3d90a99
more tweaks
2021-09-02 11:39:29 -04:00
Alan Donovan
34c20cf105
Merge pull request #10 from github/rpc-fixes
...
fix two data races in rpcHandler
2021-09-02 11:38:38 -04:00
Alan Donovan
65c19a3317
Merge pull request #107 from github/spelling-again
...
use correct correct spelling of codespace
2021-09-02 11:38:25 -04:00
Alan Donovan
4cceda1af0
rename Server to Session and simplify API
2021-09-02 11:06:58 -04:00
Alan Donovan
45f9ae76f4
Merge pull request #108 from github/update-liveshare
...
Update go-liveshare to v0.10.0
2021-09-02 09:48:28 -04:00
Alan Donovan
c31fc05746
more typo fixes
2021-09-02 09:09:05 -04:00
Alan Donovan
af38292f1e
fix data races
2021-09-01 18:18:43 -04:00
Alan Donovan
ca6d074333
Merge branch 'main' into wip
2021-09-01 17:55:31 -04:00
Alan Donovan
72a2099a50
fix breakage from API changes
2021-09-01 17:50:24 -04:00
Alan Donovan
49ccdd3d21
use correct correct spelling of codespace
2021-09-01 17:26:26 -04:00
Jose Garcia
ef8dde4d2e
Merge pull request #106 from github/jg/sku-params
...
ghcs create: pass branch for sku selection, pre-select if only one is returned
2021-09-01 16:43:02 -04:00
Jose Garcia
bfeb4e77c9
remove dir command
2021-09-01 14:38:37 -04:00
Jose Garcia
2163aba3d5
pass branch for sku selection, pre-select if only one is returned
2021-09-01 13:54:45 -04:00
Mislav Marohnić
abfe29617a
Merge pull request #4253 from despreston/4248-line-range
...
feat(4248): add support for line range w/ browse
2021-09-01 18:08:51 +02:00
Alan Donovan
55fa17d8bc
wip
2021-08-31 17:30:40 -04:00
Alan Donovan
9964a444b0
Merge pull request #9 from github/liveshare-spelling
...
spell Live Share product name correctly in UI
2021-08-31 17:30:19 -04:00
Alan Donovan
c0fbb7e9fb
Merge pull request #99 from github/runcommand
...
preparatory cleanups to ssh tunnel/port forwarding code
2021-08-31 17:30:00 -04:00
Alan Donovan
3aad0bbeb4
check context error in PollPostCreateStates
2021-08-31 17:27:53 -04:00
Alan Donovan
37b2f5e979
Merge branch 'main' into runcommand
2021-08-31 17:18:52 -04:00
Alan Donovan
4a45feb7f0
Merge pull request #101 from github/fix-80
...
Suppress display of usage message after errors
2021-08-31 16:35:49 -04:00
Alan Donovan
6a527941bf
suppress display of usage message after errors
2021-08-31 16:35:28 -04:00
Des Preston
dafd0bfbd1
feat(4248): add support for line range w/ browse
...
Allow using a range of lines when browsing files. For example:
`gh browse test.go:10-20`
Closes #4248
2021-08-31 16:32:37 -04:00
Alan Donovan
5238f249f3
Merge pull request #105 from github/product-spelling
...
spell product names (Codespace, Live Share) correctly in UI
2021-08-31 16:24:47 -04:00
Alan Donovan
f1c3a22a0b
Merge branch 'main' into product-spelling
2021-08-31 16:24:41 -04:00
Alan Donovan
fc4c678d03
Merge pull request #8 from github/portfwd-errors
...
handle errors in port forwarding
2021-08-31 16:23:33 -04:00
Alan Donovan
68792d5aa5
Merge branch 'main' into runcommand
2021-08-31 16:19:37 -04:00
Edmundo Gonzalez
d6f52ae557
Merge pull request #91 from github/edgonmsft/codespaces-ssh-rpc
...
Implement RPC interface so that the codespaces agent starts and configures ssh in the codespace
2021-08-31 13:05:56 -07:00
Jose Garcia
ebb04d1753
format code
2021-08-31 19:52:32 +00:00
Jose Garcia
535d832f8a
small tweak
2021-08-31 15:50:04 -04:00
Alan Donovan
c0aae52289
move port choice, and PortForwarder.Start call, into clients
2021-08-31 13:58:46 -04:00
Alan Donovan
509e037a5e
address review comments
2021-08-31 12:02:29 -04:00
Alan Donovan
bbcf2dd321
spell product names (Codespaces, Live Share) correctly
2021-08-31 11:15:26 -04:00
Alan Donovan
b63972b62f
spell Live Share product name correctly in UI
2021-08-31 11:07:26 -04:00
Alan Donovan
fee4b484ea
Merge pull request #102 from github/fix-12
...
remove sleep 1s in ssh subcommand
2021-08-31 09:20:35 -04:00
Alan Donovan
dc40d99096
Merge pull request #103 from github/fix-EnvironmentNotShutdown
...
in Start, ignore HTTP 503 with reason 7 EnvironmentNotShutdown
2021-08-31 09:18:45 -04:00
Alan Donovan
15dab395a5
in Start, ignore HTTP 503 with reason 7 EnvironmentNotShutdown
2021-08-30 18:23:55 -04:00
Alan Donovan
ea97e2e73d
remove sleep 1s
2021-08-30 18:15:37 -04:00
Alan Donovan
40317e91f8
cleanup to ssh api
2021-08-30 17:46:04 -04:00
Alan Donovan
4af240d87d
handle errors in port forwarding
2021-08-30 17:36:28 -04:00
Edmundo Gonzalez
903b7be7de
Comments from pr.
2021-08-30 21:01:13 +00:00
wilso199
2dba58bfa8
Using gh executable from PATH in favor of the resolved path
2021-08-30 16:57:43 -04:00
Edmundo Gonzalez
954d46dce5
Changes from comments on pr.
2021-08-30 17:30:28 +00:00
Mislav Marohnić
b0b67014f1
Suggest to re-authenticate to fix "SAML enforcement" error
...
As far as I can put together, this error appears when someone has
authenticated GitHub CLI with a PAT that isn't authorized to access a
certain org. It can also happen if someone has authorized GitHub CLI
using the legacy "GitHub CLI (dev)" OAuth app instead of our production
OAuth app.
Doing `gh auth refresh` will re-authenticate the user using our
production "GitHub CLI" OAuth app which will not have problems accessing
resources in different GitHub organizations.
2021-08-30 17:18:59 +02:00
Mislav Marohnić
e6ff77ce73
Merge pull request #4239 from Jernik/trunk
...
add quotes around `@me` in documentation to ensure examples work on ps
2021-08-30 16:27:33 +02:00
Luke
1102de89be
add quotes around @me in documentation to ensure examples work on powershell
2021-08-30 09:13:43 -05:00
