Commit graph

1155 commits

Author SHA1 Message Date
Mislav Marohnić
77227a6c50 Trigger OAuth flow only when requesting auth token
Previously we would trigger OAuth flow when the config file did not
exist. Now we will let an empty Config object be initialized in that
case, but trigger OAuth flow when the Context caller requests an
AuthToken.
2020-06-02 13:24:39 +02:00
Mislav Marohnić
f42c9d4b2d Allow stubbing multiple config files 2020-06-02 13:19:21 +02:00
Mislav Marohnić
bfc3e4e43d
Merge pull request #916 from cli/cobra1.0
Upgrade to Cobra 1.0
2020-06-02 10:34:04 +02:00
Oscar Dominguez
dfdb5ee75d 📚 docs(typo): fix typo in gh pr review command 2020-05-31 12:10:47 +02:00
Mislav Marohnić
eab5af9449 Merge remote-tracking branch 'origin' into cobra1.0 2020-05-28 15:15:20 +02:00
Corey Johnson
a7e8d6fba8 Make PullRequestDiff take a pr 2020-05-27 10:10:21 -07:00
Corey Johnson
15770881bb Use an array 2020-05-27 10:08:29 -07:00
Corey Johnson
4b03cb112c Update test stubs 2020-05-27 09:21:02 -07:00
Corey Johnson
e341d7b49f Fix test 2020-05-27 08:38:30 -07:00
Mislav Marohnić
13ba0aa56e Respect GITHUB_TOKEN in api command 2020-05-27 13:09:05 +02:00
Mislav Marohnić
2e93a065b1 Merge remote-tracking branch 'origin/master' into api-command 2020-05-27 12:56:06 +02:00
Mislav Marohnić
c6643821dc Don't offer to reauthenticate for gist if GITHUB_TOKEN is used 2020-05-27 11:57:03 +02:00
Mislav Marohnić
ab0e43c6c8 Merge remote-tracking branch 'origin/master' into auth-from-env 2020-05-27 11:44:19 +02:00
Corey Johnson
30eb2d3ad6 Fix test 2020-05-26 17:08:34 -07:00
Corey Johnson
8d1f2745a4 wip 2020-05-26 16:35:35 -07:00
Corey Johnson
951e6d8d70 Add basic lookup functions 2020-05-26 13:18:53 -07:00
Amanda Pinsker
93dab323fa
Fix typo 2020-05-26 09:50:03 -07:00
Corey Johnson
3122696140
Merge pull request #982 from cli/remote-delete
Remote delete
2020-05-26 09:10:12 -07:00
Corey Johnson
6c5c7cf163 fix test 2020-05-26 08:37:53 -07:00
Corey Johnson
be5fc07928
Merge pull request #899 from cli/merge-interactive-merge
Interactive merge
2020-05-26 08:33:47 -07:00
Corey Johnson
b27df3410a Don't delete remote or local branches for forks 2020-05-26 08:07:18 -07:00
AliabbasMerchant
5b9e64b485 Fix incorrect docs in Issue&PR create 2020-05-26 08:00:51 +05:30
AliabbasMerchant
e910c039f0 Return error when it occurs 2020-05-26 07:50:59 +05:30
AliabbasMerchant
f95b8916f3 Use url package for setting query params 2020-05-26 07:45:14 +05:30
AliabbasMerchant
42edd42da1 Undo unnecessary renames 2020-05-26 07:10:28 +05:30
Nate Smith
9ebeb5fa91
Merge pull request #981 from cli/gist-create
gh gist create
2020-05-25 14:51:32 -05:00
AliabbasMerchant
5fc722fbb8 Query Params in Web mode of Issue/PR creation 2020-05-23 14:40:49 +05:30
Corey Johnson
9c075abe93 Fix tests 2020-05-22 17:45:04 -07:00
Corey Johnson
9a290d7f43 Change interactive merge language 2020-05-22 15:30:05 -07:00
Corey Johnson
9113092f5c Delete via api 2020-05-22 15:19:39 -07:00
Corey Johnson
ff97fc138d Still delete remote branch if repo flag is used 2020-05-22 15:12:48 -07:00
Corey Johnson
e643765027 Merge remote-tracking branch 'origin/merge-interactive-merge' into remote-delete 2020-05-22 15:09:29 -07:00
Corey Johnson
858cd705ab Update name 2020-05-22 15:07:39 -07:00
Corey Johnson
b2c1b12bee Don't delete branch if the repo flag is used 2020-05-22 14:39:53 -07:00
AliabbasMerchant
8bfc935860 Fix Incorrect Template Type 2020-05-23 01:05:27 +05:30
AliabbasMerchant
4fd051b21d Issue/PR template selection flow mirrors that of GitHub 2020-05-23 00:25:13 +05:30
AliabbasMerchant
864d74d0b1 Categorize Templates as Legacy and NonLegacy 2020-05-23 00:03:38 +05:30
Corey Johnson
41e67aa3e7 Fix typo 2020-05-22 10:04:02 -07:00
Mislav Marohnić
108f7bd66c Dirty workaround to display helpful error message on mistyped subcommands
When executing `gh pr re` (note the incomplete command name), Cobra
would just display the help text for `gh pr` on standard output, exit
with status 0, and not print any message that you have mistyped the
"re" subcommand. Each part of this behavior is wrong.

This workaround makes sure that the helpful error message is printed on
stderr:

    $ gh pr re
    unknown command "re" for "gh pr"

    Did you mean this?
            reopen
            ready
            review

However, the exit status is still 0, whereas it should be non-zero.
Since `HelpFunc` does not return an error argument, we cannot trigger an
error status from this workaround.
2020-05-22 19:02:34 +02:00
Mislav Marohnić
a33c00d389 Merge remote-tracking branch 'origin/master' into cobra1.0 2020-05-22 18:21:35 +02:00
Mislav Marohnić
1f3725c94d Use @me to avoid having to look up current user in pr status 2020-05-22 15:58:57 +02:00
vilmibm
5f28751555 just use a map + stdin test 2020-05-20 17:44:09 -05:00
vilmibm
f6137fa6ae handle json error in test 2020-05-20 17:16:59 -05:00
vilmibm
509be34af6 Merge remote-tracking branch 'origin/master' into wingkwong/master 2020-05-20 17:08:31 -05:00
vilmibm
f644c11edb tweak test 2020-05-20 17:03:56 -05:00
vilmibm
7453449d9a improve docs 2020-05-20 17:01:28 -05:00
Corey Johnson
ae70a814bd Update tests 2020-05-20 14:53:52 -07:00
vilmibm
93dc62f1b3 handle piped STDIN 2020-05-20 16:51:50 -05:00
Corey Johnson
80bdd1e071 print error 2020-05-20 14:36:09 -07:00
vilmibm
466edf8d0e take files as args. handle - 2020-05-20 16:27:28 -05:00