Corey Johnson
904c541d2d
Only delete local branch if it exists
2020-05-20 14:19:44 -07:00
Corey Johnson
a303dabc5d
Add remote deletion
2020-05-20 13:47:29 -07:00
Corey Johnson
46a1e3cd53
Remove convertRepoInterfaceToRepository
2020-05-20 11:19:31 -07:00
Corey Johnson
5d99c56456
combine conditionals
2020-05-20 09:21:59 -07:00
Corey Johnson
b4783dd192
don't always switch to the default branch
2020-05-20 09:00:39 -07:00
Mislav Marohnić
db9014fd7f
Respect auth token from GITHUB_TOKEN environment variable
...
If GITHUB_TOKEN is non-blank, it overrides authentication info found in
the config file. The config file is, in fact, never consulted.
2020-05-20 17:35:10 +02:00
Corey Johnson
76368f92ee
Return error
2020-05-20 08:32:08 -07:00
Corey Johnson
c3c3058b96
Merge remote-tracking branch 'origin/master' into merge-interactive-merge
2020-05-20 08:30:17 -07:00
Corey Johnson
1eedfe18bb
Update default text
2020-05-20 08:26:34 -07:00
Mislav Marohnić
767521c055
Stop providing AuthLogin from context
...
The login name of the authenticated user will be readily available only
if authentication info comes from the config file. With other upcoming
authentication modes (for example, the GITHUB_TOKEN environment
variable), the token is the only piece of information we got, so we
would need to additionally query for the login name.
Since `issue status` and `pr status` are the only commands that need the
name of the authenticated user right now, have those commands explicitly
query for the login name. This results in an additional API query, but
simplifies Context implementation and future authentication approaches.
2020-05-20 17:09:13 +02:00
Mislav Marohnić
bef62faaea
Make NewCmdApi testable
2020-05-20 15:21:35 +02:00
Mislav Marohnić
d8146cd16e
Extract cmdutil package
2020-05-20 15:21:31 +02:00
Mislav Marohnić
90fa193eaf
Promote api command to a pkg/cmd/api package
2020-05-20 15:21:31 +02:00
Mislav Marohnić
1609afe993
Add api command
2020-05-20 15:21:31 +02:00
Mislav Marohnić
fb63efcf05
Avoid crash around "DISMISSED" or "PENDING" reviewer states
2020-05-20 14:59:40 +02:00
Corey Johnson
9185bf9a77
Return an error
2020-05-19 13:52:22 -07:00
Corey Johnson
5c113d02c8
Big M
2020-05-19 13:39:36 -07:00
Corey Johnson
96e3d79f5e
add "try again" text
2020-05-19 13:39:31 -07:00
Nate Smith
45dec1b3e0
Merge pull request #962 from cli/pr-diff
...
pr diff
2020-05-19 14:11:36 -05:00
vilmibm
983a1d9c3c
better names
2020-05-19 14:08:20 -05:00
Corey Johnson
e0dbf37b5a
Merge pull request #960 from cli/prêt-à-réviser
...
Add `gh pr ready`
2020-05-19 11:29:33 -07:00
Corey Johnson
6666adbdce
Deal with merge conflicts
2020-05-19 11:29:00 -07:00
Corey Johnson
d209c0be01
Allow pr urls
2020-05-19 11:04:43 -07:00
vilmibm
c98b0924dc
properly handle REST errors
2020-05-19 11:58:49 -05:00
dulltz
821324c2fb
cosmetic
...
- Align the first letter to uppercase.
- Align with no period at the end.
2020-05-19 12:03:56 +09:00
vilmibm
ccda5ced51
lint
2020-05-18 17:45:47 -05:00
vilmibm
51b4212070
add basic tests
2020-05-18 17:39:54 -05:00
vilmibm
8e6b8d3901
cleanup
2020-05-18 17:23:36 -05:00
vilmibm
c159d41fc2
manually colorize
2020-05-18 17:15:48 -05:00
vilmibm
aaebdfc46f
working with gross colorize hack + no pager
2020-05-18 16:49:51 -05:00
Corey Johnson
fde5409a70
Update command/pr_test.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:40:04 -07:00
Corey Johnson
be927b34ae
Update command/pr_test.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:52 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go
...
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
2020-05-18 14:39:29 -07:00
vilmibm
b94860bae7
add command file with pr resolution
2020-05-18 15:43:27 -05:00
Corey Johnson
b42f5527fd
Remove hot dog
2020-05-18 13:27:23 -07:00
Corey Johnson
78bc7260e0
Add closed test
2020-05-18 13:08:57 -07:00
Corey Johnson
0b0070e725
Add "already marked" test
2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0
Can be marked ready for review
2020-05-18 12:42:16 -07:00
Corey Johnson
fad9f24f39
Make reopen work
2020-05-18 11:11:13 -07:00
Corey Johnson
350b4c85c0
Add failing test
2020-05-18 11:11:02 -07:00
vilmibm
228d01a037
reenable skipping body prompt for pr/issue
2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug
...
pass apiClient to determineBaseRepo
2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided ( #919 )
...
Fixes #882
2020-05-18 11:13:48 +02:00
AliabbasMerchant
6effcd4261
Allow choosing a blank issue/pr template
2020-05-18 00:37:28 +05:30
vilmibm
780875d645
fix tests
2020-05-15 16:47:11 -05:00
vilmibm
96ba1eacef
undo initial thing
2020-05-15 16:44:51 -05:00
vilmibm
bf05975ceb
Revert "small repo fix"
...
This reverts commit 08e9cdaee1 .
2020-05-15 16:40:47 -05:00
vilmibm
7decae71fc
untested first pass on ensureScopes
2020-05-15 16:40:13 -05:00
vilmibm
c8c807b954
pass apiClient to determineBaseRepo
...
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.
There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
2020-05-15 15:29:33 -05:00