Commit graph

1155 commits

Author SHA1 Message Date
Mislav Marohnić
c682d90466 Add tests for issue/pr create with metadata 2020-05-08 20:32:46 +02:00
Corey Johnson
b9c4a76687 Update usage docs 2020-05-08 11:20:00 -07:00
Mislav Marohnić
8c84d6881e Avoid aborting survey if reviewers/assignees/labels/projects/milestones are empty 2020-05-08 18:49:43 +02:00
Mislav Marohnić
1128439cd1 issue/pr create: hide "Add metadata" if viewer does not have triage permission 2020-05-08 18:37:08 +02:00
Corey Johnson
ba1b3424c1 Remove unused funcs
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-05-08 09:22:50 -07:00
Mislav Marohnić
d7e6d21766 Order projects, teams, and labels by name 2020-05-08 18:22:14 +02:00
Corey Johnson
70223d1e32 Don't always use the root command help
Co-Authored-By: Nate Smith <vilmibm@neongrid.space>
2020-05-08 09:19:19 -07:00
Mislav Marohnić
1f774b4158 Add spinner while loading metadata 2020-05-08 18:11:57 +02:00
Mislav Marohnić
34fc3457d6 Skip interactive mode in pr create if title & body were passed
This matches `issue create` behavior 4b32e3f215
2020-05-08 18:06:05 +02:00
Mislav Marohnić
cedf94f450 Name some values for readability 2020-05-08 17:58:33 +02:00
Mislav Marohnić
df144926b8 Rename data variable to something more descriptive 2020-05-08 17:56:47 +02:00
Mislav Marohnić
716036161b Rename titleBody (now a misnomer) to something more descriptive 2020-05-08 17:55:46 +02:00
Mislav Marohnić
72e99e9530 Merge branch 'issue-pr-create-metadata' into issue-pr-create-metadata-wizard 2020-05-08 17:46:47 +02:00
Mislav Marohnić
d0f168f4c3 Merge remote-tracking branch 'origin/master' into issue-pr-create-metadata 2020-05-08 17:46:17 +02:00
Mislav Marohnić
3000847bb2
Merge pull request #874 from cli/httpmock
Parallelism-safe mechanism for stubbing HTTP responses
2020-05-08 17:34:57 +02:00
vilmibm
6538cca693 switch to using body flag. small TODOs 2020-05-08 10:07:20 -05:00
vilmibm
46522a2add fix current branch tests 2020-05-07 14:51:17 -05:00
vilmibm
8a5290d2b4 clarify error msg 2020-05-07 14:51:08 -05:00
vilmibm
5dbec25f44 handle pr for branch case 2020-05-07 14:27:33 -05:00
Mislav Marohnić
93c61a83b2 Fix pr status -R crash with closed PR on the default branch
At the time we have a reference to `baseRepo`, we might still not have
contacted the API nor obtained any information about the default branch
for the repository. This expands the `PullRequests()` query to always
report the default branch so we may choose how to render entries that
belong on the current branch.
2020-05-07 20:53:03 +02:00
vilmibm
d81e622700 lightest weight reviewing
this commit add very basic non-interactive PR reviewing. You can either
review the "current" or a passed PR (number or URL) as approved, changes
requested, or commented via CLI flags.
2020-05-07 13:30:34 -05:00
Corey Johnson
ea6b3dca8c Update pr_test.go 2020-05-07 10:52:30 -07:00
Corey Johnson
58663dccfd Better description 2020-05-07 10:31:05 -07:00
Corey Johnson
5b78d47306 Use stdout 2020-05-07 10:30:59 -07:00
Corey Johnson
4b2f14d939 Use PR if given 2020-05-07 10:30:51 -07:00
Corey Johnson
1ea38af79c Fix merge usage syntax 2020-05-07 10:30:31 -07:00
Corey Johnson
2041f0ab1b Fix usage syntax 2020-05-07 10:30:23 -07:00
Corey Johnson
bcf41fd5e7 Fix sentence case 2020-05-07 10:30:14 -07:00
Mislav Marohnić
a7242f4ca3
Merge pull request #863 from cli/close-cmd-syntax
Tweak syntax in `issue/pr close` docs
2020-05-07 16:55:13 +02:00
Mislav Marohnić
5913a72532
Merge pull request #819 from rista404/interactive-when-defaults-807
Disable interactive mode for `issue create` if all flags are passed
2020-05-07 16:29:04 +02:00
Mislav Marohnić
0a4d4ee007 Replace FakeHTTP with httpmock which is now compatible 2020-05-07 15:19:14 +02:00
Mislav Marohnić
256d31950a Migrate a single test over to httpmock to demonstrate its use 2020-05-06 22:06:37 +02:00
Corey Johnson
3d21a33bac update test 2020-05-06 11:47:43 -07:00
Corey Johnson
1de57db74d Fix lint error 2020-05-06 11:27:41 -07:00
Corey Johnson
5a04679535 Remove debug output 2020-05-06 11:21:05 -07:00
Corey Johnson
8c85e14bac Make it work without a PR number 2020-05-06 11:19:00 -07:00
Corey Johnson
062c8353eb Add 'already merged' test 2020-05-05 15:11:06 -07:00
Corey Johnson
8681e7a7b6 Make squash and rebase work 2020-05-05 15:09:02 -07:00
Corey Johnson
c0831d4c4f Add merge api call 2020-05-05 11:56:45 -07:00
Corey Johnson
0aca0eff1f Add merge code 2020-05-05 11:35:27 -07:00
Corey Johnson
16ad382f4d Add simple merge test 2020-05-05 11:35:19 -07:00
Corey Johnson
8c9fdc768c Merge remote-tracking branch 'origin' into a-better-runcommand 2020-05-05 09:30:32 -07:00
Corey Johnson
4ef73a723d Update all calls to RunCommand 2020-05-05 09:20:01 -07:00
Nikola Ristic
1f9b7c0fe0
Disable interactive only if both flags are passed
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-05-05 16:34:31 +02:00
Mislav Marohnić
1834d8cfd5 Tweak syntax in issue/pr close docs
This makes it consistent with other subcommands under `issue/pr`.
2020-05-05 13:32:42 +02:00
Nate Smith
1a1fc64fe4
Merge pull request #842 from foad/df-805-hide-closed-default
Hide closed/merged PRs from default branch
2020-05-04 20:17:53 -05:00
Daniel Foad
e7e3a4f9b1
pr comments 2020-05-04 23:47:47 +01:00
vilmibm
f427d252d0 whitespace 2020-05-04 15:48:00 -05:00
vilmibm
1aab2084f1 cute command to show a thank you to contributors
this commit is the result of April's hack day. it animates a thank you
for a project's contributors.

it only really works on linux/mac; animation woes led me to just make it
static and plain on windows.
2020-05-04 15:42:41 -05:00
Corey Johnson
fef11b3489 Merged prs return error 2020-05-04 10:44:20 -07:00