Commit graph

5239 commits

Author SHA1 Message Date
Mislav Marohnić
0d999ddaa1 Rework local extensions for Windows
Replace the implementation that relied on symlinks with the one that
create regular files that act like symlinks: they contain a reference to
the local directory where to find the extension.
2021-07-28 22:47:54 +02:00
Mislav Marohnić
5a46c1cab6
Merge pull request #4043 from cli/upgrade-goreleaser
This reverts commit 85d0447.
2021-07-28 21:07:29 +02:00
Mislav Marohnić
4b499be96b
Merge pull request #3942 from dscho/complete--repo-flag
Allow auto-completing the `--repo` values
2021-07-28 17:27:56 +02:00
Mislav Marohnić
d6b70beeaa List repos from non-default hostnames in completions for -R 2021-07-28 17:18:56 +02:00
Jose Garcia
ebc8ce5adb Merge pull request #53 from github/jg/perf-improvements
Liveshare client upgrade to v0.6.0
2021-07-28 10:13:06 -04:00
Jose Garcia
cd99399290 Merge pull request #3 from github/jg/ignore-eof-terminal
Ignore EOF on terminal close
2021-07-28 09:56:07 -04:00
Jose Garcia
ae29c3c1ea Ignore EOF on terminal close 2021-07-28 13:55:33 +00:00
Jose Garcia
4fc27b3ed9 Merge pull request #2 from github/jg/connection-test
Connection test
2021-07-28 09:52:58 -04:00
Jose Garcia
3a2ade23a4 Connection test 2021-07-28 13:52:30 +00:00
Johannes Schindelin
b43f78bc19 completions: auto-complete --repo values
Looking at the locally-registered remotes, we have a pretty good idea
what `--repo` values are available. Let's complete them.

Helped by Nate Smith and Mislav Marohnić.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2021-07-28 15:36:30 +02:00
Jose Garcia
9544f8acc9 Commit vendors 2021-07-28 09:05:58 -04:00
Jose Garcia
cba40ad72a liveshare client upgrade 2021-07-28 08:33:06 -04:00
Jose Garcia
39fe550aeb Merge pull request #1 from github/jg/refactor
Refactors most of the library to solidify some of the implementation with tests
2021-07-27 19:23:37 -04:00
Jose Garcia
0ab67badfa Final changes to finish this refactor 2021-07-27 23:19:55 +00:00
Sam
ef9b781283
Merge pull request #4047 from tniessen/opensuse-typo
Fix typo in openSUSE installation instructions
2021-07-27 08:18:37 -07:00
Sam
92ed42c54a
Merge pull request #4029 from cli/extensions-upgrade-force
Add --force flag for extensions upgrade
2021-07-27 08:07:14 -07:00
Mislav Marohnić
f3a7d0076e
Merge pull request #4028 from cli/bump-cobra
Upgrade Cobra for improved shell completion support
2021-07-27 16:34:20 +02:00
Mislav Marohnić
fdad37e248
Merge pull request #4019 from cli/enterprise-env
Fix error message when using GH_ENTERPRISE_TOKEN but host is ambiguous
2021-07-27 15:29:14 +02:00
Jose Garcia
77d0bc1901 Merge pull request #43 from github/gh-token
Add note about gh extension
2021-07-27 08:03:27 -04:00
Jose Garcia
529e3bf5e3 Merge pull request #42 from github/rm-dotcom-note
Remove note about creating a custom SSH setup for dotcom
2021-07-27 08:03:17 -04:00
Ben Chadwick
c8ee9829a7 Revert "fixing mistake"
This reverts commit 5e3ca02198.
2021-07-26 21:55:47 -07:00
Tobias Nießen
515902ade3
Fix typo in openSUSE installation instructions 2021-07-27 02:13:35 +02:00
Mislav Marohnić
967ef48306 Merge pull request #41 from github/auto-version
Provide version number at build time
2021-07-26 19:25:06 +02:00
Mislav Marohnić
82c6fb7d1a Add a note about the dummy GHE hostname 2021-07-26 18:59:53 +02:00
Mislav Marohnić
3931c16bd7 Provide version number at build time 2021-07-26 17:07:42 +02:00
Issy Long
bba5ebec8b Merge pull request #39 from github/ssh-codespace-param
cmd/ghcs/ssh: Add `-c` parameter for specifying a Codespace to SSH to
2021-07-26 15:44:11 +01:00
Jose Garcia
892f73221c Update shared visibility finalized tests 2021-07-26 14:39:52 +00:00
Jose Garcia
98282ba4b5 Update shared visibility tests 2021-07-26 14:31:00 +00:00
Issy Long
c092a29350 cmd/ghcs/ssh: Add -c parameter for specifying a Codespace to SSH to
- This adds a `-c`, `--codespace` parameter to `ghcs ssh` to allow for
  non-interactively specifying a Codespace to SSH into, for instance if
  a user has recently done `ghcs list` and already knows which Codespace
  they want to access. Without a value for the `-c` parameter, the
  interactive prompt appears as usual.
2021-07-26 14:58:48 +01:00
bchadwic
5e3ca02198 fixing mistake 2021-07-26 00:37:14 -07:00
bchadwic
aac4c59c31 fixing operating system dependant regex, and tests 2021-07-26 00:22:25 -07:00
bchadwic
8469441464 new functionality: current folder './', parent folder '../', absolute 'filename' 2021-07-25 23:53:27 -07:00
Jose Garcia
91114d35c3 More tests 2021-07-24 03:44:20 +00:00
Jose Garcia
fcfb10cb56 Working test for Client.Join 2021-07-23 20:24:50 +00:00
Jose Garcia
9132a28e9c Checking point after continuing to flesh out mock server 2021-07-23 19:15:54 +00:00
Jose Garcia
b9cd9af7fa Start of tests and comments 2021-07-23 01:17:32 +00:00
CamiloGarciaLaRotta
d688dc76ec Merge pull request #36 from github/config/v0.7.1
config: bump to 0.7.1
2021-07-22 10:35:23 -04:00
CamiloGarciaLaRotta
7e49db3be3 config: bump to 0.7.1
Hoping to prove that Goreleaser & Homebrew run automatically
2021-07-22 10:33:00 -04:00
CamiloGarciaLaRotta
f35186485c Merge pull request #31 from github/feat/promptless-create
feat: introduce repo, branch and machine flags for ghcs create
2021-07-22 10:18:03 -04:00
Camilo Garcia La Rotta
14468baba6 config: bump to v0.7.0 2021-07-22 10:13:20 -04:00
CamiloGarciaLaRotta
ba37311927 Merge pull request #30 from github/feat/richer-delete
feat: delete all & delete per repo
2021-07-22 10:10:58 -04:00
CamiloGarciaLaRotta
89cf916e23 Merge branch 'main' into feat/promptless-create 2021-07-22 10:09:21 -04:00
Camilo Garcia La Rotta
3ef0226e20 fix: output available machine names on --machine error 2021-07-22 10:07:09 -04:00
CamiloGarciaLaRotta
2f467e3ddc Merge branch 'main' into feat/richer-delete 2021-07-22 09:55:20 -04:00
Issy Long
8f73b18911 Merge pull request #33 from github/improve-descriptions
cmd/ghcs/*.go: Better short descriptions of what commands do
2021-07-22 14:19:07 +01:00
Issy Long
69865fa762 cmd/ghcs/main: Better description of ghcs as a whole
Co-authored-by: Camilo Garcia La Rotta <camilogarcialarotta@github.com>
2021-07-22 14:08:20 +01:00
Issy Long
b66d65379f cmd/ghcs/*.go: Better short descriptions of what commands do
- I ran `--help` on `ghcs code` and saw `ghcs code` and that was it,
  which was surprising. I expected a description.
- Here's a fix for all of the commands thus far to give them longer
  descriptions.
- I've only done "short" descriptions in Cobra terms, and removed the
  "long" descriptions as they seemed like they needed to be
  unnecessarily verbose.

Before:

```
❯ ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        code
  create      Create
  delete      delete
  help        Help about any command
  list        list
  ports       ports
  ssh         ssh

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ghcs ssh --help
ssh

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```

After:

```
❯ ./ghcs --help
Codespaces

Usage:
  ghcs [command]

Available Commands:
  code        Open a GitHub Codespace in VSCode.
  create      Create a GitHub Codespace.
  delete      Delete a GitHub Codespace.
  help        Help about any command
  list        List GitHub Codespaces you have on your account.
  ports       Forward ports from a GitHub Codespace.
  ssh         SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Flags:
  -h, --help      help for ghcs
  -v, --version   version for ghcs

Use "ghcs [command] --help" for more information about a command.

❯ ./ghcs ssh --help
SSH into a GitHub Codespace, for use with running tests/editing in vim, etc.

Usage:
  ghcs ssh [flags]

Flags:
  -h, --help              help for ssh
      --profile string    SSH Profile
      --server-port int   SSH Server Port
```
2021-07-22 11:07:23 +01:00
Jose Garcia
a99d0f5495 Better naming for rpc client and ssh session 2021-07-22 01:07:06 +00:00
Jose Garcia
fddcd876b0 Some more cleanup to the port forwarder and connection 2021-07-22 01:02:03 +00:00
Camilo Garcia La Rotta
a68cda1469 refactor: break down Create() into smaller funcs 2021-07-21 20:54:18 -04:00