Commit graph

8622 commits

Author SHA1 Message Date
Meredith Lancaster
f46cccbab4 comment
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 12:03:49 -07:00
Meredith Lancaster
258c69cd26 undo more name chanages
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:56:05 -07:00
Meredith Lancaster
0a602fae07 undo other name change
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:54:02 -07:00
Meredith Lancaster
37e0969f20 remove spaces
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:51:51 -07:00
Meredith Lancaster
3c0280c4d7 undo name change for now
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:51:23 -07:00
Meredith Lancaster
7838e912b6 more mock http client cleanup
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:37:02 -07:00
Meredith Lancaster
9d88ca8cf8 simplify mock http client
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 11:32:49 -07:00
Meredith Lancaster
ecf55c6c16 use mock to assert number of http calls
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 10:54:17 -07:00
Meredith Lancaster
e34e188ee2 add http client test constructors
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 10:43:24 -07:00
Meredith Lancaster
9ecd90c26c setup testing struct for test cases
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-07 10:24:42 -07:00
Meredith Lancaster
69865117ab add mutex for test field
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 13:14:02 -07:00
Meredith Lancaster
fb4fc7e7c2 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:58:13 -07:00
Meredith Lancaster
0202ca8df5 add test case for bundle url fetch failure
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 12:58:09 -07:00
Meredith Lancaster
b1af4b0ce3
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 12:49:27 -07:00
Andy Feller
b3be16e98e
Merge pull request #10190 from cli/andyfeller/go-gh-2.11.2-security-bump
Bump cli/go-gh for indirect security vulnerability
2025-01-06 14:38:49 -05:00
Andy Feller
757966ca7c Bump cli/go-gh for indirect security vulnerability 2025-01-06 14:27:03 -05:00
Meredith Lancaster
e03a36ea3c add tests for bundle url fetch and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 12:12:26 -07:00
Tyler McGoffin
1f4e005562
Merge pull request #10158 from aryanbhosale/trunk
fix(repo fork): add non-TTY output when fork is newly created
2025-01-06 10:11:14 -08:00
Meredith Lancaster
070b67e5a4 fetch bundles in parallel
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:44:55 -07:00
Meredith Lancaster
311f2b2e23 return fetch attestations err directly
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:39:40 -07:00
Tyler McGoffin
2358fcee83
Merge pull request #10177 from cli/cmbrose/pr-create-upstream-fix
Handle missing upstream configs for `gh pr create`
2025-01-06 09:32:00 -08:00
Meredith Lancaster
fc984c91d0 Merge branch 'fetch-artifact-attestation-bundles-with-sas-url' of github.com:malancas/cli into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 10:21:37 -07:00
Meredith Lancaster
9051da39fc provide additional logging and fallback
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-01-06 10:19:47 -07:00
Meredith Lancaster
706314b005
Merge branch 'trunk' into fetch-artifact-attestation-bundles-with-sas-url 2025-01-06 09:57:57 -07:00
William Martin
c3b41e87b8 Panic mustParseTrackingRef if format is incorrect 2025-01-06 10:33:28 -06:00
William Martin
8b5073d617 Move trackingRef into pr create package 2025-01-06 10:33:28 -06:00
William Martin
62ecb1c84d Make tryDetermineTrackingRef tests more respective of reality
Though it doesn't really matter, in practice upstream is always going to come before origin.
2025-01-06 10:33:28 -06:00
William Martin
57ba5e5608 Rework tryDetermineTrackingRef tests 2025-01-06 10:33:28 -06:00
William Martin
b8c167970b Avoid pointer return from determineTrackingBranch 2025-01-06 10:33:28 -06:00
William Martin
27bd4b2aec Doc determineTrackingBranch 2025-01-06 10:33:28 -06:00
William Martin
05764b8114 Don't use pointer for determineTrackingBranch branchConfig 2025-01-06 10:33:28 -06:00
William Martin
dc077dc09b Panic if tracking ref can't be reconstructed 2025-01-06 10:33:28 -06:00
William Martin
3ae4e5da20 Document and rework pr create tracking branch lookup 2025-01-06 10:33:28 -06:00
Kynan Ware
106d5d1144
Merge pull request #10181 from jsoref/issue-10084
Upgrade generated workflows
2025-01-06 09:08:33 -07:00
Josh Soref
dd32a9cc94 Upgrade generated workflows
Use `cli/gh-extension-precompile@v2`

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2025-01-05 23:18:28 -05:00
Aryan Bhosale
3fe6ba4e8e
Merge branch 'trunk' into trunk 2025-01-04 10:24:07 +05:30
Aryan Bhosale
c7d444d65b
Merge pull request #1 from cli/jtmcg/fix-tests-10158
Fixed test for stdout in non-tty use case of repo fork
2025-01-04 10:22:32 +05:30
Tyler McGoffin
2ec473ff2f
Merge pull request #10139 from ChandranshuRao14/feat/repo-edit-security-analysis
Feat: Allow setting security_and_analysis settings in gh repo edit
2025-01-03 16:22:10 -08:00
Tyler McGoffin
efec5d9250 Fixed test for stdout in non-tty use case of repo fork 2025-01-03 15:54:07 -08:00
Caleb Brose
67749480d5
Fix test 2025-01-03 20:45:20 +00:00
Caleb Brose
9d490547b8
Alternative: remove LocalBranch from BranchConfig 2025-01-03 20:39:12 +00:00
Caleb Brose
7a1052ca33
Set LocalBranch even if the git config fails 2025-01-03 20:35:48 +00:00
Tyler McGoffin
576fa8a3bc
Add test for permissions check for security and analysis edits (#1) 2025-01-03 01:29:45 -05:00
Aryan Bhosale
8dbbceaaaf
print repo url to stdout 2025-01-03 10:54:30 +05:30
Tyler McGoffin
d6dba93586
Merge pull request #10164 from cli/jtmcg/update-auth-PAT-info
Add mention of classic token in gh auth login docs
2025-01-02 15:29:23 -08:00
Tyler McGoffin
2306623cad
Merge pull request #10124 from hoffm/autolink-references
feat: Add support for listing autolink references
2025-01-02 14:29:48 -08:00
Tyler McGoffin
aa793f1dac
Update pkg/cmd/auth/login/login.go
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-01-02 14:22:20 -08:00
Tyler McGoffin
ae9e68b803 Move mention of classic token to correct line 2025-01-02 10:41:25 -08:00
Michael Hoffman
a5cf3751cd Separate type decrarations 2025-01-02 13:14:23 -05:00
Michael Hoffman
8f00cd40af
Merge branch 'cli:trunk' into autolink-references 2025-01-02 13:11:48 -05:00