Commit graph

2824 commits

Author SHA1 Message Date
vilmibm
f68909b7a8 use TempFile though the testing is gross 2020-11-23 11:21:28 -08:00
vilmibm
fffd315a7e fix dumb test 2020-11-23 11:21:28 -08:00
vilmibm
d300526318 preserve and restore issue/pr input on failure 2020-11-23 11:21:28 -08:00
vilmibm
e92cd43259 add IOStreams.ReadUserFile 2020-11-23 11:21:28 -08:00
Mislav Marohnić
d6c9004d64
Merge pull request #2460 from cli/spell-check-fixes
Spell check fixes
2020-11-23 13:22:01 +01:00
Josh Soref
a66a65d422 spelling: unmatched 2020-11-21 21:43:51 -05:00
Josh Soref
ded92972cd spelling: template 2020-11-21 21:43:51 -05:00
Josh Soref
ec82d3c47e spelling: settings 2020-11-21 21:43:51 -05:00
Josh Soref
e5f59a15fe spelling: response 2020-11-21 21:43:51 -05:00
Josh Soref
c8b9486fd3 spelling: nonexistent 2020-11-21 21:43:51 -05:00
Josh Soref
76bd377253 spelling: error 2020-11-21 21:43:51 -05:00
Josh Soref
861d350440 spelling: dunno 2020-11-21 21:43:51 -05:00
Josh Soref
ddd438d5e1 spelling: dismissed 2020-11-21 21:43:51 -05:00
Josh Soref
8ba68fc68a spelling: deprecated 2020-11-21 21:43:51 -05:00
Josh Soref
e58b2dbe92 spelling: chestnuts 2020-11-21 21:43:51 -05:00
Josh Soref
0e681ca6c4 spelling: beginning 2020-11-21 21:43:46 -05:00
Nate Smith
05a1a25271
match parent repo protocol when forking (#2434)
* match parent repo protocol when forking

* guard against nil and prefer PushURL
2020-11-20 12:00:49 -06:00
Nate Smith
c7eb57d443
respect GH_HOST when resolving remotes (#2301)
* vim to gitignore

* respect GH_HOST in Resolver

* slight restructure, add a test

* grammar fix
2020-11-19 12:59:18 -06:00
Nikola Ristić
e87b5bcaff
Add "reference" help topic (#2223)
* Add "reference" help topic

* Only print reference as a help topic

* fix for color fns, slightly generalize

* WIP for switching to markdown

* escape gt/lt

* minor

* higher wrap point

* detect terminal theme

* futz with angle brackets once more

* minor cleanup

* prepend parent commands

* rename help topic fns and add test

* Simplify reference help generation

- the `<...>` characters from command usage line are now preserved by enclosing the entire usage synopsis in a code span
- hard breaks in flag usage lines are preserved by enclosing flag usage in a code block
- TTY detection and Markdown rendering are now delayed until the user explicitly requests `gh help reference`
- `gh help reference` output is now pager-enabled

Co-authored-by: vilmibm <vilmibm@github.com>
Co-authored-by: vilmibm <vilmibm@neongrid.space>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2020-11-18 12:31:36 -06:00
Sam
ee4827483d
Merge pull request #2421 from cli/downgrade-survey
Downgrade survey to v2.1.1
2020-11-18 09:26:37 +03:00
Jakub Warczarek
b205faa941
Implement --web for gh pr checks (#2146) 2020-11-17 12:27:07 -06:00
Sam Coe
7f57c1c3f2
Downgrade survey to v2.1.1 2020-11-17 11:25:07 +03:00
vilmibm
00617216b8 fix missing import 2020-11-16 14:03:52 -08:00
Christopher Oswald
0bb44c9ced
Support for --web when using gist create (#2263)
* Support for --web when using gist create

Proposal to close #2071

I have not worked with Go prior to this so please smite me down with the
wisdom of a million Golang gods if I'm doing something terribly wrong.

I also added a test to gist/create for the added web arg.

Pretty much referenced the implementation from pr/create.

* Fix for Tests / build (windows-latest)

I believe this fixes it as it stopped failing on a local vm. Otherwise I
will try and tackle it tomorrow.

* minor cleanup

Co-authored-by: vilmibm <vilmibm@github.com>
2020-11-16 16:01:30 -06:00
Alex Johnson
99574f85a3
Add a command to delete a gist (#2265)
* Add a command to delete a gist

* minor cleanup

Co-authored-by: vilmibm <vilmibm@github.com>
2020-11-16 15:47:55 -06:00
Sam
116d5815b5
Merge pull request #2388 from cli/gh-token
Add support for GH_TOKEN and GH_ENTERPRISE_TOKEN
2020-11-16 08:27:50 +03:00
vilmibm
ef52376fe0 fix survey invocation 2020-11-13 10:35:32 -08:00
Nate Smith
9a20719ec4
Merge pull request #2386 from cli/create-refactor
Refactor pr/issue creation code
2020-11-13 11:37:15 -06:00
Mislav Marohnić
fed4df2afa
Merge pull request #2405 from cristiand391/fix-usage-help
Minor fix in USAGE help info for some commands
2020-11-13 16:13:51 +01:00
Cristian Dominguez
867f38970f Fix USAGE help for some commands 2020-11-13 10:10:53 -03:00
Mislav Marohnić
6a0d38df44
Merge pull request #2404 from alissonbrunosa/fix-repo-view-command-with-branch
Generate correct URL when branch option is passed in
2020-11-13 13:05:56 +01:00
Alisson Santos
62e560d6ee add empty line between functions 2020-11-13 10:24:17 +01:00
Alisson Santos
9ecc902959 Generate correct URL when branch option is passed in 2020-11-13 10:20:30 +01:00
vilmibm
a686455fb6 add Draft to issue state 2020-11-12 12:17:37 -08:00
vilmibm
b231e6c2cf use NewIssueState 2020-11-12 12:15:48 -08:00
vilmibm
f5277e452e get everything working 2020-11-12 12:03:32 -08:00
vilmibm
0ed7879329 stop using Defaults struct 2020-11-12 12:03:20 -08:00
vilmibm
1c280d4341 stop using string pointer 2020-11-12 12:03:20 -08:00
vilmibm
6671106448 WIP works, probably some title/body input edge cases 2020-11-12 12:03:20 -08:00
vilmibm
6fde02df1c use named output param 2020-11-12 12:02:17 -08:00
Mislav Marohnić
c87deab14a
Merge pull request #2397 from ganboonhong/fix-typos
Fix typos
2020-11-12 15:47:26 +01:00
boonhong
57ec879aea Fix typos 2020-11-12 22:32:36 +08:00
Sam Coe
2eb40f8a14
Empty auth token env variables are equal to being unset 2020-11-12 10:09:08 +03:00
Sam Coe
414de332fb
cleanup 2020-11-12 09:52:14 +03:00
Sam Coe
a79a0bbfd7
Add support for GH_TOKEN and GH_ENTERPRISE_TOKEN 2020-11-12 09:52:10 +03:00
Mislav Marohnić
6e1e62f496 Consistently print commands in DEBUG mode 2020-11-11 18:17:01 +01:00
Mislav Marohnić
97b176da93 Fix git executable name for Windows in tests 2020-11-11 16:46:49 +01:00
Mislav Marohnić
fc3f517419
Merge pull request from GHSA-fqfh-778m-2v32
Ensure that only PATH is searched when shelling out to external commands
2020-11-11 16:36:50 +01:00
Mislav Marohnić
38f68d849f Improve error message when git isn't found 2020-11-11 16:33:13 +01:00
Mislav Marohnić
c87dc00f38 Omit the full path of a command in DEBUG mode 2020-11-11 16:33:13 +01:00