Commit graph

288 commits

Author SHA1 Message Date
Meredith Lancaster
ac79032936 simplify build step
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-12 12:29:21 -06:00
Meredith Lancaster
fbb27df846 use platform matrix for integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-12 12:25:02 -06:00
Meredith Lancaster
8f412af64d move integration tests to prexisting test workflow
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-12 12:20:24 -06:00
Meredith Lancaster
b64e0030b5 run integration tests on ubuntu for now
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-06 14:05:15 -07:00
Meredith Lancaster
e171f97b73 remove integration test steps
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-06 13:59:34 -07:00
Meredith Lancaster
b9739140b4 split integration tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-06 13:53:35 -07:00
Meredith Lancaster
617a9f34eb build executable before integration test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-06 13:41:59 -07:00
Meredith Lancaster
e756694eda fix file path
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-06 13:25:56 -07:00
Meredith Lancaster
956e10af0e add integration test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-06 13:20:23 -07:00
Meredith Lancaster
31a00b4f70 fix path in codeowners
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-04 15:38:16 -07:00
Meredith Lancaster
24865a6202 add package security team entry to codeowners
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-03-01 13:44:37 -07:00
dependabot[bot]
2bbafc1a09
build(deps): bump microsoft/setup-msbuild from 1.3.2 to 2.0.0
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.3.2 to 2.0.0.
- [Release notes](https://github.com/microsoft/setup-msbuild/releases)
- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)
- [Commits](https://github.com/microsoft/setup-msbuild/compare/v1.3.2...v2.0.0)

---
updated-dependencies:
- dependency-name: microsoft/setup-msbuild
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-01-31 14:37:37 +00:00
dependabot[bot]
8378e83e45
build(deps): bump microsoft/setup-msbuild from 1.3.1 to 1.3.2
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/microsoft/setup-msbuild/releases)
- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)
- [Commits](https://github.com/microsoft/setup-msbuild/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: microsoft/setup-msbuild
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-01-26 14:05:45 +00:00
dependabot[bot]
32ab65fd77
build(deps): bump actions/cache from 3 to 4 (#8594)
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-18 07:37:49 -08:00
dependabot[bot]
8cfe7572de
build(deps): bump actions/download-artifact from 3 to 4 (#8466)
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-17 10:04:40 -08:00
dependabot[bot]
44cac16be1
build(deps): bump actions/upload-artifact from 3 to 4 (#8467)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-01-17 10:02:54 -08:00
Andy Feller
48f5a15e0d
Update deployment.yml
Removed previous deployment step env vars
2024-01-08 08:48:55 -05:00
Andy Feller
541ce0e5b4
Merge pull request #8465 from cli/andyfeller/213-windows-hsm-signing
Update deployment workflow for final HSM solution
2023-12-15 11:52:35 -05:00
Andy Feller
5ecdf166fb Update deployment workflow for final HSM solution
This applies the changes from the separate Windows HSM signing prototype development to the official deployment workflow including:

1. Use of Azure Code Signing client
2. Sourcing signtool.exe from runner
3. Moving from batch to PowerShell for Windows signing script
4. Using the same signing process for .exe and .msi
2023-12-14 13:15:38 -05:00
dependabot[bot]
1df8e833c7
build(deps): bump github/codeql-action from 2 to 3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-14 14:24:28 +00:00
Andy Feller
29f409666e
Merge pull request #8457 from cli/andyfeller/213-windows-hsm-signing-testing
Enhance HSM deployment prototype to use the same signing process for .exe and .msi
2023-12-14 07:10:13 -05:00
Andy Feller
e01809c075 Unify Windows sign process on signtool
- converts the process from using script/sign.bat to script/sign.ps1 for supportability and capability
- resolves signtool on runner in order to run rather than hardcoded path
2023-12-13 10:19:36 -05:00
Andy Feller
f0f09bda57
Merge pull request #8421 from cli/andyfeller/213-windows-hsm-signing-testing
Create HSM testing workflow
2023-12-12 10:19:51 -05:00
Andy Feller
35f99ee426 Final fixes 2023-12-12 10:09:47 -05:00
Andy Feller
783dbf999a Remove fugue artifact 2023-12-12 09:56:35 -05:00
Andy Feller
bcbd848bfe Remove unnecessary copying, fix secrets part deux 2023-12-12 09:54:55 -05:00
Andy Feller
1fff21a63e Fixes based on actual secret names and signtool insights 2023-12-12 09:48:16 -05:00
Andy Feller
4054968fc3 Fix Dlib DLL path
Mixed up Unix and Windows path separators
2023-12-08 17:30:28 -05:00
Andy Feller
0af95d9314 Remove previous hsm test workflow 2023-12-08 17:29:19 -05:00
Andy Feller
5e8e645a7f Update HSM test using Desktop approach
This update leverages GitHub Desktop approach of downloading Azure Code Signing DLL and wiring it up as part of the existing signing process used by Windows builds.
2023-12-08 17:27:22 -05:00
dependabot[bot]
5d780dabf1
build(deps): bump actions/setup-go from 4 to 5
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](https://github.com/actions/setup-go/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-07 14:29:50 +00:00
Andy Feller
dea2cd5fe1 Create HSM testing workflow
This commit is an initial prototype based on the deployment workflow, using the
Azure Code Signing service to sign Windows .exe and .msi files.

These changes have been isolated as much as possible to not affect existing
deployment workflows while also working around design issues with how GitHub
CLI workflow works with GoReleaser and now with ACS support.  The biggest smell
was over whether to break from using GoReleaser or have GoReleaser control as
much about the release process as it has been versus opening / signing /
archiving the resulting GoReleaser artifacts; needless to say, the latter was
chosen for expedience as well as leaning into officially supported solutions.
2023-12-05 15:24:50 -05:00
Andy Feller
8302a293d0 Fix triage workflow, restore PR support
This commit reverts the triage workflow to restore the previous PR support using the `pull_request_target`, which is more secure as it doesn't allow fork repositories to change the workflow before it runs.

Additionally, this fixes an issue currently causing the workflow to break as cli/cli uses the `discuss` label but github/cli uses the `triage` label.
2023-12-05 08:46:45 -05:00
Andy Feller
bdfdc42624 Revert "Update triage.yml"
This reverts commit 3be9a0ed85.
2023-12-05 08:33:00 -05:00
Andy Feller
3be9a0ed85
Update triage.yml 2023-12-04 13:54:16 -05:00
Andy Feller
109766fe14 Correcting label and language
- replacing triage for discuss
2023-11-30 23:09:46 -05:00
Andy Feller
a7753a9809 Refactor triage workflow
- replaces creating discussions for issues
- supports discussing both issues and pull requests
- populates more information about related issues and pull requests in triage issues
2023-11-30 23:00:30 -05:00
William Martin
ede1705bf2 Ensure good link in triage discussion 2023-10-31 10:02:42 +01:00
William Martin
b2c445f4b9 Ensure variables get passed in discussion triage 2023-10-31 09:58:30 +01:00
William Martin
6782120254 Update discussion triage types to ID 2023-10-31 09:55:29 +01:00
William Martin
4213e3e2b4 Update secret name to not be prefixed with GITHUB
Apparently this isn't allowed
2023-10-31 09:49:46 +01:00
William Martin
09b81ff545
Create private discussion for issues labelled discuss (#8264) 2023-10-31 09:44:31 +01:00
David Gardiner
64f4660ec7
Migrate all Codespaces operations from Live Share to Dev Tunnels (#8149)
* Migrate all Codespaces operations from Live Share to Dev Tunnels

* Remove Live Share references

* Fix linting errors

* Update comments, remove deps, add uint16 bound checks

* Fix tests and move keep-alive logic to forwarder

* Address comments

* Updated mock port forwarder

* Fix CodeQL error

* Update comment

* Update func name

* Add missing connection close

* Fix linting error

* https -> http

* Update defer

* Fix tests
2023-10-12 22:16:36 +00:00
Andy Feller
80e46cabeb
Update deployment.yml
Update release job to use repository environment needed for homebrew secret
2023-10-03 11:28:58 -04:00
Andy Feller
aefecbab65
Update homebrew-bump.yml
Adding missing input needed for testing
2023-10-03 10:54:44 -04:00
William Martin
49ec484211
Add homebrew-bump-debug workflow (#8114) 2023-10-03 16:45:44 +02:00
dependabot[bot]
9683b91363
build(deps): bump mislav/bump-homebrew-formula-action from 2 to 3
Bumps [mislav/bump-homebrew-formula-action](https://github.com/mislav/bump-homebrew-formula-action) from 2 to 3.
- [Release notes](https://github.com/mislav/bump-homebrew-formula-action/releases)
- [Commits](https://github.com/mislav/bump-homebrew-formula-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: mislav/bump-homebrew-formula-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-21 14:07:16 +00:00
dependabot[bot]
fe40c2652e
build(deps): bump goreleaser/goreleaser-action from 4 to 5
Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4 to 5.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](https://github.com/goreleaser/goreleaser-action/compare/v4...v5)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-12 14:24:27 +00:00
William Martin
27493ca2f8
Reinforce not opening PRs without approval on an issue 2023-09-11 15:18:20 +02:00
William Martin
1d0d51834d Move homebrew bump fork to personal repo 2023-09-06 15:23:24 +02:00