Babak K. Shandiz
3e946a356c
test(pr merge): always assert stderr
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-05 15:02:41 +01:00
Babak K. Shandiz
b1e1c8d500
test(pr merge): verify deleteRemoteBranch behaviour when API returns error
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-05 14:54:33 +01:00
Babak K. Shandiz
bafefb345e
fix(pr merge): ignore 404 as error when deleting remote branch
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-05 14:54:28 +01:00
Babak K. Shandiz
8ab5e84a12
test: add test for ParseURL
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-03 10:21:55 +01:00
Babak K. Shandiz
b7fa5ea7a9
docs: explain PR URL parsing reason
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:41:07 +01:00
Babak K. Shandiz
58ed691a6c
test: remove references to AssignedActorsUsed field
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:19:13 +01:00
Babak K. Shandiz
2c86246a1a
test: verify providing a URL arg affects the base repo
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:18:38 +01:00
Babak K. Shandiz
b85dc94f84
refactor: select PR fields based on detected features
...
This change is almost a revert to what had already done in #10984 .
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:14:50 +01:00
Babak K. Shandiz
f65683784e
test: remove tests verifying assigne-related behaviour
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:12:58 +01:00
Babak K. Shandiz
12f4794151
fix: remove assignee-related intervention
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 11:12:16 +01:00
Babak K. Shandiz
23c9ff6d89
fix: expose ParseURL as a public func
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-07-01 10:49:18 +01:00
Daniel Krzeminski
b31f38c946
Fix: gh pr create prioritize --title and --body over --fill when --web is present ( #10547 )
...
* fix: prioritize title and body over autofill for prs
* fix: prioritize title and body over autofill tests
* refactor: collapse state conditions
---------
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-24 12:54:43 +00:00
jinjingroad
28d5de9d8e
chore: fix function name
...
Signed-off-by: jinjingroad <jinjingroad@sina.com>
2025-06-19 12:36:52 +08:00
William Martin
8baf5cc3e4
Merge pull request #11065 from cli/andyfeller/gh-pr-edit-assignees
...
Fix assignees being dropped from `gh pr edit`
2025-06-11 15:44:42 +02:00
Babak K. Shandiz
bde303dab2
test: fix test data const
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-06-10 13:57:31 +01:00
Kynan Ware
ed4b90104f
test(pr): Add tests for actor assignees
2025-06-03 14:30:19 +01:00
Andy Feller
a24d39ac87
Fix test, remove partial standalone test
2025-06-03 13:48:01 +01:00
Andy Feller
cde860be88
Iterate on pr edit problems with existing assignees
...
This commit is a handful of changes around `gh pr edit --add-assignee` behavior. Most notably, fixing a bug where the assigned actors weren't being dropped.
In addition to this, I was refactoring the testing setup to allow for individual test table scenarios could be contained.
2025-06-03 13:33:52 +01:00
William Martin
c13f2f1232
Merge pull request #11057 from cli/wm/fix-pr-edit
...
Fix pr edit when URL is provided
2025-06-02 17:44:30 +02:00
Tim Rogers
9a8031151c
Document support for @copilot in gh [pr|issue] edit --add-assignee and --remove-assignee ( #11056 )
...
* Document support for `@copilot` in `gh [pr|issue] edit --add-assignee` and `--remove-assignee`
Following up on #10991 , this updates the help text for
`issue edit` and `pr edit`'s `--add-assignee` and
`--remove-assignee` options to mention that you can use
`@copilot`.
This is already mentioned in the command-level help text, but
not at the argument level, whereas the `@me` macro is.
* Apply suggestion from @babakks
Co-authored-by: Babak K. Shandiz <babakks@github.com>
* Apply suggestion from @babakks
Co-authored-by: Babak K. Shandiz <babakks@github.com>
---------
Co-authored-by: Babak K. Shandiz <babakks@github.com>
2025-06-02 16:29:35 +01:00
William Martin
793a7ff459
Fix pr edit when URL is provided
2025-06-02 15:07:55 +02:00
Babak K. Shandiz
d1b82d19f9
Merge pull request #10980 from cli/babakks/improve-pr-create-docs
...
Mention `pr create` will print the created PR's URL
2025-05-28 16:43:04 +01:00
Babak K. Shandiz
c927ea40c3
Merge pull request #10979 from cli/babakks/improve-pr-list-docs
...
Add example usage of `--head` option to `pr list` docs
2025-05-28 14:38:17 +01:00
Babak K. Shandiz
aa64bb5708
docs(pr list): mention --head does not support <owner>:<branch> syntax
...
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-28 12:55:11 +01:00
Kynan Ware
53d0d5d192
fix(editable): include DefaultLogins in EditableAssignees clone
2025-05-16 12:54:01 -06:00
Kynan Ware
6f1906073f
doc(params): incorrect func name in comment
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-05-16 12:51:09 -06:00
Kynan Ware
d932934119
Merge branch 'trunk' into kw/gh-cli-epic-900-actors-are-assignable
2025-05-16 12:49:52 -06:00
Kynan Ware
a28e2d8784
refactor(api): use constant for Copilot login
2025-05-16 12:28:46 -06:00
Kynan Ware
3a8cdda148
Merge pull request #10991 from cli/kw/gh-cli-917-special-actor-assignee-names-noninteractive
...
`issue edit`, `pr edit`: Support special non-interactive (flags) assignee name `@copilot`
2025-05-16 12:19:43 -06:00
Kynan Ware
748afb6e85
doc(issue/pr edit): clarify @copilot usage
2025-05-16 12:18:23 -06:00
Kynan Ware
475163a126
Merge pull request #10990 from cli/kw/gh-cli-916-special-actor-assignee-names
...
`issue edit`, `pr edit`: handle display names in interactive assignee editing
2025-05-16 10:16:08 -06:00
Kynan Ware
532aa1c32a
doc(issue/pr edit): doc @copilot assignee
2025-05-16 09:55:17 -06:00
Kynan Ware
debf0bbaf2
test(params): enhance Copilot replacer tests for edge cases
...
- Added tests for handling nil and empty slices in the Copilot replacer.
- Simplified test structure by removing unnecessary wantErr field.
2025-05-16 09:50:24 -06:00
Kynan Ware
871671be52
fix(params): remove needless err return
2025-05-16 09:40:29 -06:00
Kynan Ware
c5f2d7bde7
doc(editable): remove needless comment
2025-05-16 09:37:20 -06:00
Kynan Ware
ec7c8ed844
test(pr edit): fix typo in test name
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 13:41:38 -06:00
Kynan Ware
f6bb1ca756
refactor(pr edit): move httpclient initialization
2025-05-15 13:40:23 -06:00
Kynan Ware
375c6cd28f
feat(issue/pr edit): support @copilot in assignee flags
...
- Introduced CopilotReplacer to handle `@copilot` mentions in assignee lists.
2025-05-15 12:50:03 -06:00
Kynan Ware
51b1e6cd6f
Merge branch 'kw/gh-cli-909-911-assign-actors-to-prs' into kw/gh-cli-916-special-actor-assignee-names
2025-05-15 11:27:14 -06:00
Kynan Ware
52b6ebff9c
doc(pr edit): Add comments describing the use of DefaultLogins
2025-05-15 10:52:31 -06:00
Kynan Ware
9a5ea87d75
fix(issues): fix non-interactive assignee matching to logins&IDs
2025-05-15 09:56:35 -06:00
Kynan Ware
54f48cfe46
fix(pr edit): remove merge conflict artifact, extra detector
2025-05-15 09:48:44 -06:00
Kynan Ware
a03c9cec7b
Merge branch 'kw/gh-cli-epic-900-actors-are-assignable' into kw/gh-cli-909-911-assign-actors-to-prs
2025-05-15 09:42:39 -06:00
Kynan Ware
d72018d312
feat(pr edit): fetch assignable actors
2025-05-15 09:33:36 -06:00
Kynan Ware
f559068106
feat(pr edit): fetch assigned actors
2025-05-15 09:33:36 -06:00
Kynan Ware
6162a7c524
fix(api): correct var name capitalization
2025-05-15 09:33:36 -06:00
Kynan Ware
999ffbdfe7
Merge pull request #10960 from cli/kw/gh-cli-901-910-assign-actors-to-issues
...
`gh issue edit`: actors are assignable to issues
2025-05-15 09:24:32 -06:00
Kynan Ware
bcd47f1fb1
fix(api): correct var name capitalization
2025-05-15 09:13:46 -06:00
Kynan Ware
eace1e889a
feat(editable): update assigned actors to use display names
...
- Refactored AssignedActors to return display names instead of logins.
- Updated related functions to ensure consistency in display names.
- Enhanced comments for clarity on display name logic and actor types.
2025-05-14 20:26:53 -06:00
Kynan Ware
d4832ba015
feat(pr edit): fetch assignable actors
2025-05-14 11:52:02 -06:00