Commit graph

2061 commits

Author SHA1 Message Date
Francisco Miamoto
f9b50acc42 add mock for milestones on issue list 2020-08-01 23:45:21 -03:00
Francisco Miamoto
9a5e69a8a4 use graphql for repo milestones on issue list
Since we can obtain the necessary ID for the query on
node ID from the GraphQL API, it makes sense to remove
the REST version.
2020-08-01 23:43:36 -03:00
Francisco Miamoto
75e8cb8f9c register mocks for the new request 2020-07-30 22:15:15 -03:00
Francisco Miamoto
3ce1de62a2 fix searching issues by the milestone name
This fix involves using the REST API since the GraphQL one doesn't
seem to return the necessary ID for the subsequent issues query.
2020-07-30 22:11:19 -03:00
Mislav Marohnić
88eaa28aef
Merge pull request #1448 from cli/api-graphql-operationName
Support GraphQL `operationName` in `gh api` command
2020-07-29 21:09:08 +02:00
Mislav Marohnić
d26cd64745 Support GraphQL operationName in gh api command
GraphQL supports supplying multiple queries in the `query` parameter,
but an additional `operationName` parameter is then required to select
the query to execute.

Previously, it was impossible to pass `operationName` since it would get
serialized under `variables`, but it needs to be a top-level parameter.
With this change, `operationName` is a special GraphQL parameter name
just like `query` already is.
2020-07-29 16:47:33 +02:00
Nate Smith
43318fd8e8
Merge pull request #1436 from cli/move-ask-stubber
move survey helper and test helpers to prompt pkg
2020-07-28 11:49:19 -05:00
Nate Smith
f486cc4823
Merge pull request #1435 from cli/repo-cleanup
final isolation repo cleanup
2020-07-28 10:54:09 -05:00
Mislav Marohnić
58bd549de5
Merge pull request #1411 from jessemillar/feature/glamour-style
Enabling custom color themes with the `GLAMOUR_STYLE` environment variable
2020-07-28 15:29:13 +02:00
Mislav Marohnić
07eb1e7592 Document GLAMOUR_STYLE support 2020-07-28 15:24:41 +02:00
Jesse Millar
90f04d4864 Enable custom color themes with the GLAMOUR_STYLE environment variable 2020-07-28 15:23:48 +02:00
Kumar Saurabh
78124a9716
API improvement : Drain response Body inside func HasScopes (#1428)
Ensure the response body is fully read and closed to reuse the same TCPconnection.

Co-authored-by: Kumar Saurabh <kumarsaurabh@Kumars-MacBook-Air.local>
2020-07-28 14:56:17 +02:00
vilmibm
245c3c7425 move survey helper and test helpers to prompt pkg 2020-07-27 17:00:09 -05:00
vilmibm
29f4453e07 final repo command cleanup 2020-07-27 14:09:07 -05:00
vilmibm
9359dcaf80 isolate credits 2020-07-27 13:56:15 -05:00
Nate Smith
bccc93a491
Merge pull request #1423 from cli/migrate-repo-fork
isolate repo fork command and tweak usage
2020-07-27 13:13:04 -05:00
vilmibm
75cce0aaee clarify usage 2020-07-27 13:06:25 -05:00
vilmibm
a6ac615f66 remove vestigial struct field 2020-07-27 13:04:31 -05:00
vilmibm
10422e87eb just use simple bool flags
the original complexities here were because I thought there was a
shortcoming in cobra's bool support and I was wrong.
2020-07-27 13:04:31 -05:00
vilmibm
f3eb092d7e isolate repo fork command and tweak usage
This commit is another isolation refactor, this time for repo fork.
However, I got fed up with the --remote="true|false|prompt" style of
flags and took this opportunity to switch to a set of bool flags:

--remote and --clone
--no-remote and --no-clone

the string args were really non standard and confusing; with only two
bools it was impossible to tell when to prompt.
2020-07-27 13:04:31 -05:00
Nate Smith
9035418ca6
Merge pull request #1432 from szczot3k/patch-1
README.MD: Fix Arch's install example
2020-07-27 10:30:22 -05:00
Nate Smith
d84c202a6d
Merge pull request #1421 from cli/migrate-repo-create
isolate repo create command
2020-07-27 10:29:08 -05:00
vilmibm
a6c7a88e39 use dummy io streams for cobra 2020-07-27 10:14:02 -05:00
vilmibm
f84365ce08 use heredocs 2020-07-27 10:02:18 -05:00
vilmibm
dadcf4ba96 add prompt.StubConfirm 2020-07-27 10:00:19 -05:00
Filip Kszczot
ad4b3795dc
Fix Arch's install example
As the package was moved from AUR to community repo the command needs update as well.
2020-07-27 12:29:05 +02:00
vilmibm
4c57566cdc sigh 2020-07-24 15:40:59 -05:00
vilmibm
2dc8cad7c5 remove stray debugs 2020-07-24 15:26:25 -05:00
vilmibm
551c3661cb linter appeasement 2020-07-24 12:29:06 -05:00
vilmibm
c34054bdc8 isolate repo create command 2020-07-24 12:26:27 -05:00
Nate Smith
75120344c3
Merge pull request #1416 from vilmibm/migrate-repo-clone
isolate repo clone
2020-07-24 11:08:14 -05:00
vilmibm
cc862d03e7 remove dead code 2020-07-23 16:43:16 -05:00
vilmibm
1831d95433 isolated clone command
This commit hacks the existing repo clone tests into something usable by
the new isolated command. It went ok and was less effort than trying to
introduce the same kind of test format as repo view and gist create.
2020-07-23 16:40:31 -05:00
vilmibm
b9ce1a1daf pass resolving baserepo into newcmdview 2020-07-23 15:13:23 -05:00
vilmibm
d92c80b560 just swap BaseRepo implementation 2020-07-23 11:58:22 -05:00
vilmibm
086fb48d31 move displayURL 2020-07-23 11:25:31 -05:00
vilmibm
70c948a751 move isURL 2020-07-23 11:23:45 -05:00
vilmibm
dc02366128 move generateRepoURL to ghrepo 2020-07-23 11:16:47 -05:00
vilmibm
895af993a5 static not found error 2020-07-23 11:12:33 -05:00
vilmibm
12e88da400 w h i t e s p a c e 2020-07-23 11:10:25 -05:00
vilmibm
2a99ed9afb add ResolvedBaseRepo 2020-07-23 11:01:29 -05:00
vilmibm
7b8d226e0f remove redundant statement 2020-07-22 15:54:11 -05:00
vilmibm
a27c8a9c21 isolate repo view cmd 2020-07-22 15:54:11 -05:00
Mislav Marohnić
ac1333ace1
Merge pull request #1379 from cli/go-ldflags
Enable adding to GO_LDFLAGS without having to replace them all
2020-07-22 18:41:33 +02:00
Nate Smith
41376a3626
Merge pull request #1406 from cli/migrate-gist
migrate gist create to new command format
2020-07-22 10:47:03 -05:00
vilmibm
05419e46f0 put gist fixture file into gist package 2020-07-22 10:36:12 -05:00
Mislav Marohnić
97350e87a1 Merge remote-tracking branch 'origin' into migrate-gist 2020-07-22 16:17:30 +02:00
Mislav Marohnić
16739c3044 Whoops, gist create stderr is not empty 2020-07-22 14:59:35 +02:00
Mislav Marohnić
b195075644 Tweak approach to iostreams in tests
- avoid typecast to `*bytes.Buffer`
- assert that stderr is empty
2020-07-22 14:50:23 +02:00
Mislav Marohnić
41f7b054e6 Bump golangci-lint to v1.29.0
Trying to address https://github.com/cli/cli/pull/1406/checks?check_run_id=896316941
which I cannot reproduce locally on macOS
2020-07-22 14:18:18 +02:00