William Martin
fc19ff321a
Merge pull request #10549 from cli/10548-v2680-failed-to-run-secret-commands
...
Fix secret command panic when base repo from cwd
2025-03-06 12:01:40 +01:00
William Martin
db8b38a185
Fix secret command panic when base repo from cwd
2025-03-06 11:45:22 +01:00
Kynan Ware
a92528a158
Merge pull request #10546 from cli/kw-wm-af/base64-decode-gpg-passphrase-in-deployment-workflow
...
Base64 decode GPG passphrase in deployment workflow
2025-03-05 12:44:33 -07:00
Kynan Ware
601c3e448c
Fix(ci): base64 decode GPG passphrase
2025-03-05 12:43:44 -07:00
Meredith Lancaster
4d44e4f20c
Merge pull request #10382 from malancas/refactor-get-attestations-funcs
...
Refactor `GetLocalAttestations` and clean up custom registry transport
2025-03-05 11:46:36 -07:00
Meredith Lancaster
917a00ddc1
Update pkg/cmd/attestation/verification/attestation.go
...
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
2025-03-05 07:31:35 -07:00
Meredith Lancaster
ddc36c8a8e
Update pkg/cmd/attestation/verification/attestation.go
...
Co-authored-by: Fredrik Skogman <kommendorkapten@github.com>
2025-03-05 07:31:28 -07:00
Andy Feller
8683656783
Merge pull request #10539 from cli/wm/secret-env-var
...
Check `GH_REPO` too in addition to `--repo` for disambiguation
2025-03-05 08:39:31 -05:00
Andy Feller
a18a9594be
Fix acceptance test descriptions
2025-03-05 08:27:50 -05:00
Andy Feller
50780fc469
Fix gh secret disambiguity test
...
The previous commit failed to update the 2nd set of tests to rely upon GH_REPO instead of --repo flag.
These have been tested against `trunk` and fail because not being in a git directory when they should pass.
2025-03-04 14:31:12 -05:00
Andy Feller
0da037ca8f
Expand gh secret acceptance tests
...
This commit builds on top of work previously done within acceptance tests around gh secret and remote disambiguation.
The choice of expanding this existing test rather than creating a new test was in order to keep context together within a single acceptance test rather than splitting it over multiple.
2025-03-04 14:16:00 -05:00
Andy Feller
23ea61d325
Expand gh secret base repo tests
...
Building on top of the work done in commands to account for GH_REPO environment variable, this commit expands existing tests around handling base repo functions to include new test scenarios.
These tests fail in the same way as reported on the issue when run against `trunk` without the other branch's changes, demonstrating they will help avoid regression.
2025-03-04 13:39:38 -05:00
Azeem Sajid
d67d65e304
[gh secret] Check GH_REPO too in addition to --repo for disambiguation
2025-03-04 18:36:53 +01:00
Meredith Lancaster
671c4c23a9
Merge branch 'trunk' into refactor-get-attestations-funcs
2025-03-04 09:33:00 -07:00
William Martin
b8cf16dc2d
Deep Dive Document Release Process ( #10503 )
2025-03-04 13:30:29 +01:00
Andy Feller
5e21f6ac17
Merge pull request #10521 from cli/jtmcg/fix-workflow-panic
...
Fix unhandled panic in FindWorkflow and add tests
2025-03-03 13:14:49 -05:00
Tyler McGoffin
a18c54e824
Fix unhandled panic in FindWorkflow and add tests
...
FindWorkflow had a code path that could error without handling that error
that was introduced in #10328 . I previously called out the lack of tests
in this part of the code in my review, and punting them then bit us here:
https://github.com/cli/cli/pull/10328#pullrequestreview-2597266783 .
As such, this fixes the panic, but also adds tests to cover the relevant
code paths through FindWorkflow, including some tests for getWorkflowByID,
getWorkflowsByName, and GetWorkflows.
This does NOT seek to refactor the existing code, just cover the existing
behavior and validate that we are resolving this panic (covered by
TestFindWorkflow_nonHTTPError).
2025-02-28 15:11:53 -08:00
Andy Feller
817eeb26e5
Merge pull request #10518 from cli/dependabot/github_actions/actions/attest-build-provenance-2.2.2
...
Bump actions/attest-build-provenance from 2.2.0 to 2.2.2
2025-02-28 11:17:15 -05:00
dependabot[bot]
b83a1a06ef
Bump actions/attest-build-provenance from 2.2.0 to 2.2.2
...
Bumps [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance ) from 2.2.0 to 2.2.2.
- [Release notes](https://github.com/actions/attest-build-provenance/releases )
- [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md )
- [Commits](520d128f16...bd77c07785
2025-02-28 14:52:41 +00:00
William Martin
f8d9aac7e5
Merge pull request #10512 from cli/wm-kw/fix-pr-checkout-for-forks
...
Fix checkout when URL arg is from fork and cwd is upstream
2025-02-28 13:31:59 +01:00
William Martin
11b9496e17
Fix checkout when URL arg is from fork and cwd is upstream
2025-02-27 16:56:11 +01:00
Andy Feller
f9d50d86ac
Merge pull request #10508 from iamazeem/10449-inconsistent-examples-format
...
Inconsistent format of examples in help text
2025-02-27 09:15:14 -05:00
Azeem Sajid
515bb96b2f
Update project help text; fix unlink usage
2025-02-27 17:51:05 +05:00
Azeem Sajid
33c30d5bd1
Inconsistent format of examples in help text
2025-02-27 16:26:25 +05:00
Azeem Sajid
69fff52026
Inconsistent format of description of flags (starting with lowercase letter) ( #10507 )
2025-02-27 11:40:21 +01:00
Meredith Lancaster
33d863f98d
Merge pull request #10308 from malancas/attestation-verify-ref-commit-policy-opts
...
Add signer-digest, source-ref, and source-digest options for `gh attestation verify`
2025-02-26 14:27:31 -07:00
William Martin
5622d18bfa
Merge pull request #10504 from cli/wm/update-go-version-in-contributing
...
Update Go version to 1.23 in CONTRIBUTING.md
2025-02-26 16:00:59 +01:00
Tyler McGoffin
5d2eadef8c
Merge pull request #10499 from cli/dependabot/go_modules/github.com/go-jose/go-jose/v4-4.0.5
...
Bump github.com/go-jose/go-jose/v4 from 4.0.2 to 4.0.5
2025-02-25 11:13:21 -08:00
Tyler McGoffin
ed2c322a73
Merge pull request #10384 from iamazeem/9798-gh-api-encode-package-name
...
[gh api] Escape package name (URL encoding) for packages endpoint
2025-02-25 11:12:48 -08:00
William Martin
c78f6e7618
Update Go version to 1.23 in CONTRIBUTING.md
2025-02-25 17:31:32 +01:00
William Martin
f019cf7cea
Merge pull request #10501 from cli/wm/fix-minor-auth-login-help
...
Fix minor auth login help typo
2025-02-25 16:47:38 +01:00
William Martin
ac6ad78ff9
Fix minor auth login help typo
2025-02-25 12:27:30 +01:00
Azeem Sajid
9c87069199
Add docs; rename function name
2025-02-25 10:37:14 +05:00
dependabot[bot]
3cea9f375b
Bump github.com/go-jose/go-jose/v4 from 4.0.2 to 4.0.5
...
Bumps [github.com/go-jose/go-jose/v4](https://github.com/go-jose/go-jose ) from 4.0.2 to 4.0.5.
- [Release notes](https://github.com/go-jose/go-jose/releases )
- [Changelog](https://github.com/go-jose/go-jose/blob/main/CHANGELOG.md )
- [Commits](https://github.com/go-jose/go-jose/compare/v4.0.2...v4.0.5 )
---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v4
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-02-24 22:52:15 +00:00
Kynan Ware
756f4ec04a
Merge pull request #10490 from cli/kw/cli-10095-document-how-to-revoke-oauth-tokens
...
docs: document how to revoke `gh` OAuth tokens in `auth logout`'s help
2025-02-24 14:24:44 -07:00
Kynan Ware
d68a4daa8c
docs: OAuth doc link moves to newline
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-02-24 14:12:19 -07:00
Kynan Ware
b189298a6e
Merge pull request #10489 from beforetech/my_feature
...
refactor: use a more straightforward return value
2025-02-24 12:52:52 -07:00
Meredith Lancaster
ba5cf8e1ce
Merge branch 'trunk' into attestation-verify-ref-commit-policy-opts
2025-02-24 10:59:58 -07:00
Meredith Lancaster
343d9babeb
fix expected test output
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-02-24 10:51:34 -07:00
Meredith Lancaster
37a91ebfdb
undo regex changes
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-02-24 10:47:39 -07:00
Meredith Lancaster
ce87c746b2
remove signer-ref option
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2025-02-24 10:44:29 -07:00
William Martin
afa5e744d9
Merge pull request #10491 from cli/kw/update-codespaces-devcontainer
...
chore: update codespaces Go version
2025-02-24 12:08:13 +01:00
Kynan Ware
1d2fbd5155
chore: update go version in devcontainer
...
Since `gh` uses Go 1.23, the devcontainer needs to be updated to
allow building `gh` in a fresh codespace.
2025-02-23 18:39:53 +00:00
Kynan Ware
736447cca4
docs: warn about process revoking all tokens
2025-02-23 18:24:28 +00:00
Kynan Ware
e2f382c44d
docs: document how to revoke gh OAuth tokens
...
This documents how to revoke OAuth tokens generated by `gh`. This also
adjusts some language to match the language used by GitHub.com:
"invalidate" is now "revoke".
2025-02-23 18:12:06 +00:00
beforetech
563c2f9e18
refactor: use a more straightforward return value
...
Signed-off-by: beforetech <mail@before.tech>
2025-02-23 22:59:33 +08:00
William Martin
537a22228c
Merge pull request #10479 from latzskim/gh-pr-checkout-with-no-tags
...
Do not fetch tags on PR checkout.
2025-02-21 13:12:29 +01:00
William Martin
437c52f807
Test pr checkout force on different branch
2025-02-21 13:00:48 +01:00
William Martin
7fa48822e3
Merge pull request #10478 from cli/wm/fix-flaky-tuf-client-race
...
Allow injection of TUFMetadataDir in tests
2025-02-21 11:58:36 +01:00
latzskim
e331daabce
[gh pr checkout] Add --no-tags option to git fetch commands in checkout logic
2025-02-20 19:04:16 +01:00
