Commit graph

71 commits

Author SHA1 Message Date
vilmibm
fc25a4e9ed check for disabled issues in issue view command 2020-01-21 15:37:42 -06:00
vilmibm
bfdf89b579 updated based sorting and fuzzy time display on issue status 2020-01-17 15:38:41 -06:00
Tiernan L
99c17c3a5f Merge pull request #227 from github/typoswap
Typo fixes for Issue/PR preview text
2020-01-16 16:51:02 -08:00
vilmibm
31001877bd hide potentially long query strings when printing urls 2020-01-16 14:18:40 -06:00
vilmibm
32461284cc fix some TODOs 2020-01-15 12:35:28 -06:00
vilmibm
3468a46521 support preview in browser for issue create 2020-01-15 11:27:12 -06:00
Tiernan L
82d0060eb4 terminal notice 2020-01-14 11:26:44 -10:00
Tiernan L
42f876354d fix typo 2020-01-14 10:34:05 -10:00
Nate Smith
42f58eac4b Merge pull request #203 from github/preview-things
Preview issues and PRs on the terminal
2020-01-13 17:59:34 -06:00
vilmibm
5bc6d220c4 review feedback 2020-01-13 15:32:07 -06:00
Nate Smith
c5486ee3f2 Merge pull request #210 from github/noprinting
minor text edits
2020-01-13 12:19:01 -06:00
vilmibm
f911a234c2 print to proper handle 2020-01-10 15:12:54 -06:00
vilmibm
4925c3cf01 preview PRs and issues in the terminal with -p 2020-01-10 11:41:26 -06:00
Tiernan L
025845e9ff browser is sufficient
We used "browser" and "web browser" in multiple places. I made them all consistent.
2020-01-09 15:29:11 -10:00
Corey Johnson
c9bcf807b1 Make it work with PRs 2020-01-08 12:31:23 -08:00
Corey Johnson
3eb820631d Add "and x more" text" 2020-01-07 14:51:49 -08:00
Corey Johnson
2e0ea153d5 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2020-01-06 09:52:26 -08:00
Mislav Marohnić
fb0472a868 Merge pull request #176 from github/issue-pr-templates
Add template support to `issue create`, `pr create`
2019-12-23 13:41:15 +01:00
Corey Johnson
8f74b658b2 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2019-12-20 11:51:37 -08:00
Corey Johnson
b66c34e0ec Output to stderr 2019-12-20 11:16:27 -08:00
Mislav Marohnić
aeb7f337d2 Ensure issue create fails fast if issues are disabled
Before, a person would be prompted for title & body before
unconditionally failing due to issues being disabled.
2019-12-19 15:44:20 +01:00
Mislav Marohnić
d5ba3de751 Add template support to issue create, pr create
If multiple templates are found, the user is prompted to select one.

The templates are searched for, in order of preference:

- issues:
  1. `.github/ISSUE_TEMPLATE/*.md`
  2. `.github/ISSUE_TEMPLATE.md`
  3. `ISSUE_TEMPLATE/*.md`
  4. `ISSUE_TEMPLATE.md`
  5. `docs/ISSUE_TEMPLATE/*.md`
  6. `docs/ISSUE_TEMPLATE.md`

- pull requests:
  1. `.github/PULL_REQUEST_TEMPLATE/*.md`
  2. `.github/PULL_REQUEST_TEMPLATE.md`
  3. `PULL_REQUEST_TEMPLATE/*.md`
  4. `PULL_REQUEST_TEMPLATE.md`
  5. `docs/PULL_REQUEST_TEMPLATE/*.md`
  6. `docs/PULL_REQUEST_TEMPLATE.md`

The filename matches are case-insensitive.
2019-12-18 22:15:20 +01:00
Mislav Marohnić
7b7c985e79 Merge remote-tracking branch 'origin/master' into appropriate-context-and-feedback 2019-12-17 13:00:10 +01:00
Mislav Marohnić
4ad89829c5 Merge remote-tracking branch 'origin/master' into stderr-tests 2019-12-17 12:42:01 +01:00
Corey Johnson
6d0f4e7a90 Add more text 2019-12-16 11:41:56 -08:00
Nate Smith
00da5c2788 Merge pull request #158 from github/issue-create-web
Add "Opening URL in your browser" notice to `issue create --web`
2019-12-16 10:53:31 -06:00
Mislav Marohnić
48aeff1ca7 Assert stdout separarely from stderr in command tests
This stubs stderr separately from stdout in command tests (before those
streams were combined) and improves test assertions around output.

Additionally, no longer use the `cmd.Print*()` family of Cobra functions
because their name sounds like the text will go to stdout, but they
write to stderr instead. Use the more explicit `cmd.ErrOrStderr()` as
output destination instead.
2019-12-16 15:46:42 +01:00
Mislav Marohnić
57c7266328 Fix displaying "There are no issues assigned to you" notice 2019-12-16 14:08:55 +01:00
Mislav Marohnić
5d6b095f1a Add "Opening URL in your browser" notice to issue create --web 2019-12-16 13:39:22 +01:00
Corey Johnson
573dda22a1 Simplify flag setting 2019-12-11 10:19:18 -08:00
Corey Johnson
748b213c9a Add error details for gh issue view 2019-12-10 16:04:04 -08:00
Corey Johnson
5296f72189 Better messaging for gh pr checkout 2019-12-10 16:03:05 -08:00
Corey Johnson
5949ca4b56 Merge pull request #142 from github/empty-pr-list
Add empty state for `gh pr list`
2019-12-10 12:04:41 -08:00
Corey Johnson
4de0a76234 Merge pull request #141 from github/add-url-branch-to-usage
Add better usage docs for `gh pr view` `gh pr checkout` `gh issue view`
2019-12-06 14:39:43 -08:00
Corey Johnson
f70473c234 Replace excessive whitespace 2019-12-06 14:32:55 -08:00
Corey Johnson
00b38bb11c Add better message to empty gh issue list 2019-12-06 14:10:01 -08:00
Mislav Marohnić
5f90cdc801 Elaborate on what is accepted as issue/PR arguments 2019-12-06 18:01:36 +01:00
Mislav Marohnić
4b8921f011 Consistently use {} to denote mutually exclusive options 2019-12-06 18:01:14 +01:00
Mislav Marohnić
8222e7d74f Consistently use <> to denote placeholders 2019-12-06 17:59:36 +01:00
Corey Johnson
bbb91d6a2a Replace newlines 2019-12-05 14:12:12 -08:00
Corey Johnson
cce2fd4a22 Add better usage docs 2019-12-05 11:40:36 -08:00
Mislav Marohnić
b223176b37 Accept issue URL in issue view <issue>
Also validates that the issue passed either by number or by URL exists.
2019-12-03 21:41:22 +01:00
Mislav Marohnić
2621bccc44 Use RunCommand in tests to ensure flags reset between runs 2019-12-03 17:26:28 +01:00
Mislav Marohnić
64dcdd68e5 Merge pull request #118 from github/win-ansi-color
Fix ANSI color output on Windows
2019-11-28 11:47:02 +01:00
Mislav Marohnić
ae2e8f057c Merge branch 'master' into flags-language 2019-11-27 23:18:20 +01:00
Mislav Marohnić
b6fa88337d Ensure that commands print to a colorable output
If a command does `fmt.Print(...)` for output that contains ANSI color
codes, this not safe on Windows. We have to ensure that we always use
the `fmt.Fprint*` family of functions with a writer that was transformed
using `utils.NewColorable()`.
2019-11-27 20:51:51 +01:00
Mislav Marohnić
b8a0754a03 💅 Sentence case for CLI flags 2019-11-27 17:09:40 +01:00
Mislav Marohnić
6179570873 Replace "Recent issues" with "Issues opened by you" 2019-11-27 16:56:53 +01:00
Mislav Marohnić
bfdef59377 💅 consistent sub-command initialization style 2019-11-27 16:49:24 +01:00
Nate Smith
89700216c6 Merge pull request #97 from github/issue-create-editor
Use survey when creating issues
2019-11-25 11:34:11 -06:00