Commit graph

792 commits

Author SHA1 Message Date
wingkwong
fc330ded51 feat: add gist to scope #397 2020-02-25 01:25:17 +08:00
Mislav Marohnić
67e1fbcae5
Merge pull request #524 from yashLadha/chore/add_vendor_to_ignore
chore: added vendor to ignore as mod is already present
2020-02-21 13:07:43 +01:00
Mislav Marohnić
1eff7c1862
Merge pull request #306 from henvic/feat/debug-req
impr(verbose): using package httpretty to log requests on DEBUG.
2020-02-21 13:06:13 +01:00
Mislav Marohnić
9c00ac0224 Tweak verbose HTTP logging
- log headers only in DEBUG=api mode
- enable color output on stderr
- hide little-useful TLS debbuging info
- ensure all request headers are logged
2020-02-21 12:57:00 +01:00
Mislav Marohnić
9c2efd6c1c Extract reusable IsTerminal() 2020-02-21 12:46:21 +01:00
Henrique Vicente
e7c88d0fb1
impr(verbose): using package httpretty to log requests on DEBUG. 2020-02-21 02:46:18 +01:00
Yash Ladha
3a695d9874
chore: added vendor to ignore as mod is already present 2020-02-21 03:36:53 +05:30
Mislav Marohnić
b5d0b7c640
Merge pull request #523 from cli/title-body-web
Respect title & body from arguments to `pr create -w`
2020-02-20 22:53:40 +01:00
Mislav Marohnić
1a82e39ba9 Respect title & body from arguments to pr create -w 2020-02-20 22:48:04 +01:00
Mislav Marohnić
69304ce9af
Merge pull request #518 from cli/eastern-asian
Fix column alignment and truncation for Eastern Asian languages
2020-02-20 22:36:11 +01:00
Mislav Marohnić
f9649ebddd
Merge pull request #521 from yashLadha/bug/issue_list_on_no_remote
Fix error when getting issue list with no git remotes

Fixes #465
2020-02-20 22:35:35 +01:00
Mislav Marohnić
4727fc4659 Ensure descriptive error when no github.com remotes found 2020-02-20 22:30:25 +01:00
Yash Ladha
4ee995dafd
fix(486): Getting issue list on no remotes specified
Fixes: #486
2020-02-21 02:14:20 +05:30
Mislav Marohnić
4c3e498021 Fix column alignment and truncation for Eastern Asian languages
- Ensure that text is never truncated mid-character, which would result
  in garbled text

- Ensure that columns in `issue/pr list` output align properly
2020-02-20 18:52:17 +01:00
Mislav Marohnić
cbc2d16230
Merge pull request #513 from cli/closed-incl-merged
Include merged PRs with `list --state=closed`
2020-02-20 14:01:39 +01:00
Mislav Marohnić
13dbfa44c2 go fmt 2020-02-20 13:55:55 +01:00
Mislav Marohnić
861b231344 Have --state=closed include merged PRs
Since we currently offer no way of querying PRs by combining multiple
states with an OR, the best way to handle the `closed` state is to match
what the web UI is doing; that is to include merged PRs.
2020-02-20 13:53:44 +01:00
Mislav Marohnić
cc96ddd551
Merge pull request #512 from cli/dependency-bump
Bump dependencies
2020-02-20 13:11:18 +01:00
Mislav Marohnić
619c9d9495 Bump dependencies
go get -u -t ./...
    go get github.com/charmbracelet/glamour@8d4e3f0
    go mod tidy
2020-02-20 12:51:32 +01:00
Nate Smith
57eb1d1d45
Merge pull request #505 from cli/completion-error-handling
Make sure to handle errors when generating completions
2020-02-19 08:52:34 -06:00
Mislav Marohnić
6424e8c92a Make sure to handle errors when generating completions 2020-02-19 15:39:33 +01:00
Mislav Marohnić
f6c9e7b4af
Merge pull request #497 from ShahzadUmair/fix-template
Explicitly replace empty body with default template
2020-02-19 15:04:53 +01:00
Nate Smith
f6856d9783
Merge pull request #483 from cli/pr-create-web-base
Respect overriden base branch in `pr create --web`
2020-02-18 16:11:39 -06:00
Nate Smith
957fb6635f
Merge pull request #459 from sh7dm/feat/arm64
Release for arm64 linux
2020-02-18 15:33:05 -06:00
UmairShahzad
12216fee8c reset to template if body is empty 2020-02-19 02:16:12 +05:00
Nate Smith
d682c1ca01
Merge pull request #311 from penguwin/glamour-markdown
Use glamour as markdown rendering backend for issue & pr previews
2020-02-18 14:33:59 -06:00
Nate Smith
c65ac4ae9d
Merge branch 'master' into glamour-markdown 2020-02-18 14:23:49 -06:00
Nate Smith
30a4a53744
Merge pull request #495 from cli/table-crash
Fix crash in `issue/pr list` for narrow terminals
2020-02-18 13:24:16 -06:00
Mislav Marohnić
61ff5d73bd Fix crash in issue/pr list for narrow terminals
If the available column width is smaller than 3, don't try to truncate
with ellipsis (`...`). Instead, just truncate to available width.
2020-02-18 20:03:09 +01:00
Mislav Marohnić
02b4ab5be3
Merge pull request #492 from arnottcr/oauth
context: use the real oauth credentials
2020-02-18 19:36:21 +01:00
Mislav Marohnić
c32bcee4bb No need to configure production OAuth app on release anymore 2020-02-18 19:31:18 +01:00
Mislav Marohnić
72bde685b0 Add back comments explaining OAuth app credentials 2020-02-18 19:31:18 +01:00
Colin Arnott
213f4a5333 context: use the real oauth credentials
It is trivial to extract this information from the released artefacts,
thus there is no security benefit to the safe/development credentials.
This approach also prevents users from using go-get to install.

As proof of concept, and to enable go-get, this change embeds
the GitHub CLI credentials, instead of GitHub CLI (dev).
2020-02-18 19:31:01 +01:00
Nate Smith
48ffd5aa00
Merge pull request #484 from cli/issue-template-labels
Add labels to issue template
2020-02-18 10:04:54 -06:00
Nate Smith
0215074f5e
Merge pull request #481 from cli/ci-pulls
Enable CI for pull requests from forks
2020-02-18 10:03:13 -06:00
Mislav Marohnić
75b7e9588a
Merge pull request #491 from arnottcr/version
command: default to toolchain version
2020-02-18 14:04:16 +01:00
Mislav Marohnić
408b565fd9 Allow setting version via ldflags again 2020-02-18 13:47:57 +01:00
Mislav Marohnić
032390ee22
Merge pull request #490 from jschmid1/patch-1
Add openSUSE/SUSE install instructions to README
2020-02-18 12:42:41 +01:00
Mislav Marohnić
7dc24a867a
Merge pull request #488 from emecas/doc-manual-pages-clarification
(Docs) Updating CONTRIBUTING.md
2020-02-18 12:26:27 +01:00
Colin Arnott
de6e99aa75
command: default to toolchain version
Since the Go toolchain is able to extract the module version at build
time, we should use that as a default instead of DEV. This means
customers installing via go-get will get the correct version.

Unfortunately, the toolchain does not store when the build occurs, so
BuildTime now defaults to the empty string. It is still set if build
officially, just not for go-get.
2020-02-18 07:55:54 +00:00
Joshua Schmid
abfc4d3b1a
Add openSUSE/SUSE install instructions to README 2020-02-18 08:53:37 +01:00
Emerson Castaneda
103d62b309 Add manual-pages-are-automatically-generated clarification 2020-02-17 21:29:04 -05:00
Mislav Marohnić
9dd9b8c763
Merge pull request #406 from Foxboron/morten/fix-reproducible
[Makefile] Support reproducible builds
2020-02-17 16:54:19 +01:00
Mislav Marohnić
69d859a47f Add labels to issue template 2020-02-17 15:43:51 +01:00
Mislav Marohnić
96ba2d27d8 Respect overriden base branch in pr create --web 2020-02-17 14:14:37 +01:00
Mislav Marohnić
5f6fd35a99 Enable CI for pull requests from forks 2020-02-17 12:52:48 +01:00
Mislav Marohnić
5d2677ed33
Merge pull request #476 from sh7dm/chore/typoes
Correct typoes in comments
2020-02-17 12:17:45 +01:00
Mislav Marohnić
df60d8829d
Merge pull request #461 from TaKO8Ki/fix-typo
Fix typo
2020-02-17 12:17:17 +01:00
Mislav Marohnić
08811c1e05
Merge pull request #466 from emecas/doc/req_go_version_13
[DOCs] Indicate Go's Version Required for Installing from Source
2020-02-17 12:08:16 +01:00
Mislav Marohnić
3138b3b2a6
Update note about required Go version 2020-02-17 12:07:39 +01:00