Commit graph

73 commits

Author SHA1 Message Date
Liz MacLean
0bc4218024
Update README.md to have a more explicit callout about timeout-minutes 2025-05-09 09:01:03 -04:00
Sunny
bfb0ba38d0
Adding support for issue-body with more than 65536 words, issue body to be created as an issue comment (#167)
* push a built package to ghcr
* adding err catch
* auth check
* auth update
* update uname
* update uname
* testing with splitted issues
* minor fix
* revert testing changes
* Update approval.go
2025-04-26 12:02:02 +05:30
Simeon Widdis
c1ebf589e2
Make name comparison case-insensitive (#172)
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
2025-04-20 21:06:57 +05:30
Liz MacLean
ef4dddd64b
Issue templates (#161) 2025-03-17 10:58:51 -04:00
Liz MacLean
330ce9b42b
Create CONTRIBUTING.md (#160) 2025-03-17 10:58:39 -04:00
sunny-1651
e6592a6b32 create go sum at build-time with fresh hashes 2025-03-07 13:18:18 +05:30
Mateus Caruccio
c10ec77612
Feature: Save output (#132) 2025-03-07 01:46:54 -05:00
Liz MacLean
8248019266
Cleanup README and add some more informative messaging (#149) 2025-03-06 15:50:38 -05:00
Sanskar Arora
f464d52e13
Merge pull request #158 from trstringer/codeql-trigger-patch
Update codeql.yml
2025-03-04 21:55:06 +05:30
Sanskar Arora
2177c2e237
Update codeql.yml 2025-03-04 21:54:44 +05:30
Sanskar Arora
40f0592f18
Merge pull request #150 from lizziemac/feat/remove-extra-title-text
Remove default title if custom title is provided
2025-03-04 21:46:27 +05:30
Sanskar Arora
8b4df3f1bc
Dependabot codeql patch (#152)
* addding codecheck yamls

* updating versions

* code ql to run only on main repo not forks
2025-03-03 19:26:53 -05:00
Bailey Everts
77d7e0184d
feat: dispaly users as a list (#138) 2025-02-23 11:36:20 -05:00
Bailey Everts
846a0ce970
feat: use blocks for issue-body (#137) 2025-02-22 13:53:00 -05:00
Sanskar Arora
c17f1c63ff
Adding the capability to create the approval issue in the another repository (#142)
* Adding the capability to create the approval issue in another repository

* reverting testing changes

* reverting test changes contd.

* Updating readme and removing a debug line

* Introduce a 'fail-on-denial' boolean (#147)

* Introduce a 'fail-on-approval' boolean

* Use test docker image

* oops

* change default and fix logic

* Update action.yaml

* Fix linting error

* Adding the capability to create the approval issue in another repository

* reverting testing changes

* reverting test changes contd.

* moving targetRepo inputs from env vars to action-args

* Update constants.go

* Update constants.go to resolve nuances created by inconsistent tab length settings

---------

Co-authored-by: Liz MacLean <18120837+lizziemac@users.noreply.github.com>
2025-02-22 13:50:00 -05:00
Liz MacLean
17c84dd688 Remove default title if custom title is provided 2025-02-17 15:12:35 -05:00
Liz MacLean
aba06e32f1
Introduce a 'fail-on-denial' boolean (#147)
* Introduce a 'fail-on-approval' boolean

* Use test docker image

* oops

* change default and fix logic

* Update action.yaml

* Fix linting error
2025-02-14 20:23:48 -05:00
Florian Kaiser
d2e412d840
Fix issue URL in job log (#112) 2024-06-19 17:22:23 -04:00
Yucel Okcu
287b77b470
fix: use correct base URL if not enterprise (#125) 2024-06-19 17:20:51 -04:00
Thomas Stringer
662b3ddbc7
Create new release (#123) 2024-06-12 20:42:28 -04:00
Vanley
315f51d888
add timeout-minutes to valid imputs (#121) 2024-06-12 20:21:14 -04:00
Augusto Melo
dd1555b1d1
fix(#75): display corect base URL if using GHE (#90)
It was displaying the GH URL even though the GHE was configured, using the client.baseURL will correctly display a
correct value.

https://pkg.go.dev/github.com/google/go-github/v50/github#Client
2023-04-23 11:02:50 -04:00
Thomas Stringer
a824dad59a
Release v1.9.0 (#84)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2023-02-18 09:43:31 -05:00
Brandon Ward
639442a9fa
Feature: Allow Custom Approval or Denial Words (#66)
* Add support for custom approval and denial words

* Work out some regex nuances with GitHub
2023-02-16 20:20:43 -05:00
Daniel Gonzalez
948dfe9537
Add new input 'issue-body' (#74)
* Add new input 'issue-body'

Similar to the 'issue-title' input, 'issue-body' allows to put custom
text to the body of the approval issue.

* Update readme for 'issue-body' input
2023-01-20 07:13:43 -05:00
Thomas Stringer
a28646d113
Add the issue link to the action output (#64)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-14 19:27:43 -05:00
Thomas Stringer
36a6b4b6cb
Add GitHub release creation to dev docs (#63)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-13 16:21:01 -05:00
Thomas Stringer
3276970bc1
Release v1.8.0 (#62)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-13 16:17:08 -05:00
Thomas Stringer
f204a35271
Add dev guide to the documentation (#61)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-13 12:03:48 -05:00
Thomas Stringer
05a49ff052
Fix bug with period in org team name (#60)
Currently if you have an org team name with a period in it, the team will not be found with a 404 response. This is because the GitHub API requires that the periods are replaced with hyphens. This PR fixes this behavior and closes #55.

Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-11 17:59:51 -05:00
Timothy Ng
753e13e935
Option to exclude workflow initiator (GITHUB_ACTOR) as an approver (#59)
* Add constant for GITHUB_ACTOR env var

* autoformat

* Ignore workflow initiator

* Fix incorrect if-else

* refactor: camelcase userName

* fix typo

* Add allow-workflow-initiator-as-approver input

* Add shouldIncludeWorkflowInitiator

* Add usage & description for allow-workflow-initiator-as-approver

* Clearer input description

* refactor: rename inputs/vars to 'exclude'

* update error msg with correct input name

* docs: move note on optional/default to description
2022-11-10 12:25:31 -05:00
Jens H
a7a4994e00
Update README with app token timeout limits (#42) 2022-11-09 17:51:36 -05:00
Thomas Stringer
0871d5bc6b
Create release v1.7.0 (#58)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-06 08:21:37 -05:00
Thomas Stringer
955f242e70
Add documentation for required permissions (#57)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-11-06 08:12:10 -05:00
Wojciech Sielski
984d11212e
Adapt for Enterprise version - respect GITHUB ENV variables (#52)
Co-authored-by: wojciech.sielski <wojciech.sielski@adevinta.com>
2022-10-27 15:06:13 -04:00
Troy Witthoeft
2e9a86d9a2
Update approvers.go (#44)
Handling usernames with whitespace issue = https://github.com/trstringer/manual-approval/issues/43
2022-08-21 13:10:25 -04:00
Thomas Stringer
367124c80b
Release v1.6.0 (#40)
Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-08-14 19:00:18 -04:00
Thomas Stringer
1e890961bd
Add documentation for team approver (#39)
* Add documentation for team approver

This feature is now tested and this PR adds the necessary documentation
to show how to implement org team expansion for approvers.

Signed-off-by: Thomas Stringer <thomas@trstringer.com>

* fix action version

Signed-off-by: Thomas Stringer <thomas@trstringer.com>
2022-08-14 18:52:30 -04:00
Thomas Stringer
46dbdde656
Release v1.6.0-rc.2 (#35) 2022-07-14 22:31:30 -04:00
Thomas Stringer
8cbc88a78c
Troubleshoot and log failed group expansion (#34)
Currently group expansion is failing. I suspect this is due to workflow
permissions, as this succeeds locally. This additional logging should
show unexpected errors that aren't just a non-group expansion.
2022-07-14 22:29:36 -04:00
Thomas Stringer
275c15b013
Create release v1.6.0-rc.1 (#33) 2022-07-14 22:15:20 -04:00
Thomas Stringer
78b4c148f1
Add ability to specify a team as an approver (#32)
Prior to this change, the approvers could only be explicit users. With
this change, you can now specify an org team and this will be expanded
out with a user list for approvers.

Closes #14.
2022-07-14 22:11:38 -04:00
Thomas Stringer
d8f25cb80e
Add branding to the Marketplace Action (#31)
Adds icon and color to the Action's branding in the Marketplace.
2022-07-14 19:57:45 -04:00
Thomas Stringer
c89961879d
Release v1.5.1 (#28) 2022-06-29 21:34:22 -04:00
Thomas Stringer
5b477abdf2
Add required approvers permissions requirement to documentation (#27)
If a required approver does not have the ability to be an approver in
the repository then when running this action you could receive an
HTTP/402 Validation Failed error. This change documents this behavior.
Closes #7.
2022-06-29 21:27:10 -04:00
Thomas Stringer
797770b08d
Add timeout to manual approval in documentation (#26)
If you want to be able to force a timeout for the manual approval
process you can use the `timeout-minutes` setting for either the step or
the job. This change documents this in the README. Closes #15.
2022-06-29 21:22:06 -04:00
Thomas Stringer
89390d2289
Add markdown files to ignored files in the CI pipeline (#25)
The CI pipeline should not be running if only markdown files are
modified, so they should be ignored.
2022-06-29 21:15:08 -04:00
Thomas Stringer
fee68ac26e
Add limitations to the README (#24)
Add the specific limitations and considerations to the project
documentation. Closes #2.
2022-06-29 21:12:01 -04:00
Thomas Stringer
816ea3dd2b
Add linting (#23)
Adds linting and fixes a couple of linting issues. Closes #6.
2022-06-29 21:02:36 -04:00
Thomas Stringer
14ea447010
Fix newline for denied (#22)
This was originally fixed for approved in #12 but the denied case was
missing. This adds a failing test and the fix for it.
2022-06-29 20:54:06 -04:00