STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1482 commits 87 branches 0 tags 160 MiB
Commit graph

806 commits

Author SHA1 Message Date
Mislav Marohnić
108f7bd66c Dirty workaround to display helpful error message on mistyped subcommands 
When executing `gh pr re` (note the incomplete command name), Cobra
would just display the help text for `gh pr` on standard output, exit
with status 0, and not print any message that you have mistyped the
"re" subcommand. Each part of this behavior is wrong.

This workaround makes sure that the helpful error message is printed on
stderr:

    $ gh pr re
    unknown command "re" for "gh pr"

    Did you mean this?
            reopen
            ready
            review

However, the exit status is still 0, whereas it should be non-zero.
Since `HelpFunc` does not return an error argument, we cannot trigger an
error status from this workaround.
 2020-05-22 19:02:34 +02:00
Mislav Marohnić
a33c00d389 Merge remote-tracking branch 'origin/master' into cobra1.0 2020-05-22 18:21:35 +02:00
Mislav Marohnić
fb63efcf05 Avoid crash around "DISMISSED" or "PENDING" reviewer states 2020-05-20 14:59:40 +02:00
Nate Smith
45dec1b3e0
Merge pull request #962 from cli/pr-diff 
pr diff
 2020-05-19 14:11:36 -05:00
vilmibm
983a1d9c3c better names 2020-05-19 14:08:20 -05:00
Corey Johnson
e0dbf37b5a
Merge pull request #960 from cli/prêt-à-réviser 
Add `gh pr ready`
 2020-05-19 11:29:33 -07:00
Corey Johnson
d209c0be01 Allow pr urls 2020-05-19 11:04:43 -07:00
vilmibm
c98b0924dc properly handle REST errors 2020-05-19 11:58:49 -05:00
dulltz
821324c2fb cosmetic 
- Align the first letter to uppercase.
- Align with no period at the end.
 2020-05-19 12:03:56 +09:00
vilmibm
ccda5ced51 lint 2020-05-18 17:45:47 -05:00
vilmibm
51b4212070 add basic tests 2020-05-18 17:39:54 -05:00
vilmibm
8e6b8d3901 cleanup 2020-05-18 17:23:36 -05:00
vilmibm
c159d41fc2 manually colorize 2020-05-18 17:15:48 -05:00
vilmibm
aaebdfc46f working with gross colorize hack + no pager 2020-05-18 16:49:51 -05:00
Corey Johnson
fde5409a70
Update command/pr_test.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:40:04 -07:00
Corey Johnson
be927b34ae
Update command/pr_test.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:52 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:29 -07:00
vilmibm
b94860bae7 add command file with pr resolution 2020-05-18 15:43:27 -05:00
Corey Johnson
b42f5527fd Remove hot dog 2020-05-18 13:27:23 -07:00
Corey Johnson
78bc7260e0 Add closed test 2020-05-18 13:08:57 -07:00
Corey Johnson
0b0070e725 Add "already marked" test 2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0 Can be marked ready for review 2020-05-18 12:42:16 -07:00
Corey Johnson
fad9f24f39 Make reopen work 2020-05-18 11:11:13 -07:00
Corey Johnson
350b4c85c0 Add failing test 2020-05-18 11:11:02 -07:00
vilmibm
228d01a037 reenable skipping body prompt for pr/issue 2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug 
pass apiClient to determineBaseRepo
 2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided (#919) 
Fixes #882
 2020-05-18 11:13:48 +02:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo 
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
 2020-05-15 15:29:33 -05:00
Mislav Marohnić
e28e6097ce
Merge pull request #891 from victorhsn/master 
add description default private for repo create
 2020-05-13 21:03:59 +02:00
Mislav Marohnić
57e60ab8a1 Merge remote-tracking branch 'origin/master' into issue-metadata-resolve-ids 2020-05-13 17:20:37 +02:00
Mislav Marohnić
1ff37be361 Fix assigning multiple user reviewers 
This was due to a typo. Fixes #913
 2020-05-13 17:16:12 +02:00
Mislav Marohnić
ab4c6e2ad0 Remove obsolete hack to generate fish completions 2020-05-13 12:51:55 +02:00
Mislav Marohnić
c225d379a9 Preserve CODEOWNERS reviewers in pr create 
When reviewers were requested on a PR, they would apparently
overwrite the current set of reviewers. A fresh PR will already have
reviewers if it was assigned some by CODEOWNERS rules.

The fix is to only ever add additional reviewers and not overwrite the
entire set.
 2020-05-13 12:09:59 +02:00
Corey Johnson
ad3a5903b2
Merge pull request #873 from cli/the-merge-dubai 
Add support for `gh pr merge`
 2020-05-12 10:18:54 -07:00
Mislav Marohnić
b75c4a812d Guard against leaked parameters in issue/pr create tests 2020-05-12 16:54:54 +02:00
Mislav Marohnić
386a53c34a Fix metadata resolver query 2020-05-12 16:48:30 +02:00
Mislav Marohnić
3abc2be0f7 Switch issue create to optimized resolver and update tests 2020-05-12 16:17:06 +02:00
Mislav Marohnić
00f23b8d86 Store milestones as slice for consistency with other metadata 
This is for code simplicity. Only 1 milestone per issue or PR is
allowed, like before.
 2020-05-12 15:48:59 +02:00
Mislav Marohnić
6d57f2a91e Faster resolve GraphQL node IDs for assignees, reviewers, and labels 2020-05-12 15:33:51 +02:00
vilmibm
79ad1ed5d3 tyop fix + stricter switch 2020-05-11 17:39:52 -05:00
vilmibm
7009321314 review feedback 2020-05-11 17:06:18 -05:00
vilmibm
c8e9768bf5 slopwip on interactive review 2020-05-11 15:28:12 -05:00
vilmibm
569595894f skip review tests for now 2020-05-11 12:09:21 -05:00
vilmibm
1675a677d6 hide credits from main help 2020-05-11 12:04:24 -05:00
vilmibm
9f0a19911a de-register review until it's ready to ship 2020-05-11 12:04:05 -05:00
Corey Johnson
a7cef60aae
Merge pull request #889 from cli/hacky-help 
Fix the help docs on subcommands
 2020-05-11 09:39:53 -07:00
Mislav Marohnić
1f0db96f2a Avoid relying on Cobra help internals 2020-05-11 12:38:22 +02:00
Nate Smith
c7f7bfc328
Merge pull request #787 from cli/issue-pr-create-metadata 
Add flags to add additional metadata to `issue/pr create`
 2020-05-08 15:04:15 -05:00
Nate Smith
5ba3baa3c8
Merge pull request #762 from doi-t/reviewers-in-pr-view 
Add Reviewers to pr view in CLI
 2020-05-08 14:46:08 -05:00