Mislav Marohnić
1ec47d8191
Improvements to gh extensions
...
- Extensions on Windows now enabled through the `sh.exe` interpreter
- `sh.exe` now found on Windows when git was installed via scoop
- `gh extensions list` command shows origin repo for the extension
- `gh extensions upgrade --all` is required to upgrade all extensions
- Added `gh extensions remove`
- Shell completions now include aliases and extension names
- `gh` help output now lists available extension names
- Extensions are stored to XDG_DATA_HOME
2021-06-21 16:54:08 +02:00
Nate Smith
936d6e1a8f
Merge pull request #3856 from cli/isolate-config-in-tests
...
Ensure that tests for command factory never read from user's config
2021-06-18 14:03:02 -07:00
Vishesh Gupta
4d20aa7873
Merge pull request #3801 from Vishesh-Gupta/automate-winget-release
...
Automate packaging for Winget
2021-06-18 15:56:58 +02:00
Mislav Marohnić
4b2cded1f8
Ensure that tests for command factory never read from user's config
...
If these tests are going to exerise `factory.New()`, the config getter
should always be overriden since the default config getter reads from
`~/.config/gh` and thus makes tests dependent on the user's environment.
2021-06-17 17:59:34 +02:00
Mislav Marohnić
dd3aac7f52
Merge pull request #3846 from cli/build-windows-fix
...
Improvements to build script on Windows
2021-06-15 18:52:03 +02:00
Sam
741f768a28
Merge pull request #3792 from chemotaxis/docs-install-via-conda
...
Document installing via Conda package manager
2021-06-15 12:19:24 -04:00
Sam
d299b74a37
Merge pull request #3841 from cli/factory-cleanup
...
Factory cleanup
2021-06-15 12:10:36 -04:00
Mislav Marohnić
bd01566251
Allow script\build as shorthand for go run script\build.go on Windows
2021-06-15 17:33:33 +02:00
Mislav Marohnić
32f9a462a8
Speed up build script by avoiding recursing into 3rd-party directories
2021-06-15 17:32:43 +02:00
Mislav Marohnić
cda406f495
Better error handling in build script on Windows
...
`script/build.go` could encounter an "Access is denied" error when the
project contains a symlink that could not be followed. This ignores such
errors with a warning and allows the build to resume.
2021-06-15 17:31:01 +02:00
Mislav Marohnić
543a17df7f
Merge pull request #3787 from cli/editor-tests
...
Allow explicitly empty body in issue/pr create
2021-06-15 16:16:59 +02:00
Sam Coe
edfac42384
Set up iostreams in factory default
2021-06-15 09:20:00 -04:00
Sam Coe
53fac59ef9
Cleanup factory/default and add tests
2021-06-15 09:19:16 -04:00
Sam
e380d68ed2
Merge pull request #3789 from cristiand391/increase-gh-pager-precedence
...
Increase `GH_PAGER` precedence
2021-06-15 09:18:57 -04:00
Mislav Marohnić
5984cf2a82
Merge pull request #3832 from cli/env-set-fix
...
Fix setting environment secrets
2021-06-14 16:17:24 +02:00
Mislav Marohnić
f7a786407d
Merge pull request #3834 from cristiand391/remove-unused-method
...
Remove unused method from `httpmock` package
2021-06-14 15:40:20 +02:00
Cristian Dominguez
d8ce615252
Remove unused method from httpmock package
2021-06-14 09:39:14 -03:00
Mislav Marohnić
3a7ce3a440
Fix setting environment secrets
...
This uses the correct public key when setting environment secrets.
https://docs.github.com/en/rest/reference/actions#get-an-environment-public-key
2021-06-14 11:51:20 +02:00
Mislav Marohnić
1f4bd80c56
Fix test flaky due to race in showing/hiding cursor
...
https://github.com/cli/cli/pull/3787/checks?check_run_id=2793254411
2021-06-14 10:58:53 +02:00
Nate Smith
aecfc01e69
Merge pull request #3809 from cli/fork-test-cleanup
...
fork tests cleanup
2021-06-11 11:31:33 -05:00
Mislav Marohnić
af90f72493
Merge pull request #3803 from cli/http-accept-header
...
Update "Accept" header for github.com requests
2021-06-11 14:38:52 +02:00
Mislav Marohnić
4debbb17cd
Further separate out test cases
2021-06-11 14:32:08 +02:00
Mislav Marohnić
7dbaaf2eb7
Merge pull request #3804 from cli/pr-status-checks
...
Fix showing Checks information in `pr status`
2021-06-11 14:18:50 +02:00
Nate Smith
b0998772ae
more cleanup
2021-06-10 21:46:02 +00:00
Nate Smith
f31a31e2ed
stop stubbing out a Since function
2021-06-10 21:46:02 +00:00
vilmibm
4a7ec7f4f6
cleaning up fork tests
2021-06-10 21:45:54 +00:00
vilmibm
14de70a011
add defaultRemoteName
2021-06-10 21:44:49 +00:00
Mislav Marohnić
a4d1ce7709
Fix fetching information about the PR potentially being behind base branch
2021-06-10 15:51:27 +02:00
Mislav Marohnić
885e94786a
Shorten GraphQL query for pr status --json
2021-06-10 15:37:58 +02:00
Mislav Marohnić
e1b5f78df3
💅 grammar in comment
2021-06-10 14:09:43 +02:00
vilmibm
395355d075
make prompt.Confirm stubbable
2021-06-08 15:49:37 -05:00
Mislav Marohnić
f5cd33b4bf
Fix showing Checks in pr status
...
This was a regression in how `statusCheckRollup` is queried and stored.
As a result, `gh pr status` did not include rendered information about
checks related to each pull request. This switches the query builder to
`PullRequestGraphQL()` to eliminate the outdated query.
2021-06-08 20:22:33 +02:00
Mislav Marohnić
3a55c26000
Update "Accept" header for github.com requests
...
The `antiope-preview` has graduated in github.com and no longer needs
activating. However, we still need it for GHES requests.
2021-06-08 19:25:40 +02:00
Mislav Marohnić
8a221bb766
Add tests for our default HTTP client
2021-06-08 19:21:48 +02:00
chemotaxis
a72f6346dd
Rearrange Conda installation instructions
...
Originally, I was thinking of putting Conda in a separate section after
the Windows section, since Conda probably isn't as well known or used.
But reading through the readme again, it seems like arranging it like
the other instructions makes more sense.
I found myself trying to look for the instructions when I first read it
in the MacOS section, but couldn't find the instructions.
2021-06-05 12:37:55 -04:00
chemotaxis
71c6b8f43a
Add links to Conda section within each OS section
2021-06-05 00:48:36 -04:00
chemotaxis
71b738b553
Make whitespace consistent
2021-06-05 00:42:39 -04:00
chemotaxis
3caba02f3c
Add documentation for installing via Conda
...
Conda is a cross-platform package and environment manager, primarily
associated with the scientific computing and data science communities.
2021-06-05 00:35:30 -04:00
Cristian Dominguez
b3c2318e09
Increase GH_PAGER precedence
...
If `GH_PAGER` is exists, set it as the pager even if one is
already set in config.
This allows a user to change/disable the pager per single invocation.
2021-06-04 23:22:37 -03:00
Mislav Marohnić
606deaf134
Allow setting empty body via editor in issue/pr create
2021-06-04 21:50:51 +02:00
Mislav Marohnić
f570deb118
Add tests for opening the editor program
2021-06-04 21:24:17 +02:00
Mislav Marohnić
75abeb13a8
Merge pull request #3786 from browniebroke/remove-secret-long-description
...
Add a long command description for secrets remove
2021-06-04 20:18:26 +02:00
Mislav Marohnić
bcfe176594
Fix flaky editor test
...
There was a race condition wherein the test didn't wait enough time for
the prompt to get rendered before testing the terminal output.
2021-06-04 20:06:21 +02:00
Bruno Alla
051520afe1
Add a long command description for secrets remove
2021-06-04 16:44:44 +01:00
Mislav Marohnić
7d8940b751
Merge pull request #3784 from browniebroke/fix/set-env-secret-description
...
Fix description for gh secret set --env option
2021-06-04 16:41:53 +02:00
Bruno Alla
4d46447eb3
Fix description for gh secret set --env option
2021-06-04 15:29:01 +01:00
Mislav Marohnić
ffebd23ba7
Merge pull request #3761 from cli/command-extensions
...
Experimental command extensions support
2021-06-03 19:13:38 +02:00
Mislav Marohnić
4bdddd72d3
Allow installing local extensions via symlinks
...
This also quits searching for local extensions in PATH.
2021-06-03 19:06:28 +02:00
Mislav Marohnić
83fcecef74
Merge pull request #3658 from chemotaxis/fix-pr-issue-body
...
Handle default body text when creating issues and pull requests
2021-06-03 18:36:45 +02:00
Mislav Marohnić
c2c691f444
Add test for our survey editor extension
2021-06-03 18:05:43 +02:00