STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
1467 commits 87 branches 0 tags 160 MiB
Commit graph

1467 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mislav Marohnić
1f3725c94d Use @me to avoid having to look up current user in pr status 2020-05-22 15:58:57 +02:00
Mislav Marohnić
d9e39226ca Clean up unused struct field 
https://github.com/cli/cli/pull/976/checks?check_run_id=693382299
 2020-05-20 17:41:33 +02:00
Mislav Marohnić
db9014fd7f Respect auth token from GITHUB_TOKEN environment variable 
If GITHUB_TOKEN is non-blank, it overrides authentication info found in
the config file. The config file is, in fact, never consulted.
 2020-05-20 17:35:10 +02:00
Mislav Marohnić
767521c055 Stop providing AuthLogin from context 
The login name of the authenticated user will be readily available only
if authentication info comes from the config file. With other upcoming
authentication modes (for example, the GITHUB_TOKEN environment
variable), the token is the only piece of information we got, so we
would need to additionally query for the login name.

Since `issue status` and `pr status` are the only commands that need the
name of the authenticated user right now, have those commands explicitly
query for the login name. This results in an additional API query, but
simplifies Context implementation and future authentication approaches.
 2020-05-20 17:09:13 +02:00
Nate Smith
45dec1b3e0
Merge pull request #962 from cli/pr-diff 
pr diff
 2020-05-19 14:11:36 -05:00
vilmibm
983a1d9c3c better names 2020-05-19 14:08:20 -05:00
Corey Johnson
e0dbf37b5a
Merge pull request #960 from cli/prêt-à-réviser 
Add `gh pr ready`
 2020-05-19 11:29:33 -07:00
Corey Johnson
d209c0be01 Allow pr urls 2020-05-19 11:04:43 -07:00
vilmibm
c98b0924dc properly handle REST errors 2020-05-19 11:58:49 -05:00
Nate Smith
06e43ac881
Merge pull request #964 from dulltz/cosmetic-short 
Cosmetic about short descriptions
 2020-05-19 00:10:24 -05:00
dulltz
821324c2fb cosmetic 
- Align the first letter to uppercase.
- Align with no period at the end.
 2020-05-19 12:03:56 +09:00
Nate Smith
d1bdb31558
Merge pull request #958 from cli/ci-git-id 
fix and tweak for site build
 2020-05-18 17:47:35 -05:00
vilmibm
ccda5ced51 lint 2020-05-18 17:45:47 -05:00
vilmibm
51b4212070 add basic tests 2020-05-18 17:39:54 -05:00
vilmibm
8e6b8d3901 cleanup 2020-05-18 17:23:36 -05:00
vilmibm
c159d41fc2 manually colorize 2020-05-18 17:15:48 -05:00
vilmibm
aaebdfc46f working with gross colorize hack + no pager 2020-05-18 16:49:51 -05:00
Corey Johnson
fde5409a70
Update command/pr_test.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:40:04 -07:00
Corey Johnson
be927b34ae
Update command/pr_test.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:52 -07:00
Corey Johnson
6eab3751d0
Update command/pr.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:43 -07:00
Corey Johnson
9721f75b2b
Update command/pr.go 
Co-authored-by: Billy Griffin <5091167+billygriffin@users.noreply.github.com>
 2020-05-18 14:39:29 -07:00
vilmibm
b94860bae7 add command file with pr resolution 2020-05-18 15:43:27 -05:00
Corey Johnson
b42f5527fd Remove hot dog 2020-05-18 13:27:23 -07:00
vilmibm
14e8498b90 fix path 2020-05-18 15:14:10 -05:00
Corey Johnson
78bc7260e0 Add closed test 2020-05-18 13:08:57 -07:00
vilmibm
d2bdd53dd2 depend on bin/gh 2020-05-18 15:08:31 -05:00
vilmibm
d800e3f0b6 rely on environment 2020-05-18 15:07:28 -05:00
Corey Johnson
0b0070e725 Add "already marked" test 2020-05-18 13:03:43 -07:00
Corey Johnson
922b6e06e0 Can be marked ready for review 2020-05-18 12:42:16 -07:00
Nate Smith
b904ed6556
Merge pull request #955 from vilmibm/skipfix 
reenable skipping body prompt for pr/issue
 2020-05-18 14:23:24 -05:00
vilmibm
da95cbd1bf use gh if available when cloning site 2020-05-18 14:05:50 -05:00
vilmibm
296062b869 configure author on site commits 2020-05-18 14:01:35 -05:00
Corey Johnson
fad9f24f39 Make reopen work 2020-05-18 11:11:13 -07:00
Corey Johnson
350b4c85c0 Add failing test 2020-05-18 11:11:02 -07:00
vilmibm
228d01a037 reenable skipping body prompt for pr/issue 2020-05-18 10:23:20 -05:00
Mislav Marohnić
4d11732a47
Merge pull request #943 from cli/reauth-bug 
pass apiClient to determineBaseRepo
 2020-05-18 13:16:07 +02:00
Kevin Bluer
d440a95aed
Improved error message when "owner/repo" format not provided (#919) 
Fixes #882
 2020-05-18 11:13:48 +02:00
vilmibm
c8c807b954 pass apiClient to determineBaseRepo 
Our code had an unspoken assumption that only one apiClient is created
during the course of a command. Violating this assumption is fine in
almost all cases, but not when we need to do a re-auth to add a new
oauth scope to a user's token.

There is likely a more elegant solution to the problem but until then
this changes determineBaseRepo to use an existing apiClient.
 2020-05-15 15:29:33 -05:00
Nate Smith
c115d32b74
Merge pull request #923 from cli/install-source 
Change source installation docs to avoid suggesting to change PATH
 2020-05-14 13:36:05 -05:00
Mislav Marohnić
e3676c3a95 Change source installation docs to avoid suggesting to change PATH 2020-05-14 18:32:57 +02:00
Mislav Marohnić
e28e6097ce
Merge pull request #891 from victorhsn/master 
add description default private for repo create
 2020-05-13 21:03:59 +02:00
Mislav Marohnić
9acaca90e2
Merge pull request #908 from cli/issue-metadata-resolve-ids 
Faster resolve assignees, reviewers, labels on create via flags
 2020-05-13 17:28:55 +02:00
Mislav Marohnić
57e60ab8a1 Merge remote-tracking branch 'origin/master' into issue-metadata-resolve-ids 2020-05-13 17:20:37 +02:00
Mislav Marohnić
1ff37be361 Fix assigning multiple user reviewers 
This was due to a typo. Fixes #913
 2020-05-13 17:16:12 +02:00
Nate Smith
3552bca596
Merge pull request #912 from cli/pr-create-codeowners-fix 
Preserve CODEOWNERS reviewers in `pr create`
 2020-05-13 10:05:10 -05:00
Mislav Marohnić
c225d379a9 Preserve CODEOWNERS reviewers in pr create 
When reviewers were requested on a PR, they would apparently
overwrite the current set of reviewers. A fresh PR will already have
reviewers if it was assigned some by CODEOWNERS rules.

The fix is to only ever add additional reviewers and not overwrite the
entire set.
 2020-05-13 12:09:59 +02:00
Corey Johnson
ad3a5903b2
Merge pull request #873 from cli/the-merge-dubai 
Add support for `gh pr merge`
 2020-05-12 10:18:54 -07:00
Mislav Marohnić
b75c4a812d Guard against leaked parameters in issue/pr create tests 2020-05-12 16:54:54 +02:00
Mislav Marohnić
386a53c34a Fix metadata resolver query 2020-05-12 16:48:30 +02:00
Mislav Marohnić
3abc2be0f7 Switch issue create to optimized resolver and update tests 2020-05-12 16:17:06 +02:00