Commit graph

1184 commits

Author SHA1 Message Date
Mislav Marohnić
2ddd61afcc
Merge pull request #795 from cli/contributing-docs
Tweak CONTRIBUTING docs to clarify our stance about installation instructions
2020-04-21 10:05:57 +02:00
Nate Smith
664d250a61
Merge pull request #785 from pabs3/debian-instructions
Update Debian instructions for modern apt versions
2020-04-20 10:36:34 -05:00
Mislav Marohnić
206cff9b67
Please avoid adding installation instructions for your OS 2020-04-17 15:34:41 +02:00
Mislav Marohnić
2f02a79df0
Touch up CONTRIBUTING docs 💅 2020-04-17 15:29:12 +02:00
Paul Wise
a6618cf02f
Update Debian instructions for modern apt versions
apt can now install local .deb files too, with dependencies.
2020-04-15 12:41:01 +08:00
Mislav Marohnić
82bd7b97cf
Merge pull request #772 from gertd/bug/rest-204
fix api.REST(DELETE, ...) failure with "unexpected end of JSON input" error
2020-04-14 09:44:07 +02:00
Mislav Marohnić
8f3dcb3e22
Merge pull request #780 from cli/setup-go-beta
Avoid intermittent CI failures while setting up Go
2020-04-13 19:27:29 +02:00
Mislav Marohnić
26ee7baf67 💅 indent 2020-04-13 17:16:47 +02:00
Mislav Marohnić
4e393fdab4 Avoid intermittent CI failures while setting up Go
Switch to `actions/setup-go@v2-beta` which advertises better retries
around downloading the Go version
2020-04-13 17:15:59 +02:00
Mislav Marohnić
609beb5596
Merge pull request #778 from cli/bump-spinner
Avoid race conditions when interacting with the spinner
2020-04-13 16:57:03 +02:00
Mislav Marohnić
ea9f89f366 go mod tidy 2020-04-13 16:53:46 +02:00
Mislav Marohnić
3fdae05bcf
Merge pull request #779 from cli/composite-literals-lint
Appease linter that warns about redundant type in composite literals
2020-04-13 16:52:53 +02:00
Mislav Marohnić
f09994dd84 Appease linter that warns about redundant type in composite literals 2020-04-13 15:15:41 +02:00
Mislav Marohnić
aa183d7408 Set spinner writer stream in a preferred way 2020-04-13 14:09:56 +02:00
Mislav Marohnić
0bc631179b Update spinner library to avoid race condition after Stop() 2020-04-13 14:07:16 +02:00
gertd
203525c031 pr bug/rest-204 review feedback 2020-04-10 16:48:11 -07:00
Billy Griffin
971e658b63
Merge pull request #771 from cli/contributers-gonna-contribute
Update contributing doc to reflect something closer to reality
2020-04-10 08:46:05 -06:00
gertd
b9f1b5dac1 fix api.REST(DELETE, ...) json.Unmarshal failure 2020-04-09 22:19:28 -07:00
Nate Smith
c670049ce7
Merge pull request #745 from doi-t/add-metadata-to-view
Add relevant metadata to issue view in CLI
2020-04-09 16:27:07 -05:00
Billy Griffin
8518b8255a
Update contributing to reflect something closer to reality 2020-04-09 13:40:03 -06:00
Mislav Marohnić
d14b5d3e2c
Merge pull request #764 from cli/pr-view-docs
Improve `issue/pr/repo view` documentation
2020-04-09 19:12:34 +02:00
Nate Smith
3c335104c5
Merge pull request #748 from doi-t/add-pr-metadata-to-view
Add relevant metadata to pr view in CLI
2020-04-09 12:12:18 -05:00
Mislav Marohnić
7f9aef6c0d
Merge pull request #761 from cli/completion-fixes
Improve `completion` command
2020-04-09 19:10:36 +02:00
Toshiya Doi
6d0e5bf2b8 Remove Participants related codes for pr view` 2020-04-10 01:02:51 +09:00
Toshiya Doi
054ec3c635 Remove Participants related codes 2020-04-10 00:56:45 +09:00
Toshiya Doi
531bfbc295 Update unit tests for PR metadata 2020-04-08 20:07:19 +09:00
Mislav Marohnić
a6495a8c0d
Merge pull request #733 from michaelld/add_MP_to_readme
add MacPorts usage info
2020-04-08 12:27:30 +02:00
Mislav Marohnić
60e7bb6243
Tweak macOS installation docs 2020-04-08 12:26:15 +02:00
Mislav Marohnić
d1754b2bb0 Improve issue/pr/repo view documentation
- Short-form docs for `pr/repo view` no longer say "in browser"

- Long-form docs for all these commands now list more information about
  what will be displayed in the terminal, plus stressing out the
  alternate behavior with the `--web` flag.

- `--web` flag docs: add English articles
2020-04-08 12:04:39 +02:00
Toshiya Doi
d07617817d Query first 100 issue metadata by PR number and branch (3 --> 100) 2020-04-08 14:53:55 +09:00
Toshiya Doi
542314a9c3 Omit participants metadata from pr view 2020-04-08 14:53:23 +09:00
Toshiya Doi
9169c8d0eb Update unit tests for issue metadata 2020-04-08 14:48:08 +09:00
Toshiya Doi
24fcc69f9e Query first 100 issue metadata by issue number (3 --> 100) 2020-04-08 14:47:46 +09:00
Toshiya Doi
d600709e9e Omit participants metadata from issue view 2020-04-08 13:50:13 +09:00
Mislav Marohnić
2915abc2ba Improve user-friendliness of completion command
When ran directly in the terminal, the command now errors out with:

    $ gh completion
    error: the value for `--shell` is required
    see `gh completion --help` for more information

This is to avoid the previously default bash code output confusing the
user if they ran the command out of curiousity.

A backwards compatibility layer is present here: if stdout is not a
terminal, then output bash code like before. This is to support users
who have already added a line like this to their bash profile:

    eval "$(gh completion)"
2020-04-07 16:58:50 +02:00
Mislav Marohnić
79f749a02b Avoid checking for updates during gh completion
This is due to the fact that `gh completion` can be programatically used
during shell startup and we definitely don't want to
1. slow down people's startup time
2. show any upgrade notice until the user has invoked `gh` manually
2020-04-07 16:46:36 +02:00
Mislav Marohnić
c0c28622bd
Merge pull request #754 from cli/long-from
spell out PR text
2020-04-07 11:13:39 +02:00
Tiernan L
1aba837589
update text to long-form
Change from "repo" to "repository".  Run "gh repo clone -h` to see the usage text I am referring to.

We use the word "repository" here:

Usage:
  gh repo fork [<repository>] [flags]

Usage:
  gh repo view [<repository>] [flags]
2020-04-06 11:27:17 -10:00
Tiernan L
806574f9c1
spell out PR
changes "PR" ---> "pull request" for consistency and clarity
2020-04-06 09:56:45 -10:00
Mislav Marohnić
e878cdf060
Merge pull request #752 from lumaxis/feature/fetch-upstream-after-adding
Fetch upstream remote after adding it

Fixes #731
2020-04-06 19:48:14 +02:00
Toshiya Doi
8fca78f584 Query first 100 requestedReviewer and last 100 reviews 2020-04-06 17:56:51 +09:00
Toshiya Doi
a4fcb634c2 Fix requestedReviewer struct 2020-04-06 17:53:41 +09:00
Lukas Spieß
7e1ed5f9a3
Fetch upstream remote after adding it 2020-04-05 20:54:29 +02:00
Toshiya Doi
f14459c451 Clean up unnecessary fmt.Sprintf 2020-04-04 15:11:57 +09:00
Toshiya Doi
d5bff70259 Clean up unnecessary fmt.Sprintf 2020-04-04 15:09:22 +09:00
Toshiya Doi
92dea433e4 An attempt of collecting reviewers metadata 2020-04-04 13:28:47 +09:00
Toshiya Doi
85d8f808f2 Test pr metadata in CLI preview 2020-04-04 13:14:34 +09:00
Toshiya Doi
0cb6890c74 Print pr metadata in CLI preview 2020-04-04 13:09:34 +09:00
Toshiya Doi
d538f7a1be Query pr metadata by number and branch 2020-04-04 13:08:22 +09:00
Toshiya Doi
125ff06b2c Add metadata to PullRequest struct 2020-04-04 13:07:44 +09:00