Commit graph

6978 commits

Author SHA1 Message Date
Adarsh Jha
351c5f1cd5
feat: modified choice input to take option list opposed to blank text (#8180) 2023-10-31 17:48:49 +01:00
William Martin
ede1705bf2 Ensure good link in triage discussion 2023-10-31 10:02:42 +01:00
William Martin
b2c445f4b9 Ensure variables get passed in discussion triage 2023-10-31 09:58:30 +01:00
William Martin
6782120254 Update discussion triage types to ID 2023-10-31 09:55:29 +01:00
William Martin
4213e3e2b4 Update secret name to not be prefixed with GITHUB
Apparently this isn't allowed
2023-10-31 09:49:46 +01:00
William Martin
09b81ff545
Create private discussion for issues labelled discuss (#8264) 2023-10-31 09:44:31 +01:00
David Gardiner
500f359592
Don't poll for addition codespace permissions if user chooses to create without them (#8267) 2023-10-30 13:22:38 -05:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface (#8246) 2023-10-27 15:42:05 +02:00
dependabot[bot]
ce7d89de0c
build(deps): bump google.golang.org/grpc from 1.53.0 to 1.56.3 (#8251)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.53.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-26 08:44:31 +02:00
Sam Coe
20baccfa85
Add default configuration back from go-gh (#8244) 2023-10-24 13:23:31 +02:00
William Martin
08bc4cbb5e
Merge pull request #8235 from ffalor/issue_8218
clearer error message
2023-10-23 19:12:32 +02:00
ffalor
f4535004c2 clearer error message 2023-10-23 00:39:25 -05:00
Sam Coe
5023b61909
Remove uses of FuzzyAgoAbbr in tables (#8222) 2023-10-22 17:33:49 +02:00
Sam Coe
d70d798ebf
Fix up NoHeaders linter errors in project commands (#8223) 2023-10-20 15:30:13 +02:00
Heath Stewart
7738b6187c
Add headers to all tables (#8157) 2023-10-20 11:20:02 +02:00
William Martin
26f3601a81
Merge pull request #8213 from cli/wm/add-tests-for-existing-config
Add tests for the existing config
2023-10-19 15:59:08 +02:00
William Martin
4fc1999847 Add link to token source issue 2023-10-19 15:39:10 +02:00
Swastik Baranwal
6696229fb1
gh extension install not give an error if extension already installed and a clear message (#8211)
* `gh extension install` not give an error if extension already installed and a clear message

* remove test

* Add implementation

* lint go.sum

---------

Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2023-10-19 15:22:21 +02:00
William Martin
6dc04bb1e2 Remove GetOrDefault uses in favour of GitProtocol 2023-10-19 12:57:19 +02:00
William Martin
7d8c1af009 Fix GitProtocol signature and rework test descriptions 2023-10-19 12:49:38 +02:00
William Martin
b9cbee0462 Remove incorrect comment about HasEnvToken 2023-10-19 12:39:31 +02:00
William Martin
3c3fbcdb66 Remove Login branch that handles empty username 2023-10-19 12:35:43 +02:00
William Martin
aa8848471f Remove Logout branch that handles empty hostname 2023-10-19 12:33:15 +02:00
William Martin
c430da7329 Ensure all AuthConfig tests are isolated on disk 2023-10-19 12:31:41 +02:00
William Martin
c9de817865 Avoid using keyring unnecessarily in AuthConfig tests
This is to avoid the impression that the keyring matters, when the test
is actually about general auth behaviour
2023-10-19 12:26:52 +02:00
William Martin
fa80802c81 Add tests for AuthConfig DefaultHost 2023-10-19 12:24:25 +02:00
William Martin
07f5ca48d8 Share config.Read setup in AuthConfig tests 2023-10-19 12:24:05 +02:00
William Martin
e0bc2ff0ca Add test that host is added on Login 2023-10-19 12:08:03 +02:00
William Martin
cb7672e573 Add additional comment on Logout ignoring errors 2023-10-19 12:05:40 +02:00
William Martin
3380831672 Rewrite AuthConfig User and GitProtocol tests 2023-10-19 12:05:14 +02:00
William Martin
e011633cdc Add tests for AuthConfig HasEnvToken 2023-10-18 18:10:00 +02:00
William Martin
465474ec5b Mod tidy go-md2man 2023-10-18 17:52:00 +02:00
William Martin
07110eca33 Add tests for AuthConfig Token 2023-10-18 17:51:53 +02:00
William Martin
52ba99ebab Update AuthConfig to use default fn 2023-10-18 17:51:41 +02:00
William Martin
614e49296b Add tests for AuthConfig Login and Logout 2023-10-18 17:09:20 +02:00
William Martin
34b0b33f24 Add initial AuthConfig tests 2023-10-18 16:31:13 +02:00
William Martin
5f645eaded Add tests for config GetOrDefault 2023-10-18 16:10:53 +02:00
William Martin
b94f458950 Add initial tests for config Get 2023-10-18 15:51:46 +02:00
dependabot[bot]
1b58241501
build(deps): bump github.com/mattn/go-isatty from 0.0.19 to 0.0.20 (#8205)
Bumps [github.com/mattn/go-isatty](https://github.com/mattn/go-isatty) from 0.0.19 to 0.0.20.
- [Commits](https://github.com/mattn/go-isatty/compare/v0.0.19...v0.0.20)

---
updated-dependencies:
- dependency-name: github.com/mattn/go-isatty
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-18 15:26:14 +02:00
Sam Coe
59e84dd069
Remove crypto fork (#8204) 2023-10-18 11:19:03 +02:00
Mikel Olasagasti Uranga
46a7042b88
Bump cpuguy83/go-md2man from 2.0.1 to 2.0.3 (#8209)
Version 2.0.3 introduces a fix in PR
https://github.com/cpuguy83/go-md2man/pull/105 that breaks a test for
gen-doc, thus requires a small change in the test.
2023-10-18 07:17:20 +00:00
EBIBO
8e8e6d9ac6
gh browse subdirectory path problem with repo flag (#8141) 2023-10-17 09:01:51 +00:00
EBIBO
fd8bbf0be5
gh pr create duplicates targets if there are duplicate remotes (#8184)
* `gh pr create` duplicates targets if there are duplicate remotes

* De-duplicate the same remote
2023-10-17 08:21:35 +00:00
Sam Coe
5916439d22
Remove template field from projects exporting (#8160) 2023-10-17 09:54:12 +02:00
Arun Sathiya
9b037ffac1
update(repo create): Support for --homepage flag for template-based repository creation flow (#8188) 2023-10-17 09:01:32 +02:00
David Gardiner
bc0f63b043
Merge pull request #8179 from dmgardiner25/poll-codespace-permissions
Poll permission acceptance endpoint on codespace creation
2023-10-16 11:42:59 -07:00
David Gardiner
135c56aead Fix linting error 2023-10-16 10:09:04 -07:00
dependabot[bot]
7d558edd12
build(deps): bump github.com/gabriel-vasile/mimetype from 1.4.2 to 1.4.3 (#8185)
Bumps [github.com/gabriel-vasile/mimetype](https://github.com/gabriel-vasile/mimetype) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/gabriel-vasile/mimetype/releases)
- [Commits](https://github.com/gabriel-vasile/mimetype/compare/v1.4.2...v1.4.3)

---
updated-dependencies:
- dependency-name: github.com/gabriel-vasile/mimetype
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-13 17:15:54 +02:00
David Gardiner
a8f8728056 Poll permission acceptance endpoint on codespace creation 2023-10-12 16:55:13 -07:00
David Gardiner
64f4660ec7
Migrate all Codespaces operations from Live Share to Dev Tunnels (#8149)
* Migrate all Codespaces operations from Live Share to Dev Tunnels

* Remove Live Share references

* Fix linting errors

* Update comments, remove deps, add uint16 bound checks

* Fix tests and move keep-alive logic to forwarder

* Address comments

* Updated mock port forwarder

* Fix CodeQL error

* Update comment

* Update func name

* Add missing connection close

* Fix linting error

* https -> http

* Update defer

* Fix tests
2023-10-12 22:16:36 +00:00