Commit graph

2975 commits

Author SHA1 Message Date
vilmibm
509e5dd0c9 fix tests 2021-01-20 16:10:56 -08:00
vilmibm
99c312e8ce accept a remote name instead of doing magic remote naming in repo fork 2021-01-20 15:32:19 -08:00
vilmibm
03f99a0140 Merge remote-tracking branch 'origin/trunk' into remote-renaming-847 2021-01-20 15:10:20 -08:00
Nate Smith
5430728a0a
Merge pull request #2813 from cli/token-from-env-err
More descriptive error when aborting auth due to environment variables
2021-01-20 15:06:52 -08:00
Björn Heinrichs
c9f79271b1
Add --maintainer-edit flag (#2250)
* Add --maintainer-edit flag

Closes #2213 while retaining backwards compatibility.

* Fix linting

* Adjust documentation and validation

* Negate logic and fix build errors

* rename to no-maintainer-edit

* test

* use a positive option instead of negative

Co-authored-by: vilmibm <vilmibm@github.com>
2021-01-20 14:51:27 -08:00
Sam
3bec668aaa
Merge pull request #2757 from cli/review-comments
Display reviews when viewing pull requests
2021-01-20 12:22:03 -08:00
Sam Coe
b9b1079493
Display reviews when viewing pull requests 2021-01-20 12:15:25 -08:00
Mislav Marohnić
dcf5a27f53
Merge pull request #1862 from edualb/trunk
[#1755] SSH key management (gh ssh-key list)
2021-01-20 20:47:21 +01:00
Mislav Marohnić
4a2cc8d2a4 Simplify ssh-key list
Do not require nor request `read:public_key` scope by default.
2021-01-20 20:23:57 +01:00
edualb
e26a1b98a1 add ssh-key command 2021-01-20 20:23:38 +01:00
Cristian Dominguez
2086d135f3
Respect system/user timezone in API requests (#2630)
* Respect system/user timezone in API requests

* Fall back to a known timezone if TZ is not set

Co-authored-by: Cristian Dominguez <cristiand391@users.noreply.github.com>
2021-01-20 10:44:46 -08:00
Mislav Marohnić
c9407b2629 More descriptive error when aborting auth due to environment variables
Old message:

    read-only token in GH_TOKEN cannot be modified

This message was vague and some users did not understand that this
refers to the value that is read from environment variables.

New message:

    $ GH_TOKEN=123 ghd auth login -h github.com
    The value of the GH_TOKEN environment variable is being used for authentication.
    To have GitHub CLI store credentials instead, first clear the value from the environment.
2021-01-20 18:27:35 +01:00
Mislav Marohnić
b5366c6ebf
Merge pull request #2794 from cristiand391/use-testify-assertion
Use Testify assertions in tests
2021-01-19 14:08:25 +01:00
Mislav Marohnić
75ebb863e3 Use testify assertions for error matching 2021-01-19 13:59:37 +01:00
Cristian Dominguez
45f4a1f087 Equal: flip arguments position 2021-01-18 21:00:59 -03:00
Mislav Marohnić
e566c61671
Merge pull request #2789 from dpromanko/dpromanko/2625 2021-01-18 18:41:01 +01:00
Mislav Marohnić
66546e2245 When pr merge --delete-branch flag is supplied, avoid prompting for it 2021-01-18 18:10:20 +01:00
Cristian Dominguez
3afb1d0b1a Use Testify assertions in test 2021-01-16 19:19:30 -03:00
Devon Romanko
df31fae9c6 remove prompt for deleting branches on pr merge in interactive mode when -d flag is passed 2021-01-15 17:34:00 -05:00
Devon Romanko
2c35eb04ff address pr comments 2021-01-15 16:54:46 -05:00
Devon Romanko
85e0e44920 Add prompt to delete local branch when attempting to merge a PR that is already merged 2021-01-15 07:25:24 -05:00
Mislav Marohnić
4750e4ae18
Merge pull request #2774 from rneatherway/codeql-add-pull-request-trigger
Add on: pull_request trigger to CodeQL workflow
2021-01-13 14:40:38 +01:00
Robin Neatherway
3ab01661e4 Add on: pull_request trigger to CodeQL workflow
From February 2021, in order to provide feedback on pull requests, Code Scanning workflows must be configured with both `push` and `pull_request` triggers. This is because Code Scanning compares the results from a pull request against the results for the base branch to tell you only what has changed between the two.

Early in the beta period we supported displaying results on pull requests for workflows with only `push` triggers, but have discontinued support as this proved to be less robust.

See https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#scanning-pull-requests for more information on how best to configure your Code Scanning workflows.
2021-01-13 11:09:00 +00:00
Sam
b0ae09e627
Merge pull request #2535 from cli/create-comments
Create issue comments
2021-01-12 11:24:09 -08:00
Mislav Marohnić
3985577de0
Merge pull request #2759 from cristiand391/migrate-legacy-tests
Migrate legacy HTTP tests
2021-01-12 18:20:45 +01:00
Cristian Dominguez
ce151420f3 Migrate legacy tests 2021-01-11 21:07:19 -03:00
Sam Coe
723e9e31ba
Address PR comments 2021-01-11 13:56:17 -08:00
Mislav Marohnić
c73845ee22
Merge pull request #2742 from cli/linter-update
Simplify linter output setup
2021-01-11 15:32:18 +01:00
Mislav Marohnić
19ee0eff08 Simplify linter output setup
`golangci-lint` now supports an output formatter for GitHub Actions, so
we don't need to manually reformat the failure output anymore.
2021-01-07 16:16:44 +01:00
Mislav Marohnić
5e97775978
Clarify building from source on Windows
Address https://github.com/cli/cli/issues/2545#issuecomment-751842548
2021-01-06 18:08:02 +01:00
Sam Coe
155507d31d
Make comment command easier to test 2021-01-05 15:14:25 -08:00
xhqr
8b5c5896f2
[repo/create] Create local repo dir with non tty. (#2671)
This addresses issue #2587.
2021-01-05 14:40:52 -08:00
Sam Coe
de73b16178
Move CreateComment mutation 2021-01-05 10:39:07 -08:00
Sam Coe
1fc8b66b26
Address PR comments 2021-01-05 10:36:03 -08:00
Sam Coe
f862123071
Modify issue commenting to adhere to designs and add tests 2021-01-05 10:35:09 -08:00
Yuki Osaki
338bf1d112
fix linter issue 2021-01-05 10:35:09 -08:00
Yuki Osaki
8ef2bb4d14
Comment on issues from editor 2021-01-05 10:35:09 -08:00
Mislav Marohnić
86eb264277
Merge pull request #2650 from cli/auth-extract
Extract the oauth package into a separate repo
2021-01-05 16:41:22 +01:00
Mislav Marohnić
536a173364 Enable debugging HTTP traffic during auth login/refresh 2021-01-05 16:24:47 +01:00
Mislav Marohnić
ca83106a38
Merge pull request #2727 from cristiand391/remove-unused-methods
Remove unused methods
2021-01-05 15:33:56 +01:00
Sam
4c53e5eee6
Merge pull request #2698 from camelid/view-newline
view: Add missing newline
2021-01-04 11:20:40 -08:00
Cristian Dominguez
21a57d9253 Remove unused methods 2021-01-04 07:35:41 -03:00
Camelid
8ff4cc40e6 view: Add missing newline
Add a newline at the end of the 'View this {issue, pull request} on
GitHub' message. `gh repo view` already had a newline at the end, so
this only changes `issue view` and `pr view`.
2020-12-27 11:37:59 -08:00
Nate Smith
230441e1a5
Merge pull request #2222 from Crunch09/issue-2115
add `gist clone` command
2020-12-18 13:07:44 -08:00
Mislav Marohnić
9140e88708 Extract oauth package 2020-12-18 20:27:56 +01:00
Mislav Marohnić
f26ad4cce4
Merge pull request #2639 from marmorag/bump-survey
Bump AlecAivazis/survey
2020-12-18 15:10:48 +01:00
marmorag
7415d236bc chore(deps): bump AlecAivazis/survey 2020-12-18 15:01:25 +01:00
Mislav Marohnić
782932bfae
Merge pull request #2636 from cli/docs-completion
Improve `completion` docs for bash, zsh, fish
2020-12-17 18:21:19 +01:00
Mislav Marohnić
3d2d9e7229
Merge pull request #2638 from cli/version-output-fix
Fix link in `version` output
2020-12-17 13:05:47 +01:00
Mislav Marohnić
18b19e074d Fix link in version output
It now correctly links to the tagged release instead of to the latest
release.
2020-12-17 12:37:22 +01:00