Commit graph

606 commits

Author SHA1 Message Date
Nate Smith
55a5d19252 Merge pull request #247 from github/issue-pr-view-docs
Tweak `issue/pr view` documentation
2020-01-23 09:35:38 -06:00
Nate Smith
3764e25921 Merge pull request #248 from github/main-pkg
Move main package to under `cmd/`
2020-01-23 09:34:54 -06:00
Nate Smith
91ab3086a8 Merge pull request #249 from github/issue-pr-argument-docs
Avoid saying "number as argument" for `issue/pr view`
2020-01-23 09:31:18 -06:00
Mislav Marohnić
e81a29c076 Merge pull request #238 from github/pr-create-just-works-TM
Support triangular git workflows in `pr create`
2020-01-23 14:11:17 +01:00
Mislav Marohnić
4f6dfee965 Merge remote-tracking branch 'origin/master' into pr-create-just-works-TM 2020-01-23 14:08:07 +01:00
Mislav Marohnić
f10b8d8095 Add unit tests for remotes-to-repos resolver 2020-01-23 14:05:15 +01:00
Mislav Marohnić
f58dd04074 Avoid saying "number as argument" for issue/pr view
Since issue URLs, PR URLs, and PR branch names are all accepted as arguments,
avoid explicitly requesting "number" as argument.
2020-01-23 13:09:37 +01:00
Mislav Marohnić
537b0a8429 Friendlier output for network connectivity errors
For `net.DNSError`, the full error message can be scary. Instead, print "error
connecting to HOST" and hint that the user should check their internet connection
or githubstatus.com.

When $DEBUG is set, the full DNS error is printed like before.

Fixes #206
2020-01-23 12:48:10 +01:00
Mislav Marohnić
eb6541d8d6 Fix CI build 2020-01-23 11:03:06 +01:00
Mislav Marohnić
6282a3c24e Improve readability of error output
Ensure a blank line between error and usage output
2020-01-23 11:00:23 +01:00
Mislav Marohnić
02f5a68937 Move main package to under cmd/
It's a Go convention that main packages (one per each binary produced) are
scoped under `cmd/`.

https://github.com/github/go-lang/blob/master/docs/style-guide.md#directory-structure-and-filenames-layout
2020-01-23 10:45:28 +01:00
Mislav Marohnić
f5ad43458c Avoid using <...> in docs
When converted to HTML docs, these get interpreted as HTML tags.

In theory, we could encapsulate these bits in backticks, but the docs are
already in raw Go string literals, and we can't easily escape backticks in that
context. Instead, just avoid using `<>` for now.
2020-01-23 10:28:29 +01:00
Mislav Marohnić
305410cdee Fix usage synopsis for pr view
Indicate that the argument is optional
2020-01-23 10:28:26 +01:00
Mislav Marohnić
c8d257cd07 Merge pull request #246 from github/auth-page-restyle
Restyle auth page
2020-01-23 10:24:52 +01:00
Amanda Pinsker
ea09883b07 Restyle auth page 2020-01-22 14:45:31 -08:00
Nate Smith
340f747944 Merge pull request #242 from github/debug-api
Dump HTTP request/response bodies when `DEBUG=api`
2020-01-22 14:05:29 -06:00
Nate Smith
fa56851c19 Merge pull request #240 from github/disabled-issue-preview
check for disabled issues in issue view
2020-01-22 13:15:18 -06:00
vilmibm
8c84fe3e3c just augment existing queries 2020-01-22 12:37:00 -06:00
Mislav Marohnić
0b0fd42ef3 Dump HTTP request/response bodies when DEBUG=api 2020-01-22 19:35:39 +01:00
Mislav Marohnić
6799e7f570 Avoid resetting the current branch when --repo is used
This leads to unwanted consequences in `pr create`
2020-01-22 19:33:53 +01:00
Mislav Marohnić
a767fd7910 Add code comments for tricky parts 2020-01-22 18:37:50 +01:00
Mislav Marohnić
e2a825effb Auto-fork on pr create if no pushable target found 2020-01-22 18:32:06 +01:00
Mislav Marohnić
2aaffc69a2 Clean up obsolete struct 2020-01-21 23:20:50 +01:00
Mislav Marohnić
fa30c16ad5 Fix web-based pr create for forks 2020-01-21 23:20:32 +01:00
Mislav Marohnić
6c49614db7 Fix tests 2020-01-21 22:56:15 +01:00
vilmibm
f09b05e628 test for disabled issues 2020-01-21 15:47:36 -06:00
vilmibm
fc25a4e9ed check for disabled issues in issue view command 2020-01-21 15:37:42 -06:00
Nate Smith
50a89564a7 Merge pull request #237 from github/issue-sort
Better sorting and freshness display for issue status
2020-01-21 14:41:38 -06:00
vilmibm
d7d575fccb support more time units 2020-01-21 14:25:38 -06:00
Mislav Marohnić
7a614ce697 Support triangular git workflows in pr create
- The local git remotes are scanned and resolved to GitHub repositories
- The "base" repo is the first result resolved to its parent repo (if a fork)
- The name of the default branch is read from the base repo
- The "head" repo is the first repo that has push access
2020-01-21 18:26:08 +01:00
vilmibm
a4b97014d1 stray TODO 2020-01-17 16:07:35 -06:00
vilmibm
a297153637 test for utils.FuzzyAgo 2020-01-17 15:57:02 -06:00
vilmibm
bfdf89b579 updated based sorting and fuzzy time display on issue status 2020-01-17 15:38:41 -06:00
Tiernan L
99c17c3a5f Merge pull request #227 from github/typoswap
Typo fixes for Issue/PR preview text
2020-01-16 16:51:02 -08:00
Nate Smith
9e22b9b035 Merge pull request #230 from github/no-fail-fast
Disable cancelling other CI builds after one fails
2020-01-16 14:33:59 -06:00
Nate Smith
84b19a5535 Merge pull request #231 from github/create-flows
PR/Issue create flow tweaks
2020-01-16 14:33:21 -06:00
vilmibm
7aa186fe02 make prompt match mockup more 2020-01-16 14:29:59 -06:00
vilmibm
115cc30a8e rely on iota syntax magic 2020-01-16 14:28:49 -06:00
vilmibm
ffb6b8e29f move survey extension to its own package and clarify 2020-01-16 14:28:40 -06:00
vilmibm
31001877bd hide potentially long query strings when printing urls 2020-01-16 14:18:40 -06:00
vilmibm
beeb35e7e2 clean up body prompt text 2020-01-16 14:03:58 -06:00
vilmibm
1e19b9953a use pluralize helper 2020-01-15 12:39:35 -06:00
vilmibm
32461284cc fix some TODOs 2020-01-15 12:35:28 -06:00
vilmibm
7bbd70d6b2 use default to preserve non-interactive behavior 2020-01-15 11:27:25 -06:00
vilmibm
3468a46521 support preview in browser for issue create 2020-01-15 11:27:12 -06:00
Mislav Marohnić
a3c808e22e Disable cancelling other CI builds after one fails
https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
2020-01-15 12:56:00 +01:00
Mislav Marohnić
d2eb17b150 Fix test after copy changes 2020-01-15 12:53:52 +01:00
vilmibm
d8cbb6a6a7 support previewing PRs in the browser 2020-01-14 17:03:53 -06:00
Tiernan L
96edddc874 PR to pull request 2020-01-14 12:33:48 -10:00
Tiernan L
cf44dcd81b removed terminal mention 2020-01-14 11:27:40 -10:00