Yukai Chou
5612d2864e
Add leftovers
2023-11-17 01:32:29 +08:00
Yukai Chou
8eec3e8040
Wrap path to file in backticks
2023-11-17 01:32:29 +08:00
Yukai Chou
b70c28ba20
Misc docs improvements
2023-11-17 01:32:28 +08:00
Yukai Chou
5c4cb50231
Wrap env variables in backticks uniformly
2023-11-17 01:32:00 +08:00
Yukai Chou
896101678f
Wrap cli commands in backticks uniformly
2023-11-17 01:32:00 +08:00
Yukai Chou
17d336e005
Wrap cli flags in backticks uniformly
2023-11-16 22:54:27 +08:00
Sam Coe
3f37d7e372
Fix query for project item status field ( #8332 )
2023-11-14 17:27:50 +01:00
Qiming Xu
5e14987d65
Fix determining executable location in PATH ( #8238 )
2023-11-14 08:26:19 +00:00
Sam Coe
ebcf3a1022
Set default Accept header for api command when one is not specified ( #8303 )
2023-11-06 15:22:32 +01:00
William Martin
515b85480f
Merge pull request #8301 from cli/wm/minor-annotation-fetch-error-simplification
...
Simplify run view annotation fetch error handling
2023-11-06 13:46:19 +01:00
William Martin
8364301017
Simplify run view annotation fetch error handling
2023-11-06 12:40:13 +01:00
Yukai Chou
ccf45cc7c6
Improve gh release download doc ( #8294 )
...
* Improve `gh release download` doc
When downloading latest release assets,
`gh release download --archive=(zip|tar.gz)` works too.
Sync doc with no-arguments warning.
* Apply suggestion from code review
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
---------
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2023-11-06 07:59:03 +00:00
William Martin
f41f402a20
Merge pull request #8286 from cli/dependabot/go_modules/github.com/henvic/httpretty-0.1.3
...
build(deps): bump github.com/henvic/httpretty from 0.1.2 to 0.1.3
2023-11-03 15:41:48 +01:00
David Gardiner
ecdb557156
Merge pull request #8275 from dmgardiner25/fix-cs-conn-race
...
Resolve race condition in codespaces connection
2023-11-02 09:52:03 -07:00
dependabot[bot]
b0252989eb
build(deps): bump github.com/henvic/httpretty from 0.1.2 to 0.1.3
...
Bumps [github.com/henvic/httpretty](https://github.com/henvic/httpretty ) from 0.1.2 to 0.1.3.
- [Commits](https://github.com/henvic/httpretty/compare/v0.1.2...v0.1.3 )
---
updated-dependencies:
- dependency-name: github.com/henvic/httpretty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-02 14:18:44 +00:00
William Martin
28d3628c5b
Merge pull request #8202 from mattruggio/mattruggio/add-status-column-value-to-project-items
...
Include Project Item Status for Issues and Pull Requests
2023-11-01 17:57:19 +01:00
William Martin
8a9eb7bfc2
Add tests for issue and PR project items query building
2023-11-01 17:40:29 +01:00
Arun Sathiya
5eff7a529a
fix(release create): Handle latest flag value when updating the release after assets are uploaded ( #8207 )
...
Signed-off-by: Arun <arun@arun.blog>
Co-authored-by: William Martin <williammartin@github.com>
2023-11-01 15:17:05 +01:00
dependabot[bot]
534f6d7978
build(deps): bump github.com/creack/pty from 1.1.18 to 1.1.20 ( #8265 )
...
Bumps [github.com/creack/pty](https://github.com/creack/pty ) from 1.1.18 to 1.1.20.
- [Release notes](https://github.com/creack/pty/releases )
- [Commits](https://github.com/creack/pty/compare/v1.1.18...v1.1.20 )
---
updated-dependencies:
- dependency-name: github.com/creack/pty
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Martin <williammartin@github.com>
2023-11-01 10:34:47 +01:00
David Gardiner
d22c6f33e9
Update comment
2023-10-31 13:12:25 -07:00
David Gardiner
d04a9d941f
Lock the Close func
2023-10-31 13:11:28 -07:00
David Gardiner
1bcf92438a
Defer the mutex unlock
2023-10-31 13:08:34 -07:00
David Gardiner
b566ea670c
Add mutex for connect
2023-10-31 13:01:24 -07:00
David Gardiner
581b6652e2
Resolve race condition in codespaces connection
2023-10-31 12:19:14 -07:00
Adarsh Jha
351c5f1cd5
feat: modified choice input to take option list opposed to blank text ( #8180 )
2023-10-31 17:48:49 +01:00
William Martin
ede1705bf2
Ensure good link in triage discussion
2023-10-31 10:02:42 +01:00
William Martin
b2c445f4b9
Ensure variables get passed in discussion triage
2023-10-31 09:58:30 +01:00
William Martin
6782120254
Update discussion triage types to ID
2023-10-31 09:55:29 +01:00
William Martin
4213e3e2b4
Update secret name to not be prefixed with GITHUB
...
Apparently this isn't allowed
2023-10-31 09:49:46 +01:00
William Martin
09b81ff545
Create private discussion for issues labelled discuss ( #8264 )
2023-10-31 09:44:31 +01:00
David Gardiner
500f359592
Don't poll for addition codespace permissions if user chooses to create without them ( #8267 )
2023-10-30 13:22:38 -05:00
Sam Coe
7924878315
Fix git protocol and refactor Config interface ( #8246 )
2023-10-27 15:42:05 +02:00
dependabot[bot]
ce7d89de0c
build(deps): bump google.golang.org/grpc from 1.53.0 to 1.56.3 ( #8251 )
...
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go ) from 1.53.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases )
- [Commits](https://github.com/grpc/grpc-go/compare/v1.53.0...v1.56.3 )
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-26 08:44:31 +02:00
Sam Coe
20baccfa85
Add default configuration back from go-gh ( #8244 )
2023-10-24 13:23:31 +02:00
William Martin
08bc4cbb5e
Merge pull request #8235 from ffalor/issue_8218
...
clearer error message
2023-10-23 19:12:32 +02:00
ffalor
f4535004c2
clearer error message
2023-10-23 00:39:25 -05:00
Sam Coe
5023b61909
Remove uses of FuzzyAgoAbbr in tables ( #8222 )
2023-10-22 17:33:49 +02:00
Sam Coe
d70d798ebf
Fix up NoHeaders linter errors in project commands ( #8223 )
2023-10-20 15:30:13 +02:00
Heath Stewart
7738b6187c
Add headers to all tables ( #8157 )
2023-10-20 11:20:02 +02:00
William Martin
26f3601a81
Merge pull request #8213 from cli/wm/add-tests-for-existing-config
...
Add tests for the existing config
2023-10-19 15:59:08 +02:00
William Martin
4fc1999847
Add link to token source issue
2023-10-19 15:39:10 +02:00
Swastik Baranwal
6696229fb1
gh extension install not give an error if extension already installed and a clear message (#8211 )
...
* `gh extension install` not give an error if extension already installed and a clear message
* remove test
* Add implementation
* lint go.sum
---------
Co-authored-by: Sam Coe <samcoe@users.noreply.github.com>
2023-10-19 15:22:21 +02:00
William Martin
6dc04bb1e2
Remove GetOrDefault uses in favour of GitProtocol
2023-10-19 12:57:19 +02:00
William Martin
7d8c1af009
Fix GitProtocol signature and rework test descriptions
2023-10-19 12:49:38 +02:00
William Martin
b9cbee0462
Remove incorrect comment about HasEnvToken
2023-10-19 12:39:31 +02:00
William Martin
3c3fbcdb66
Remove Login branch that handles empty username
2023-10-19 12:35:43 +02:00
William Martin
aa8848471f
Remove Logout branch that handles empty hostname
2023-10-19 12:33:15 +02:00
William Martin
c430da7329
Ensure all AuthConfig tests are isolated on disk
2023-10-19 12:31:41 +02:00
William Martin
c9de817865
Avoid using keyring unnecessarily in AuthConfig tests
...
This is to avoid the impression that the keyring matters, when the test
is actually about general auth behaviour
2023-10-19 12:26:52 +02:00
William Martin
fa80802c81
Add tests for AuthConfig DefaultHost
2023-10-19 12:24:25 +02:00