Commit graph

241 commits

Author SHA1 Message Date
Jose Garcia
cd6386cf64 Update order 2022-05-05 15:07:29 -04:00
Jose Garcia
ea7d9288e3 Handle star in display name 2022-05-05 08:21:12 -04:00
Jose Garcia
801cd3b282
Merge pull request #5571 from cli/jg/add-display-name
codespaces: add Display Name to the list command
2022-05-04 09:38:27 -04:00
Jose Garcia
7191960694 Add Display Name to the list command 2022-05-03 16:17:53 -04:00
JP Ungaretti
2dd81671a9
Remove empty return 2022-05-03 09:40:07 -07:00
Caleb Brose
55bce59ab7
Add command to open codespaces in JupyterLab
Add command to open codespaces in JupyterLab
2022-04-28 16:11:14 -05:00
JP Ungaretti
3526d25a1e Remove mention of function 2022-04-28 20:55:43 +00:00
JP Ungaretti
8aa132e6c6 Use named return values 2022-04-28 18:42:05 +00:00
JP Ungaretti
ceba2c896b Use safeClose instead of Close 2022-04-28 18:38:46 +00:00
JP Ungaretti
6ddd3360d8 Update auth error message 2022-04-28 18:10:14 +00:00
Håvard Anda Estensen
58cb773e09
Replace ioutil with io and os (#5498) 2022-04-26 13:07:44 +02:00
Roshan Padaki
13342cb272
Don't error on list commands when no results found (#5479)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-25 17:55:52 +00:00
JP Ungaretti
fce69a5350 Add context to errors 2022-04-21 15:03:07 -07:00
JP Ungaretti
f21faca03e Resolve feedback 2022-04-21 14:56:55 -07:00
JP Ungaretti
3216d1bb3a Remove function return 2022-04-21 14:29:30 -07:00
Jeff Hubbard
7678274464
Merge pull request #5076 from cli/multi-devcontainer
Multi devcontainer
2022-04-20 12:06:23 -07:00
Jeff Hubbard
2b57084bd0 PR feedback 2022-04-20 11:52:32 -07:00
JP Ungaretti
4452f37819 Clarify session helper 2022-04-14 17:10:11 -05:00
JP Ungaretti
322fae53b1 Clean up more errors 2022-04-14 16:14:29 -05:00
JP Ungaretti
e8e9b58670 Clean up errors 2022-04-14 16:12:44 -05:00
JP Ungaretti
eaf8f84baf Merge branch 'trunk' into add-cs-jupyter 2022-04-14 15:27:40 -05:00
JP Ungaretti
ee1625add2 Fix -c option 2022-04-14 15:26:06 -05:00
JP Ungaretti
9874d57d62 Print JupyterLab URL 2022-04-14 14:55:40 -05:00
JP Ungaretti
9fd5923b9b Clean up Jupyter code 2022-04-14 14:40:42 -05:00
Jeff Hubbard
9fb6cf5423 Fix tests 2022-04-12 10:26:08 -07:00
Jack Meyer
ce0562c5f2
Add codespace open --web flag (#5380)
Co-authored-by: Luan Vieira <luanzeba@github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-11 19:09:27 +02:00
Jeff Hubbard
de9b5ad8f8
Merge branch 'trunk' into multi-devcontainer 2022-04-08 15:17:33 -07:00
Jake Shorty
6783509d3b
Merge pull request #5410 from cli/codespaces-location-optional
Make location an optional flag when creating codespaces
2022-04-07 10:58:39 -06:00
Jake Shorty
e9ed200c1b
Use proper syntax for location values
Co-authored-by: Mislav Marohnić <mislav@github.com>
2022-04-07 10:49:03 -06:00
Amanda Lin
dc990e38ef
Merge pull request #5409 from cli/adnamalin/timeout-notice
handle IdleTimeoutNotice on gh cs create
2022-04-06 11:23:03 -05:00
Jake Shorty
be7a4ed70b Enumerate available codespace locations for now
We'll probably want to have an intermediate geographical abstraction for these eventually, but this gives parity with the github.com UI.
2022-04-06 15:00:42 +00:00
Amanda Lin
5b10b6e986 use stderr instead and add tests 2022-04-06 09:57:36 -05:00
Jake Shorty
4aca945e2e Drop unused locationResult 2022-04-05 20:27:10 +00:00
Jake Shorty
41719f7624 Location is an optional flag when creating codespaces 2022-04-05 20:19:19 +00:00
Jose Garcia
f6b8bbe982
Merge pull request #5390 from legomushroom/legomushroom/codespaces-add-hidden-select-command
[codespaces]: add hidden select command
2022-04-05 13:37:45 -04:00
Oleg Solomka
e7fb9c0c4d fix linter issues 2022-04-05 10:08:34 -07:00
Amanda Lin
6490f658de handle IdleTimeoutNotice 2022-04-05 10:27:26 -05:00
Oleg Solomka
78573442eb address more PR feedback 2022-04-04 17:13:52 -07:00
Jeff Hubbard
a84e43cadf Final copy and behavior update for prompt 2022-04-04 16:32:38 -07:00
Amanda Lin
371f128871 remove idle timeout flag 2022-04-04 15:15:00 -05:00
Oleg Solomka
d6edc6f8a6 address more PR feedback 2022-04-04 10:53:52 -07:00
Oleg Solomka
b4d29a8b7b address PR feedback 2022-04-04 10:34:04 -07:00
Oleg Solomka
9a0b208200 [select codespace]: cleanup description 2022-04-01 12:30:55 -07:00
Oleg Solomka
07e18ea3d4 [codespace select]: add unit tests for filePath flag, add command description 2022-04-01 11:35:40 -07:00
Jeff Hubbard
ef0672eac0
Merge branch 'trunk' into multi-devcontainer 2022-03-29 13:46:05 -07:00
Mislav Marohnić
3f5311ea1c
Merge pull request #5345 from znull/znull/ssh-config-example
ssh.go: use setup example that should work with any ssh config
2022-03-29 16:15:56 +02:00
Jeff Hubbard
9554e522af Change the way we parse list-devcontainers response 2022-03-28 14:24:57 -07:00
Jeff Hubbard
03b8b16585 Merge branch 'trunk' of ssh://github.com/cli/cli into multi-devcontainer 2022-03-28 13:59:01 -07:00
Jason Lunz
17cb6346a5
ssh.go: use setup example that should work with any ssh config
The `gh cs ssh` command suggests an example recipe for setting up
openssh integration. The last step appends an `Include` statement to the
user's `~/.ssh/config`.

Unfortunately, this won't always work as intended. If the existing
configuration ends with a `Host` block, the added `Include` statement
will be conditional on whether that block matches.

By preceding the `Include` statement with `Match all`, we can ensure
that it is always evaluated.
2022-03-23 17:00:36 -06:00
Caleb Brose
623e67f6b1 Update comments/usage and remove -- 2022-03-23 16:09:07 +00:00