Commit graph

8409 commits

Author SHA1 Message Date
Meredith Lancaster
91edde1acb simplify var creation
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:18 -07:00
Meredith Lancaster
2ced59fba3 update integration test scripts
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-11 07:42:05 -07:00
Meredith Lancaster
b6c2b4ff2a try nesting scripts
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 11:58:23 -07:00
Meredith Lancaster
050f295b37 run all tests in a single script
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 11:41:15 -07:00
Meredith Lancaster
0e15557000 windows for loop syntax
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 10:18:15 -07:00
Meredith Lancaster
9ff3370ff7 use replaceAll
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:52:56 -07:00
Meredith Lancaster
98a81ffe0f update expected file path on windows
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 09:47:15 -07:00
Meredith Lancaster
9f6d18c70e run integration tests with windows specific syntax
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 08:37:32 -07:00
Meredith Lancaster
fb7f2bfea2 Merge branch 'trunk' into gh-attestation-download-windows-bug 2024-12-10 08:25:31 -07:00
Meredith Lancaster
351592d90f run all attestation cmd integration tests automatically
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-10 08:24:01 -07:00
Meredith Lancaster
23a3c18d56
Merge pull request #10020 from malancas/attestation-fetch-integration-tests 2024-12-10 07:56:57 -07:00
Meredith Lancaster
e97d01f265 use different file name for attestation files on windows
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-09 17:32:55 -07:00
William Martin
46bba45fac
Merge pull request #9712 from heaths/issue8979
Open PR against gh-merge-base
2024-12-09 13:23:22 +01:00
William Martin
54a7f4de70 Revert "Confirm auto-detected base branch"
This reverts commit e021a07285.
2024-12-09 13:01:00 +01:00
Heath Stewart
e021a07285
Confirm auto-detected base branch
If interactive, confirm the automatically configured gh-merge-branch or, if not configured, the default branch.

Based on PR feedback.
2024-12-08 22:27:00 -08:00
Heath Stewart
5da86e07e7
Merge changes from #10004
Merges changes from @williammartin including acceptance tests and word changes.

Co-authored-by: William Martin <williammartin@github.com>
2024-12-08 20:34:21 -08:00
Heath Stewart
88b96f411c
Set gh-merge-base from issue develop 2024-12-08 17:40:03 -08:00
Heath Stewart
3d139019f8
Open PR against gh-merge-base
Partly resolves issue #8979 by checking for a `gh-merge-base` branch tag and using that as though it were passed to `gh pr create --base`.
2024-12-08 17:40:00 -08:00
Kynan Ware
481a9dd5ad
Merge pull request #10025 from ankddev/update-browse-docs
docs: improve docs for browse command as of #5352
2024-12-06 10:53:08 -07:00
ANKDDEV
a4923de755
docs: update description of command
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 20:43:54 +03:00
ANKDDEV
0653a5a09c
style: reformat files 2024-12-06 20:04:15 +03:00
ANKDDEV
0e5f26449d
docs: update sentence case
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2024-12-06 19:38:26 +03:00
Meredith Lancaster
67798b06c0 use github owned oci image
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-06 08:32:16 -07:00
ANKDDEV
694e209142
docs: improve help for browse command
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-12-06 16:33:57 +03:00
ANKDDEV
3e647385f7
docs: improve docs for browse command as of #5352 2024-12-06 13:45:22 +03:00
Andy Feller
d60e5ffba3
Merge pull request #10016 from cli/andyfeller/cli-cli-10013-pr-checks-json-watch-mutex
Error for mutually exclusive json and watch flags
2024-12-05 12:22:24 -05:00
Meredith Lancaster
7e69c0d4ab fix package reference
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 10:06:26 -07:00
Meredith Lancaster
006ed7b5b5 add gh attestation verify integration test for oci bundles
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 10:02:01 -07:00
Meredith Lancaster
2b7c6f6a16 add integration test for bundle-from-oci option
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:58:27 -07:00
Andy Feller
acfdae466e
Merge pull request #10009 from cli/wm/safepaths
Use safepaths for run download
2024-12-05 11:43:10 -05:00
Meredith Lancaster
90dfefbefb
Merge pull request #10019 from malancas/gh-attestation-oci-attestations-bug
Fix bug when fetching bundles from OCI registry
2024-12-05 09:41:56 -07:00
Meredith Lancaster
2137a483de include alg with digest when fetching bundles from OCI
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-12-05 09:27:14 -07:00
Andy Feller
c9ecf310b3 Error for mutually exclusive json and watch flags
Closes #10013

This commit enhances `gh pr checks` to exit with an error when mutually exclusive `--json` and `--watch` flags are used.  Users are encouraged to either 1) retrieve information about the checks via `--json` or 2) watch and wait on PR checks that are being updated.
2024-12-05 10:23:13 -05:00
William Martin
9bd8f09774 Use safepaths for run download 2024-12-04 22:12:58 +01:00
Andy Feller
179f0c479e
Merge pull request #10006 from cli/10005-fix-flaky-run-download-test
Use consistent slice ordering in run download tests
2024-12-04 08:13:20 -05:00
William Martin
a47b4c9f1d Use consistent slice ordering in run download tests 2024-12-04 13:02:25 +01:00
Tyler McGoffin
1136764c36
Merge commit from fork
The fix
2024-12-03 15:12:05 -08:00
Andy Feller
8720479b0b Consolidate logic for isolating artifacts 2024-12-03 13:33:00 -05:00
William Martin
7c241cf4e6
Merge pull request #9992 from cli/wm/fix-pr-checkout-panic
Fix PR checkout panic when base repo is not in remotes
2024-12-03 14:04:32 +01:00
William Martin
694e565384 Fix PR checkout panic when base repo is not in remotes 2024-12-02 17:20:57 +01:00
Andy Feller
5a74934d19
Merge pull request #9983 from timrogers/timrogers/fork-rename
When renaming an existing remote as part of remote creation in `gh repo fork`, log the change
2024-12-02 10:30:03 -05:00
Kynan Ware
67df4a39fe
Merge pull request #9976 from cli/kw/Improve-DNF-version-clarity-in-install-steps
Clarify which commands correspond to which DNF version under Linux install instructions
2024-12-02 06:08:47 -07:00
William Martin
8d8ac515d0
Merge pull request #9942 from cli/dependabot/go_modules/github.com/gabriel-vasile/mimetype-1.4.7
Bump github.com/gabriel-vasile/mimetype from 1.4.6 to 1.4.7
2024-12-02 14:03:25 +01:00
Tim Rogers
c719d920c3
When renaming an existing remote in gh repo fork, log the change
When running `gh repo fork` in the context of an existing repo, the CLI offers to create a remote for the fork:

```
? Would you like to add a remote for the fork? Yes
```

If you accept, it prints a log stating that the `origin` remote has been created:

```
✓ Added remote origin
```

Where there is an existing `origin` remote, this is renamed to `upstream`, but this is done silently without any notification to the user.

```bash
$ git remote -v
origin	https://github.com/timrogers/badger.github.io.git (fetch)
origin	https://github.com/timrogers/badger.github.io.git (push)
upstream	https://github.com/badger/badger.github.io.git (fetch)
upstream	https://github.com/badger/badger.github.io.git (push)
```

It seems kinda fine to rename the remote without explicitly confirming since this is not a truly destructive action, but it should make it clear what it is doing.

This updates the logging to explicitly log about the renaming of
the existing remote:

```
✓ Renamed remote origin to upstream
```

Fixes #9982.
2024-11-30 21:19:55 +00:00
Kynan Ware
4f4602a682 Improve DNF version clarity in install steps 2024-11-29 16:34:41 -07:00
Andy Feller
9983939d53
Merge pull request #9969 from cli/kw/fix-formatting-for-linter-git-client_test.go
Fix formatting in `git/client_test.go` comments for linter
2024-11-27 16:32:02 -05:00
bagtoad
76f1553fb9 Fix formatting in client_test.go comments for linter 2024-11-27 14:19:27 -07:00
Andy Feller
1fe14c956d
Merge commit from fork
Use only one pattern for credential helper matching
2024-11-27 15:57:08 -05:00
Andy Feller
c94def8b51 Bump cli/go-gh for codespace fix 2024-11-27 15:54:38 -05:00
William Martin
ec086a021b
Update git/client_test.go
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-11-27 15:51:44 +01:00