Commit graph

10048 commits

Author SHA1 Message Date
Melissa Xie
926e29392e
Merge pull request #11592 from luxass/cache-delete-with-ref
feat: add support for `--ref` in `gh cache delete`
2025-09-03 08:04:55 -07:00
Kyle Kelly
ade581679c
Merge pull request #11652 from cli/jkylekelly/trustroot-doc
Remove mention of public preview in trustedroot.go
2025-09-02 16:59:56 -07:00
Kyle Kelly
30994ddc5b Remove mention of public preview in trustedroot.go 2025-09-02 23:42:03 +00:00
Babak K. Shandiz
08e4aa892e
test(cache delete): combine test cases for invalid/non-existent refs
Also note that the API never returns HTTP 422 for invalid refs.

Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 11:07:49 +01:00
Babak K. Shandiz
d1a404a060
test(cache delete): replace HTTP 204 with 200 to match API behaviour
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 11:06:58 +01:00
Babak K. Shandiz
02d50700b5
docs(cache delete): explain different API responses
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 11:05:28 +01:00
Babak K. Shandiz
d457a1bce0
test(cache delete): add test case for key arg and --all
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 10:12:19 +01:00
Babak K. Shandiz
2dd54ae921
refactor(cache delete): simplify error handling
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 10:08:04 +01:00
Babak K. Shandiz
842d3449b4
refactor(cache delete): simplify condition
Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-08-28 10:02:03 +01:00
Lucas
926327ce6d
fix(cache): validate --ref flag usage with cache ID
* Ensure that the `--ref` flag cannot be used in conjunction with a cache ID.
* Update error handling to provide clear feedback when this condition is violated.
* Add tests to cover scenarios involving the `--ref` flag and cache ID.
2025-08-27 19:54:19 +02:00
Lucas
1a19918581
fix(cache): prevent using --ref flag with cache ID
* Added validation to ensure that the `--ref` flag cannot be used when a cache ID is provided.
* Updated error message to include the reference when a cache is not found with the specified `--ref`.
2025-08-27 19:38:01 +02:00
Lucas
5c292286cf
refactor(cache): extract cache ID parsing logic
* Replaced direct conversion of cache ID string to int with a dedicated `parseCacheID` function.
* Improved readability and maintainability of the `deleteCaches` function.
2025-08-27 19:37:39 +02:00
Lucas
047326fcb4
fix(cache): update error message for missing cache key with --ref flag
* Changed the error message from "--ref cannot be used without cache key/ID" to "must provide a cache key" for clarity.
* Updated corresponding test case to reflect the new error message.
2025-08-27 04:56:48 +02:00
Lucas
3ba82b58a9
chore(cache): improve help text for --ref flag in cache deletion
* Clarified the description of the `--ref` flag to specify its purpose more accurately.
* Ensures users understand that it narrows down deletion by cache key and ref.
2025-08-27 04:56:48 +02:00
Lucas
bfb1354e51
test(cache): add tests for --ref flag in cache deletion
* Implemented test cases for handling the `--ref` flag in cache deletion commands.
* Added validation for using `--ref` with cache key and ID.
* Ensured proper error messages are returned for invalid usage of `--ref`.
2025-08-27 04:56:48 +02:00
Lucas
aff2bfaa5c
feat(cache): add support for --ref flag in cache deletion
- Introduced `--ref` flag to narrow down cache deletion to a specific branch or PR reference.
- Updated command examples to include usage of `--ref`.
- Added validation to ensure `--ref` cannot be used with `--all` and must accompany a cache key/ID.
2025-08-27 04:56:46 +02:00
minxinyi
21b08bdd20
refactor: use slices.Equal to simplify code (#11364)
Signed-off-by: minxinyi <minxinyi6@outlook.com>
2025-08-26 15:29:19 -06:00
Andrey
4e1318eb2a
feat: gh auth Automatically copy one-time OAuth code to clipboard (#11518)
* feat: add ability to copy one-time OAuth code while authenticating

Signed-off-by: Andrey <andrekabatareika@gmail.com>

* fix(docs): wrong example for gh auth refresh

* chore(authflow): update message to include one-time code to it

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* chore(authflow): improve message when copied one-time code

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* chore(authflow): don't early return error when could not copy OAuth code

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* refactor(authflow): make code for working with OAuth code more readable

* Adjust language in `gh auth` help for clipboard

---------

Signed-off-by: Andrey <andrekabatareika@gmail.com>
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-08-25 09:52:51 -06:00
Andrey
204536cdd0
docs(release create): difference --generate-notes and --notes-from-tag (#11534)
* docs(release create): distinguish difference between '--generate-notes' and '--notes-from-tag'

Signed-off-by: Andrey <andrekabatareika@gmail.com>

* Clarify release notes behavior for unannotated tags

Updated help text to specify that if a git tag is not annotated, the release notes will use the commit message instead of the tag annotation.

---------

Signed-off-by: Andrey <andrekabatareika@gmail.com>
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-08-25 15:20:21 +00:00
Andrey
89512590ad
Add --force flag to gh run cancel (#11513)
* feat: add --force flag to run cancel command

Signed-off-by: Andrey <andrekabatareika@gmail.com>

* docs: use less prescriptive docs for --force flag

Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>

* chore: remove short flag

Signed-off-by: Andrey <andrekabatareika@gmail.com>

---------

Signed-off-by: Andrey <andrekabatareika@gmail.com>
Co-authored-by: Kynan Ware <47394200+BagToad@users.noreply.github.com>
2025-08-21 12:45:12 -06:00
Kynan Ware
d43d7a1bdd
Update third-party license versions (#11557)
Bump several dependency versions in third-party-licenses files for Darwin, Linux, and Windows platforms to reflect updated packages and license links.
2025-08-21 17:45:56 +00:00
dependabot[bot]
6d183488cc
chore(deps): bump github.com/go-viper/mapstructure/v2 (#11556)
Bumps [github.com/go-viper/mapstructure/v2](https://github.com/go-viper/mapstructure) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/go-viper/mapstructure/releases)
- [Changelog](https://github.com/go-viper/mapstructure/blob/main/CHANGELOG.md)
- [Commits](https://github.com/go-viper/mapstructure/compare/v2.3.0...v2.4.0)

---
updated-dependencies:
- dependency-name: github.com/go-viper/mapstructure/v2
  dependency-version: 2.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-08-21 11:09:59 -06:00
Copilot
5eddf8d523
Merge pull request #11536 from cli/copilot/fix-11535
Fix `gh repo delete --yes` safety issue when no repository argument provided
2025-08-20 11:03:44 -06:00
Kynan Ware
f0f9987584
Merge pull request #11537 from cli/dependabot/go_modules/github.com/cli/go-gh/v2-2.12.2
chore(deps): bump github.com/cli/go-gh/v2 from 2.12.1 to 2.12.2
2025-08-19 15:35:51 -06:00
dependabot[bot]
4fad0b42bc
chore(deps): bump github.com/cli/go-gh/v2 from 2.12.1 to 2.12.2
Bumps [github.com/cli/go-gh/v2](https://github.com/cli/go-gh) from 2.12.1 to 2.12.2.
- [Release notes](https://github.com/cli/go-gh/releases)
- [Commits](https://github.com/cli/go-gh/compare/v2.12.1...v2.12.2)

---
updated-dependencies:
- dependency-name: github.com/cli/go-gh/v2
  dependency-version: 2.12.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-19 21:21:19 +00:00
Andy Feller
9ae764b9fa
Merge pull request #11514 from cli/github-cli-937-v1-project-ghes-deprecation
Ensure users can see v2 projects when viewing issues and PRs, avoid v1 projects on GHES 3.17 and newer
2025-08-18 16:15:54 -04:00
Eugene
5ae174b6b3
Merge pull request #11511 from cli/eugene/trusted_root_flag_for_release_verify
Hidden trusted root flag for release verify
2025-08-15 16:58:19 -04:00
Kynan Ware
f64892474f
Merge pull request #11510 from cli/kw/upgrade-grpc-batch
Bump google.golang.org/grpc & other required dependencies
2025-08-15 09:44:58 -06:00
Andy Feller
4a2abf79b7
Merge pull request #11497 from cli/11409-pr-view-v2-projects
View v2 projects in `gh pr view` output
2025-08-15 08:07:36 -04:00
Andy Feller
8873d1b6a7
Merge pull request #11496 from cli/10708-issue-view-v2-projects
Display v2 projects in `gh issue view`
2025-08-15 08:06:22 -04:00
Kynan Ware
1dadf98148
Merge branch 'github-cli-937-v1-project-ghes-deprecation' into 11409-pr-view-v2-projects 2025-08-14 15:31:27 -06:00
Kynan Ware
17ce7893a7
Merge branch 'github-cli-937-v1-project-ghes-deprecation' into 10708-issue-view-v2-projects 2025-08-14 15:21:26 -06:00
Eugene
7316ddc57d
Update pkg/cmd/release/verify/verify.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-14 16:08:44 -04:00
Eugene
e23c9d087d
Update pkg/cmd/release/verify-asset/verify_asset.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-08-14 16:08:37 -04:00
Eugene
38a00b8976
Merge pull request #11481 from cli/eugene/test-for-release-FetchRefSHA
add test for FetchRefSHA
2025-08-14 15:31:35 -04:00
ejahnGithub
79888378d8 Hidden trusted root flag for release verify 2025-08-14 14:00:55 -04:00
Kynan Ware
f781d90ebc Update Go dependencies to latest versions
Bump several dependencies in go.mod and go.sum, including golang.org/x/crypto, golang.org/x/net, golang.org/x/sys, golang.org/x/term, golang.org/x/text, golang.org/x/tools, google.golang.org/protobuf, google.golang.org/genproto/googleapis/rpc, and github.com/GoogleCloudPlatform/grpc-gcp-go/grpcgcp. This keeps the project up to date with the latest bug fixes and improvements.
2025-08-14 10:15:54 -06:00
Kynan Ware
6fa003543b
Merge pull request #11368 from cli/dependabot/go_modules/github.com/yuin/goldmark-1.7.13
chore(deps): bump github.com/yuin/goldmark from 1.7.12 to 1.7.13
2025-08-14 09:49:04 -06:00
Kynan Ware
1da55e90f3
Merge pull request #11490 from cli/dependabot/github_actions/actions/checkout-5
chore(deps): bump actions/checkout from 4 to 5
2025-08-14 09:45:42 -06:00
dependabot[bot]
6710bbc2be
chore(deps): bump actions/checkout from 4 to 5
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-14 15:35:09 +00:00
Kynan Ware
245484cc51
Merge pull request #11458 from cli/dependabot/github_actions/actions/download-artifact-5
chore(deps): bump actions/download-artifact from 4 to 5
2025-08-14 09:33:54 -06:00
Eugene
a45107f6b4
Merge branch 'trunk' into eugene/test-for-release-FetchRefSHA 2025-08-14 11:20:48 -04:00
Andy Feller
8699d8596f
Merge pull request #11491 from cli/andyfeller/10716-project-featuredetection-api-version
Report that v1 classic projects are detected on GHES 3.16.x or older
2025-08-14 09:46:36 -04:00
ejahnGithub
c4d14044c7 udpate the test 2025-08-13 14:42:50 -04:00
ejahnGithub
2d9cf84690 replace /git/refs/tags/ to /git/ref/tags/ 2025-08-13 11:23:06 -04:00
Andy Feller
d10251211c
Update feature_detection.go 2025-08-12 21:18:47 -04:00
Andy Feller
746da6de00 Update PR tests for v2 projects 2025-08-12 21:13:18 -04:00
Andy Feller
72f5fbbec0 Base changes for PR project items 2025-08-12 20:59:50 -04:00
Andy Feller
7851c9c664 Update gh issue view to show v2 projects
These changes enhance the existing `gh issue view` experience by listing v2 projects in interactive and non-interactive forms.

Additionally, the tests have been enhanced to use a more standard `httpStubs` approach from other tests.
2025-08-12 16:18:45 -04:00
Kynan Ware
1b083c2005
Merge pull request #11482 from cli/kw/fix-govulncheck-sarif-upload
Update govulncheck workflow to scan source code
2025-08-11 15:18:55 -06:00