Meredith Lancaster
92c623ab54
var naming
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:38:09 -07:00
Meredith Lancaster
a326f5cb18
drop table view
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:36:51 -07:00
Meredith Lancaster
c9be8ce7b9
Merge branch 'print-policy-info' of github.com:malancas/cli into print-policy-info
2024-11-26 13:35:24 -07:00
Meredith Lancaster
645d7501f0
order policy info so relevant info is printed next to each other
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-26 13:35:19 -07:00
Meredith Lancaster
ab3f368dd1
Merge branch 'trunk' into print-policy-info
2024-11-26 09:01:39 -07:00
Andy Feller
b133f9cce0
Merge pull request #9791 from cli/kw/cli-9773-informative-message-for-workflow-scope
...
Print friendly error when `release create` fails due to missing `workflow` OAuth scope
2024-11-26 08:30:59 -05:00
Meredith Lancaster
c7d3e6daeb
Update pkg/cmd/attestation/verification/policy.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-25 14:50:16 -07:00
Meredith Lancaster
4b83d8e73b
Update pkg/cmd/attestation/verification/policy.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-25 14:49:56 -07:00
Meredith Lancaster
241bb2edd1
Update pkg/cmd/attestation/verification/policy.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-25 14:49:44 -07:00
bagtoad
deb34d6456
Refactor error handling for missing "workflow" scope in createRelease
2024-11-23 16:59:49 -07:00
bagtoad
11dc6df88b
ScopesResponder wraps StatusScopesResponder
2024-11-23 13:19:45 -07:00
Kynan Ware
a4f96d29e3
Refactor workflow scope checking
...
Refactor the logic for checking `workflow` scope checking in releases to be in the positive - check if the scope is there, not check if it isn't there. Then, when the function is called we invert it.
Also update comments to be more imperative.
This refactor also incorporates @andyfeller's suggestion to use `slices`.
Co-Authored-By: Andy Feller <andyfeller@github.com>
2024-11-23 13:17:09 -07:00
Kynan Ware
ae87caf8d6
Merge pull request #9948 from cli/kw/use-heredoc-for-several-command-docs
...
Fix some multiline command documentation to use `heredoc` strings
2024-11-22 10:11:32 -07:00
Meredith Lancaster
862786cca6
Merge branch 'trunk' into print-policy-info
2024-11-22 09:10:19 -07:00
Phill MV
f84c1c6f51
Merge pull request #9937 from malancas/verify-result-processing
...
Update verification results printing
2024-11-22 10:54:34 -05:00
Meredith Lancaster
f92d703554
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 15:40:15 -07:00
Meredith Lancaster
0fd09eb5ff
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 15:30:41 -07:00
Meredith Lancaster
fed3c8142c
Update pkg/cmd/attestation/verify/attestation_integration_test.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-21 15:20:44 -07:00
Kynan Ware
74f13a9b4f
Apply suggestions from code review
...
Co-authored-by: Andy Feller <andyfeller@github.com>
2024-11-21 13:55:35 -07:00
bagtoad
677ed2cdcf
Refactor command documentation to use heredoc
2024-11-21 13:23:03 -07:00
Meredith Lancaster
27a268cf17
Merge branch 'trunk' into verify-result-processing
2024-11-21 10:07:03 -07:00
Meredith Lancaster
2d41225dd5
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 09:11:18 -07:00
Meredith Lancaster
28565dc1f8
remove unused test file
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 08:58:55 -07:00
Meredith Lancaster
7a271b008a
undo change
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 08:58:23 -07:00
Meredith Lancaster
4d277df559
add more testing testing fixtures
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-21 08:43:21 -07:00
Meredith Lancaster
19afe453c7
update test with new test bundle
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 14:53:02 -07:00
Meredith Lancaster
5601149c83
naming
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 13:34:40 -07:00
Meredith Lancaster
ff8844a308
update test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 13:22:55 -07:00
Tyler McGoffin
1ec23f698f
Merge pull request #9938 from daliusd/base-ref-oid
...
Adding option to return `baseRefOid` in `pr view`
2024-11-20 12:08:40 -08:00
Meredith Lancaster
4671b8d66b
update test
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 12:46:06 -07:00
Meredith Lancaster
a170c91c6d
experiment with table output
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-20 09:04:42 -07:00
Andy Feller
984bfdc38d
Merge pull request #9936 from kommendorkapten/manual-verification
...
Added a section on manual verification of the relases.
2024-11-20 10:36:08 -05:00
Andy Feller
78260967f9
Fix README.md code block formatting
2024-11-20 10:26:00 -05:00
Meredith Lancaster
3e6861e7e1
clean up
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 16:28:36 -07:00
Meredith Lancaster
b5788f2523
wrap sigstore and cert ext verification into a single function
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 16:24:17 -07:00
Dalius Dobravolskas
9414930b5d
Adding option to return baseRefOid in pr view
...
You need to know exact `baseRefOid` so you could show correct diff.
`baseRefName` is not enough sometimes because branch from which PR was
forked might have changes already.
Example usage:
```
gh pr view --json headRefName,headRefOid,number,baseRefName,baseRefOid,reviewDecision
```
2024-11-19 23:50:45 +02:00
Meredith Lancaster
f48e6b56e3
verify cert extensions function should return filtered result list
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 14:38:28 -07:00
Meredith Lancaster
08a66f5383
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-19 14:26:15 -07:00
Fredrik Skogman
0cc4846239
Merge branch 'trunk' into manual-verification
2024-11-19 13:25:11 +01:00
Meredith Lancaster
a55f9a6301
Merge branch 'trunk' into print-policy-info
2024-11-18 13:57:34 -07:00
Meredith Lancaster
9177b22a21
Merge pull request #9892 from malancas/refactor-fetch-attestations
...
Refactor the `getAttestations` functions
2024-11-18 13:56:46 -07:00
Meredith Lancaster
b787a8b785
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 13:39:06 -07:00
Meredith Lancaster
a89071c30d
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:25:57 -07:00
Meredith Lancaster
cfbc1c7e10
wording
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 12:16:12 -07:00
Meredith Lancaster
6ca5e6f18c
add newlines for additional policy info
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 11:42:39 -07:00
Meredith Lancaster
63f37eb369
pr feedback
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:24:25 -07:00
Meredith Lancaster
30ae1388e4
Update pkg/cmd/attestation/download/download.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:19:41 -07:00
Meredith Lancaster
762e99d151
fix function param calls
...
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-11-18 08:19:07 -07:00
Meredith Lancaster
c518a3b1f5
Update pkg/cmd/attestation/verification/extensions.go
...
Co-authored-by: Phill MV <phillmv@github.com>
2024-11-18 08:18:04 -07:00
Fredrik Skogman
075691b03e
Formatting fix
...
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
2024-11-18 15:17:34 +01:00
