Commit graph

9541 commits

Author SHA1 Message Date
Kynan Ware
999ffbdfe7
Merge pull request #10960 from cli/kw/gh-cli-901-910-assign-actors-to-issues
`gh issue edit`: actors are assignable to issues
2025-05-15 09:24:32 -06:00
Kynan Ware
bcd47f1fb1 fix(api): correct var name capitalization 2025-05-15 09:13:46 -06:00
Kynan Ware
ea85b92b35
refactor(api): remove needless parenthesis
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 09:09:36 -06:00
Kynan Ware
da40e08746
doc(api): code comment typo
Co-authored-by: Andy Feller <andyfeller@github.com>
2025-05-15 08:33:30 -06:00
Kynan Ware
5dc854c75e doc(issue edit): clarify synchronous handling of assignees 2025-05-14 11:50:11 -06:00
Kynan Ware
08cd1dc7db feat(issue edit): replacing actor assignee is done synchronously with updateIssue 2025-05-14 11:43:29 -06:00
Kynan Ware
712eeabd4a doc(api): remove needless comment 2025-05-14 08:55:55 -06:00
Kynan Ware
dfd600713f refactor(api): rename assignable user types and methods 2025-05-14 08:53:47 -06:00
Kynan Ware
1e5c3c7426 fix(issue edit): revert rename of ActorAssignees 2025-05-13 13:02:20 -06:00
Kynan Ware
21bd797c6c fix(issue edit): use double quotes for assignedActors 2025-05-13 11:45:40 -06:00
Kynan Ware
261297f0a2 refactor(issue edit): add assignedActors to lookupFields 2025-05-13 07:28:42 -06:00
Kynan Ware
3bed77836a refactor(issue edit): rename loop variable for clarity 2025-05-13 07:11:24 -06:00
Kynan Ware
35792827ad refactor(issue edit): rename AssignedActors to ActorAssignees 2025-05-13 07:09:04 -06:00
Kynan Ware
cff2fa71e2 doc(repo queries): clarify reviewer actor fetching logic 2025-05-12 11:49:44 -06:00
Kynan Ware
73e5589059 doc(issue): comment why assignable actors disabled 2025-05-12 11:37:37 -06:00
Kynan Ware
29241cb7a5 refactor(issue edit): improve actor type handling
This improves actor type handling while fetching repository assignable actors.
2025-05-12 11:34:31 -06:00
Kynan Ware
218152f7c5 fix(issue edit): resolve race condition in actor assignment 2025-05-09 23:26:06 -06:00
Kynan Ware
e0afc91fef chore(issue edit): comments cleanup 2025-05-09 23:02:15 -06:00
Kynan Ware
0efdfed068 feat(issue edit): support assigning actors to issues 2025-05-09 22:56:09 -06:00
Kynan Ware
ee9d169204 feat(issue edit): fetch assignable actors 2025-05-09 15:13:11 -06:00
Kynan Ware
38e52db377 feat(issue edit): fetch currently assigned actors 2025-05-09 15:12:07 -06:00
Andy Feller
7ceca4534d
Merge pull request #10937 from cli/kw/accessible-prompter-prints-readable-defaults-in-prompt
Accessible prompter always displays defaults in speech synthesis readable format
2025-05-09 08:48:10 -04:00
Babak K. Shandiz
90532e8377
Improve assertion for disabled echo mode (#10927)
* Improve assertion for disabled echo

Signed-off-by: Babak K. Shandiz <babakks@github.com>

* Use `expect.RegExpPattern`

Signed-off-by: Babak K. Shandiz <babakks@github.com>

---------

Signed-off-by: Babak K. Shandiz <babakks@github.com>
2025-05-08 21:26:02 +01:00
William Martin
e5f7a453df
Merge pull request #10942 from cli/wm/projectsv1-deprecation-pr-edit
Feature detect v1 projects on pr edit
2025-05-08 15:53:21 +02:00
Kynan Ware
9b89a0ac0e fix(a11y prompter): remove invalid defaults 2025-05-08 07:41:36 -06:00
William Martin
202a4f3c5a
Merge pull request #10947 from cli/gitulisca/handling-download-of-unpublished-release
Handle missing archive URLs on release download
2025-05-08 15:03:06 +02:00
Art Leo
89bed45c55 Release download handles missing archive URLs
Co-authored-by: William Martin <williammartin@github.com>
2025-05-08 12:41:12 +02:00
Art Leo
d78980c668 Fix release download test http stubbing
Co-authored-by: William Martin <williammartin@github.com>
2025-05-08 12:15:28 +02:00
Kynan Ware
8ebbd1d4bf feat(fd): add ActorIsAssignable to IssueFeatures 2025-05-07 12:23:18 -06:00
William Martin
55cd3c34cd Feature detect v1 projects on pr edit 2025-05-07 16:17:15 +02:00
Azeem Sajid
ee281fd9ba
Add closedByPullRequestsReferences JSON field to issue view (#10941)
* [gh issue view] Expose `closedByPullRequestsReferences` JSON fields

* Incorporate GitHub Copilot review suggestions

* Incorporate review changes
2025-05-07 13:59:22 +01:00
Kynan Ware
3594f6357b fix(a11y prompter): confirm prompt default is readable 2025-05-06 15:50:57 -06:00
Kynan Ware
04aaaea142 fix(a11y prompter): multi select defaults are readable 2025-05-06 15:43:26 -06:00
Kynan Ware
957667efe6 doc(prompter): remove TODO about default value panic 2025-05-06 15:33:51 -06:00
Kynan Ware
cab906151f fix(a11y prompter): select prompt default value is readable 2025-05-06 15:33:15 -06:00
Kynan Ware
ab4cfb84d2 refactor(a11yprompter): shared method for prompt defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
2ee68411a7 fix(a11y prompter): Select prompt respects defaults 2025-05-06 15:33:15 -06:00
Kynan Ware
9bc2c388da fix(a11y prompter): input prompt default value is readable 2025-05-06 14:34:05 -06:00
Meredith Lancaster
315876852a
Merge pull request #10670 from malancas/move-predicate-type-filtering
Move predicate type filtering in `gh attestation verify`
2025-05-06 11:08:34 -06:00
William Martin
a2fcb9b2df
Merge pull request #10915 from cli/wm/projectsv1-deprecation-pr-create-rest
Feature detect v1 projects on interactive `pr create`
2025-05-06 15:24:04 +02:00
William Martin
4967a5edd5
Merge pull request #10911 from cli/wm/projectsv1-deprecation-pr-web
Feature detect v1 projects on web mode pr create
2025-05-06 14:19:15 +02:00
Meredith Lancaster
e4ef9bcedd
Merge branch 'trunk' into move-predicate-type-filtering 2025-05-05 14:34:00 -06:00
Kynan Ware
d6d8275809
Merge pull request #10918 from cli/kw/fix-accessible-prompter-flaky-test
Fix flakey test for accessible prompter
2025-05-02 14:59:39 -06:00
Kynan Ware
cc673cfaba test(prompter): add timeout before password input 2025-05-02 14:48:07 -06:00
Kynan Ware
7b86830ade
Merge pull request #10729 from nopcoder/trunk
Fix panic on `gh pr view 0`
2025-05-02 09:47:48 -06:00
William Martin
1a5b7ca60c Feature detect v1 projects for preview URL
As far as I can see, when there is project metadata, the preview option
will never be shown in the interactive multiselect, so I don't believe
this change has any functional difference. However, I did use the
opportunity to drive out tests for generateCompareURL
2025-05-02 17:42:23 +02:00
William Martin
5a3aee056a Feature detect v1 projects on interactive pr create 2025-05-02 17:42:23 +02:00
William Martin
5ee70748fa
Merge pull request #10909 from cli/wm-kw/projectsv1-deprecation-pr-create
Feature detect v1 projects on non-interactive pr create
2025-05-02 15:23:11 +02:00
William Martin
9822bb5d07 Feature detect v1 projects on web mode pr create 2025-05-02 15:11:04 +02:00
William Martin
e995a873cb Feature detect v1 projects on non-interactive pr create 2025-05-02 15:08:34 +02:00