Commit graph

102 commits

Author SHA1 Message Date
Benjamin Chadwick
4bbbf46321
Fix browse last commit when using the repo override flag (#4845) 2021-12-13 15:00:22 +01:00
Benjamin Chadwick
c581a093ed
Encode segments of gh browse resulting URL (#4663)
- URLs are now always generated without a trailing slash
- Windows-style paths are normalized before processing
- Special characters in branch names are escaped

Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-11-18 13:10:55 +00:00
Boston Cartwright
dd0edc8fbd
Omit current directory when browse --branch is used with no file argument (#4676) 2021-11-04 15:00:42 +00:00
nate smith
70c78f2aa8 some fixes, streamlining 2021-10-14 17:07:51 -05:00
nate smith
4996ba2ba4 Merge remote-tracking branch 'origin/trunk' into relative-path 2021-10-14 12:24:27 -05:00
nate smith
5bdaab882b fix 2021-10-14 11:25:33 -05:00
nate smith
d72d0f47f6 Merge remote-tracking branch 'origin/trunk' into browse-commit 2021-10-13 16:53:50 -05:00
Andrew Hsu
e13398f6b4
fix browse of markdown files with line ranges (#4310)
Co-authored-by: Mislav Marohnić <mislav@github.com>
2021-09-14 16:08:19 +02:00
Mislav Marohnić
e0fa56dc29 Merge remote-tracking branch 'origin' into go-module-v2 2021-09-02 20:02:16 +02:00
Des Preston
dafd0bfbd1 feat(4248): add support for line range w/ browse
Allow using a range of lines when browsing files. For example:

`gh browse test.go:10-20`

Closes #4248
2021-08-31 16:32:37 -04:00
Mislav Marohnić
11fbb60ae7 Rename the module to "github.com/cli/cli/v2" 2021-08-25 12:41:30 +02:00
bchadwic
5993018679 NEW functionality:
current folder '.', from current folder '.(pathsep)', parent folder '..(path sep)', absolute 'folder | filename'
2021-08-04 15:20:45 -07:00
bchadwic
7ef919d713 NEW functionality: current folder '.', from current folder '.(path sep)', parent folder '..(path sep)', absolute 'folder | filename' 2021-08-04 15:03:30 -07:00
Ben Chadwick
1efc07b183 made tests non os dependant 2021-07-28 22:09:37 -07:00
Ben Chadwick
c8ee9829a7 Revert "fixing mistake"
This reverts commit 5e3ca02198.
2021-07-26 21:55:47 -07:00
bchadwic
5e3ca02198 fixing mistake 2021-07-26 00:37:14 -07:00
bchadwic
aac4c59c31 fixing operating system dependant regex, and tests 2021-07-26 00:22:25 -07:00
bchadwic
8469441464 new functionality: current folder './', parent folder '../', absolute 'filename' 2021-07-25 23:53:27 -07:00
bchadwic
285f8659b3 clean up 2021-07-21 01:11:38 -07:00
bchadwic
8962aeebf9 changed functionality to open up last commit with -c / --commit for gh browse 2021-07-21 01:08:15 -07:00
bchadwic
b3a24d273b cleaned up git.go, browse_test.go, and browse.go 2021-07-16 00:07:04 -07:00
bchadwic
25a35a6e88 added relative path access in gh browse 2021-07-15 23:38:54 -07:00
bchadwic
158a15160d Changed name from SHA to Commit 2021-07-14 01:19:55 -07:00
Benjamin Chadwick
0e18db2b11
Merge branch 'cli:trunk' into browse-commit 2021-07-12 14:26:10 -07:00
nate smith
98d3b7cc79 don't check Fprintf error
we don't ever check the return of Fprintf anywhere else in the codebase
so doing it here suggests that it's a special case. if it's something we
should be doing we can circle back and do it more consistently.
2021-07-12 13:05:49 -05:00
bchadwic
0a496317a5 added in the ability to view repository by commit hashes 2021-07-05 14:57:44 -07:00
Evan Silberman
49ff0c6530 Add a no-browser mode to gh browse
For when you just want the destination URL on stdout.
2021-07-02 17:12:16 -07:00
jlsestak
93118c65df
Merge pull request #52 from bchadwic/trunk
Update browse.go removed trailing newlines on errors
2021-06-16 20:53:06 -07:00
jlsestak
876b61af7b
Update browse.go 2021-06-16 20:50:08 -07:00
jlsestak
0a801c1ed5
Merge pull request #51 from bchadwic/trunk
Fixed parseFileArgs, reformatted tests
2021-06-15 20:14:44 -07:00
Jessica Sestak
b64488fe5c Changed parsefileArg to return a string, reformatted testing, polished up browse.go 2021-06-15 20:10:48 -07:00
Benjamin Chadwick
3d97aaf7f4
Merge pull request #49 from bchadwic/trunk
Fixed pr issues
2021-06-14 22:37:21 -07:00
bchadwic
679d396c8d reformatted spacing and final touches 2021-06-14 22:31:29 -07:00
ravocean
21691c8d2e Reorganized tests 2021-06-14 22:16:58 -07:00
ravocean
79da79fb68 We added new tests to bring the coverage to 90%+ 2021-06-14 21:40:52 -07:00
jlsestak
707897ffb6
Deleted extra space 2021-06-14 08:29:22 -07:00
bchadwic
9c7a788193 created more tests, and removed repoFlag 2021-06-13 21:05:50 -07:00
Jessica Sestak
7ea9d9164a Fixed TestNewCmdBrowse and added more tests 2021-06-13 20:16:19 -07:00
Jessica Sestak
edef757c6c Made more runBrowse tests 2021-06-12 22:36:03 -07:00
bchadwic
2b42ab92c3 refactored browse.go 2021-06-12 21:58:29 -07:00
Mislav Marohnić
7999a457ad Separate out NewCmdBrowse tests from runBrowse tests
Co-authored-by: Benjamin Chadwick <benchadwick87@gmail.com>
Co-authored-by: Jessica Sestak <jlsestak@gmail.com>
2021-06-11 18:53:34 +02:00
bchadwic
88ec5ad3b2 Fixing issues in the pr 2021-06-10 21:14:10 -07:00
Jessica Sestak
e5b81fb6a5 Started working on testing for parseFileArgs 2021-06-08 22:09:11 -07:00
Jessica Sestak
1657cf46c1 Fixed parsefileargs to throw errors with incorrect line numbers 2021-06-08 21:23:50 -07:00
Jessica Sestak
a96612c5e9 Fixed --repo to open with Args 2021-06-08 20:54:56 -07:00
bchadwic
98a5541d15 Started to fix the flags and the restrictions using them 2021-06-08 20:35:38 -07:00
bchadwic
95afca882b Finished refactoring now 2021-06-08 16:35:53 -07:00
bchadwic
506bd4b2de working on refactoring the output, the tests and how opts is structured 2021-06-08 15:36:11 -07:00
Benjamin Chadwick
698ca014c7
Merge pull request #38 from bchadwic/trunk
Redefined browse output, and added in more test cases
2021-06-08 13:12:48 -07:00
Benjamin Chadwick
9fe986a480
Update pkg/cmd/browse/browse.go
Co-authored-by: Mislav Marohnić <hi@mislav.net>
2021-06-08 12:48:17 -07:00