Commit graph

8180 commits

Author SHA1 Message Date
Meredith Lancaster
bb5136007e
Merge pull request #9838 from malancas/attestation-clean-up-tests
Clean up skipped online tests for `gh attestation verify`
2024-10-30 13:28:44 -06:00
Andy Feller
3b4301f62a
Merge pull request #9845 from cli/andyfeller/9807-repo-edit-visibility-confirmation
Require visibility confirmation in `gh repo edit`
2024-10-30 15:20:51 -04:00
Andy Feller
3f5fc85e41 Assert stderr for gh repo edit visibility tests 2024-10-30 13:31:00 -04:00
Andy Feller
15b2db9277 Require visibility confirmation in gh repo edit
This commit modifies interactive and non-interactive behaviors around `gh repo edit` as well as providing greater information about the impact.

1. `--help` usage is expanded to highlight the most significant consequences of changing visibility
1. `--help` usage and interactive experience call out GitHub Docs content that act as source of truth about full consequences of various changes
1. `gh repo edit` interactive experience will require confirmation for any visibility change
1. `gh repo edit` interactive experience will output potential stars and watchers lose regardless of visibility transition
1. `gh repo edit` will require `--visibility` flag to include new `--accept-visibility-change-consequences` flag regardless of interactivity
2024-10-29 10:25:04 -04:00
Meredith Lancaster
8a8f224a7a fix test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 15:28:00 -06:00
Meredith Lancaster
4ec696dacd create common test fixture, organize tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:40:48 -06:00
Meredith Lancaster
502856082e table tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:40:23 -06:00
Meredith Lancaster
f8b0f5e687 clean up test
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 13:02:12 -06:00
Meredith Lancaster
ce5bde4379 simplify signer workflow validation tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 12:59:04 -06:00
Meredith Lancaster
a820457b09 clean up skipped online tests
Signed-off-by: Meredith Lancaster <malancas@github.com>
2024-10-28 11:47:31 -06:00
William Martin
14d339d9ba
Merge pull request #9810 from cli/andyfeller/testscript-extension
Add comprehensive testscript for gh ext commandset
2024-10-28 13:05:32 +01:00
Andy Feller
37da12a9d2 Rename similar to other coarse commandset tests
Based on insights gained from reviewing conventions in #9815 with @jtmcg, I'm renaming this testscript to keep consistent with `gpg-key`, `label`, `ssh-key`, etc.
2024-10-28 12:54:50 +01:00
Andy Feller
911f070936 Skip extension testscript if bash isn't available
As this testscript creates a Bash-based script extension, the testscript should be skipped if it isn't on the path and executable.

Ideally, we would refactor this test to isolate that portion of the tests OR switch to a Go-based extension that can be compiled and run everywhere.
2024-10-28 12:54:50 +01:00
Andy Feller
ed24477fd3 Add comprehensive testscript for gh ext commandset
Rather than multiple separate testscripts per `gh ext` subcommand, this commit adds a comprehensive test around `gh extension` commandset.
2024-10-28 12:54:47 +01:00
William Martin
7066cdeb26
Merge pull request #9815 from cli/andyfeller/testscripts-ruleset
Add comprehensive testscript for `gh ruleset`
2024-10-28 12:52:24 +01:00
Andy Feller
6dc86e5f40 Rename testscript for consistency
Similar to `gpg-key`, `label`, `ssh-key`, this coarse grained testscript should be named after the commandset given it isn't a collection of targeted scenarios.
2024-10-28 12:40:15 +01:00
Andy Feller
c27677bda6 Add comprehensive testscript for gh ruleset 2024-10-28 12:40:12 +01:00
William Martin
f35c123b71
Merge pull request #9816 from cli/jtmcg/testscripts-project
Add acceptance test for `project` command
2024-10-28 12:24:53 +01:00
William Martin
a381ca5dc4
Merge pull request #9821 from cli/hard-fork-go-internal
Update testscript to use hard fork
2024-10-25 18:21:52 +02:00
Tyler McGoffin
7a5dc50324 Modify script to use the project number returned by the api upon creation 2024-10-25 09:03:50 -07:00
William Martin
30d9fc53d1 Update testscript to use hard fork 2024-10-25 16:29:23 +02:00
Tyler McGoffin
7148304344 Add acceptance test for project-create and project-delete 2024-10-24 12:53:52 -07:00
Tyler McGoffin
8b5c5385c7 Add TestProject to acceptance_test.go 2024-10-24 12:18:56 -07:00
Tyler McGoffin
31e8a87598 Alphabetize test functions
While swarming on this, I've encountered many merge conflicts based on
where folks have introduced new test functions. Alphabetizing them should
reduce the number of merge conflicts we encounter while introducing more
of these tests moving forward
2024-10-24 10:01:39 -07:00
Kynan Ware
44ee177607
Merge pull request #9813 from cli/wm/update-acceptance-test-redaction
Note token redaction in Acceptance test README
2024-10-24 10:47:44 -06:00
William Martin
2a2adfed0f
Merge pull request #9787 from cli/jtmcg/testscripts-auth
Add acceptance tests for `gh auth` commands
2024-10-24 18:42:31 +02:00
William Martin
366aea95eb Note token redaction in Acceptance test README 2024-10-24 18:35:30 +02:00
William Martin
0880dc4d79
Merge pull request #9812 from cli/wm-kw/ssh-key-and-org-testscripts.txtar
Add acceptance tests for `org` and `ssh-key` commands
2024-10-24 18:30:47 +02:00
bagtoad
f72a82db99 Refactor gpg-key delete to align with ssh-key delete 2024-10-24 09:59:02 -06:00
bagtoad
2f849f03ff Add acceptance tests for org command 2024-10-24 09:58:06 -06:00
William Martin
d4c70009bf
Adjust environment help for host and tokens (#9809) 2024-10-24 17:54:27 +02:00
William Martin
76e6fbba36 Add SSH Key Acceptance test 2024-10-24 17:46:17 +02:00
William Martin
ff9b0a1c64
Merge pull request #9811 from cli/wm-kw/github-cli-636-add-testscript-for-gpg-key
Add testscripts for gpg-key and label commands
2024-10-24 17:21:02 +02:00
William Martin
4100992d40 Add Acceptance test for label command 2024-10-24 17:00:54 +02:00
bagtoad
f27cddcb92 Add acceptance test for gpg-key 2024-10-24 08:43:40 -06:00
William Martin
fc4d7e44fd
Merge pull request #9804 from cli/wm/redact-tokens-from-acceptance
Use forked testscript for token redaction
2024-10-24 16:24:44 +02:00
William Martin
787a243323 Update go-internal to redact more token types in Acceptance tests 2024-10-24 15:14:51 +02:00
Tyler McGoffin
2b480daf7a Address PR feedback 2024-10-23 13:57:57 -07:00
Andy Feller
8513824ef8
Merge pull request #9805 from cli/kw/clarify-gh-is-available-for-GHEC
Clarify in README that `gh` is supported on GitHub Enterprise Cloud
2024-10-23 16:55:35 -04:00
Kynan Ware
15d86bbdf8
Clarify gh is available for GitHub Enterprise Cloud 2024-10-23 14:44:13 -06:00
Tyler McGoffin
59aedc4e89 Remove comment from gh auth logout 2024-10-23 13:33:17 -07:00
Tyler McGoffin
0614d85027 Add acceptance tests for auth-setup-git and formattedStringToEnv helper func
To test this, I decided to look into the .gitconfig used for the test and
examine the credential helpers. However, the format of the git command is

`git config --get credential.<URL>.helper`

What's awkward about this is that the <URL> depends on the host the user
specified when running the tests, meaning I'd need to create a key like
credential.https://github.com.helper to access what I need while setting
this up.

There was no functionality for string formatting before, so I added the
command formattedStringToEnv which essentially wraps fmt.Sprintf() and
saves the string to an environment variable.

This allowed me to dynamically create the config key in the test.
2024-10-23 13:33:17 -07:00
Phill MV
afa4272bdf
Merge pull request #9797 from cli/phillmv/retry-getting-attestations
`gh at verify` retries fetching attestations if it receives a 5xx
2024-10-23 13:45:09 -04:00
William Martin
2433475d3f Use forked testscript for token redaction 2024-10-23 14:13:26 +02:00
Kynan Ware
e390874fef
Merge pull request #9799 from cli/kw/attestation-use-new-github-previews-terminology
Use new GitHub previews terminology in attestation commands' help docs
2024-10-22 13:20:33 -06:00
Kynan Ware
fd56fec110
Merge pull request #9800 from cli/kw/update-docs-with-github-preview-terminology
Use new GitHub preview terms in `working-with-us.md`
2024-10-22 12:40:14 -06:00
bagtoad
abb2772696 Use new GitHub preview terms in working-with-us.md
Update the "working with us" docs to align with new GitHub previews terminology, replacing `beta` with `public preview`.

https://github.blog/changelog/2024-10-18-new-terminology-for-github-previews/
2024-10-22 10:56:39 -06:00
bagtoad
04add8d68f Use new GitHub previews terminology in attestation
Update attestations commands to align with new GitHub previews terminology, replacing `beta` with `public preview`.

https://github.blog/changelog/2024-10-18-new-terminology-for-github-previews/
2024-10-22 10:50:00 -06:00
Andy Feller
34f1b50acc
Merge pull request #9784 from cli/andyfeller/testscripts-variable
Add acceptance tests for `variable` commands
2024-10-22 10:04:21 -04:00
William Martin
ad7c29dc5c
Merge pull request #9790 from tsukasaI/feature/add-archived-timestamp
Add archivedAt json field to repo view and list
2024-10-22 14:03:58 +02:00